DGNum/Stirling-PDF
14
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

[Bug Fix] Multiple Bug Fixes (#1836)

Browse source 
* Fix the add file button on the multi-tools page.

* Fix a bug where the page numbers wouldn't be removed on page move on Firefox.

---------

Co-authored-by: kazandaki <ahmetfiratusta@gmail.com>
This commit is contained in:
FiratUsta 2024-09-07 23:40:19 +03:00 committed by GitHub
parent 3c04486348
commit 82219dd899
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/resources/static/js/multitool/PdfActionsManager.js
View file

@ -78,7 +78,7 @@ class PdfActionsManager {
imgContainer.classList.toggle("split-before"); imgContainer.classList.toggle("split-before");
} }
setActions({ movePageTo, addPdfs, rotateElement }) { setActions({ movePageTo, addFiles, rotateElement }) {
this.movePageTo = movePageTo; this.movePageTo = movePageTo;
this.addFiles = addFiles; this.addFiles = addFiles;
this.rotateElement = rotateElement; this.rotateElement = rotateElement;

7
src/main/resources/static/js/multitool/PdfContainer.js
View file

@ -53,6 +53,13 @@ class PdfContainer {
const childArray = Array.from(this.pagesContainer.childNodes); const childArray = Array.from(this.pagesContainer.childNodes);
const startIndex = childArray.indexOf(startElement); const startIndex = childArray.indexOf(startElement);
const endIndex = childArray.indexOf(endElement); const endIndex = childArray.indexOf(endElement);
// Check & remove page number elements here too if they exist because Firefox doesn't fire the relevant event on page move.
const pageNumberElement = startElement.querySelector(".page-number");
if (pageNumberElement) {
startElement.removeChild(pageNumberElement);
}
this.pagesContainer.removeChild(startElement); this.pagesContainer.removeChild(startElement);
if (!endElement) { if (!endElement) {
this.pagesContainer.append(startElement); this.pagesContainer.append(startElement);