DGNum/Stirling-PDF
14
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Merge pull request #766 from Stirling-Tools/pixeebot/drip-2024-02-01-pixee-java/limit-readline

Browse source 
Protect `readLine()` against DoS
This commit is contained in:
Anthony Stirling 2024-02-01 23:05:22 +00:00 committed by GitHub
commit 6105451e08
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/main/java/stirling/software/SPDF/utils/ProcessExecutor.java
View file

@ -1,5 +1,6 @@
package stirling.software.SPDF.utils;
import io.github.pixee.security.BoundedLineReader;
import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
@ -109,7 +110,7 @@ public class ProcessExecutor {
process.getErrorStream(),
StandardCharsets.UTF_8))) {
String line;
while ((line = errorReader.readLine()) != null) {
while ((line = BoundedLineReader.readLine(errorReader, 5_000_000)) != null) {
errorLines.add(line);
if (liveUpdates) logger.info(line);
}
@ -130,7 +131,7 @@ public class ProcessExecutor {
process.getInputStream(),
StandardCharsets.UTF_8))) {
String line;
while ((line = outputReader.readLine()) != null) {
while ((line = BoundedLineReader.readLine(outputReader, 5_000_000)) != null) {
outputLines.add(line);
if (liveUpdates) logger.info(line);
}