DGNum/Stirling-PDF
15
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Merge pull request #1396 from Stirling-Tools/pixeebot/drip-2024-06-07-sonar-java/add-missing-override-s1161

Browse source 
(Sonar) Fixed finding: "`@Override` should be used on overriding and implementing methods"
This commit is contained in:
Anthony Stirling 2024-06-07 06:27:02 +01:00 committed by GitHub
commit 32b3cfca41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/main/java/stirling/software/SPDF/config/security/AppUpdateAuthService.java
View file

@ -18,6 +18,7 @@ class AppUpdateAuthService implements ShowAdminInterface {
@Autowired private UserRepository userRepository; @Autowired private UserRepository userRepository;
@Autowired private ApplicationProperties applicationProperties; @Autowired private ApplicationProperties applicationProperties;
@Override
public boolean getShowUpdateOnlyAdmins() { public boolean getShowUpdateOnlyAdmins() {
boolean showUpdate = applicationProperties.getSystem().getShowUpdate(); boolean showUpdate = applicationProperties.getSystem().getShowUpdate();
if (!showUpdate) { if (!showUpdate) {

2
src/main/java/stirling/software/SPDF/model/ApplicationProperties.java
View file

@ -559,6 +559,7 @@ public class ApplicationProperties {
this.clientSecret = clientSecret; this.clientSecret = clientSecret;
} }
@Override
public Collection<String> getScopes() { public Collection<String> getScopes() {
if (scopes == null || scopes.isEmpty()) { if (scopes == null || scopes.isEmpty()) {
scopes = new ArrayList<>(); scopes = new ArrayList<>();
@ -661,6 +662,7 @@ public class ApplicationProperties {
return scopes; return scopes;
} }
@Override
public void setScopes(String scopes) { public void setScopes(String scopes) {
this.scopes = this.scopes =
Arrays.stream(scopes.split(",")).map(String::trim).collect(Collectors.toList()); Arrays.stream(scopes.split(",")).map(String::trim).collect(Collectors.toList());