This change makes Gerrit run as the 'git' user, which can be shared by
other services such as hound or cgit to access the git trees.
Change-Id: Ic6c91f3e852184f5ef21f4374738cbf687462194
Reviewed-on: https://cl.tvl.fyi/c/depot/+/21
Reviewed-by: lukegb <lukegb@tvl.fyi>
Reviewed-by: isomer <isomer@tvl.in>
Quoting myself from IRC, for those who missed it:
-------------
Alright, some of you might be wondering what 'UNDERGOING CHANGES'
means. The gist of it is that TVL has kind of departed from what it
was originally (a place for friends of mine to hang out) by growing a
little too fast, and I've decided to do a bit of a reboot.
What this means is that for most people I don't know directly, I'll be
asking you to leave (I'll +v/-v accordingly) and see if we can get the
original TVL crowd back before opening it for a wider audience again.
The "opening hours" (heh) will also be more restricted again.
Some people will be a little unhappy about this, but the good news is
that you can easily make your own Meet and use that! Some folks even
started an alternative EU-daytime lounge already. But for now, with
this particular one, it'll be s/The V/tazjin's V/.
----------------
Clang treats function-like macros "correctly", in that, per the C11 spec:
"Each subsequent instance of the function-like macro name followed by a (
[...] is replaced by the replacement list [...]".
Additionally, fprintf is also permitted to be defined as a function-like
macro rather than as a true function: "Any function declared in a header
may be additionally implemented as a function-like macro defined in the
header [...]". The specification then suggests surrounding the name of the
function in parens to avoid this, which is the technique we use here to avoid
the function-like macro being invoked.
The other fix here is to use uintptr_t for some arithmetic, since Git
is expecting an int as the value here and not a pointer.
Having a colon in the path may cause issues, and having the hash
function indicated isn't actually necessary. We now verify the path
format in the tests to prevent regressions.
(cherry picked from commit c65a6fa86aef7bdf51fb4fba7bd31d265619ba3f)
This makes the paths consistent without relying on ordering.
Co-authored-by: edef <edef@edef.eu>
(cherry picked from commit 515c0a263e137a00e82f7d981284dbe54db23247)
