From f41b611761cd7fa88ddfdf922eef7ec789903b81 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 21 Jul 2023 14:32:30 +0300 Subject: [PATCH] feat(nix/buildkite): add meta.ci.buildkiteExtraDeps This allows setting a buildkiteExtraDeps in `meta.ci`, which will get added to `depends_on` (which can also be a list). It allows explicitly describing a dependency on another buildkite step, either generated by nix/buildkite, or part of the static pipeline. At some point we might want to expose our key calculation function too, similar to how readTree exposes mkLabel already, but that's left for a followup. Change-Id: I793170401ccd3907ad8bf232b80ca7a492e1c942 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8980 Reviewed-by: tazjin Autosubmit: flokli Tested-by: BuildkiteCI --- nix/buildkite/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nix/buildkite/default.nix b/nix/buildkite/default.nix index ec148050b..08be8f38c 100644 --- a/nix/buildkite/default.nix +++ b/nix/buildkite/default.nix @@ -83,7 +83,7 @@ rec { # Add a dependency on the initial static pipeline step which # always runs. This allows build steps uploaded in batches to # start running before all batches have been uploaded. - depends_on = ":init:"; + depends_on = [ ":init:" ] ++ lib.optionals (target ? meta.ci.buildkiteExtraDeps) target.meta.ci.buildkiteExtraDeps; } // lib.optionalAttrs (target ? meta.timeout) { timeout_in_minutes = target.meta.timeout / 60; };