From e66dcba19549a0a108f93b17feafb8084a1e67a1 Mon Sep 17 00:00:00 2001 From: Aspen Smith Date: Fri, 5 Jan 2024 11:10:37 -0500 Subject: [PATCH] fix(tvix/eval): Update eval benches for new API cl/10475 updated the API of tvix_eval::Evaluation, but didn't update this benchmark to use that new API. Also, fixes the docstring to no longer specify that there is a "given snippet". Change-Id: Ibb8285731849dbeec814e2585bbaa36f22368afe Reviewed-on: https://cl.tvl.fyi/c/depot/+/10542 Autosubmit: aspen Tested-by: BuildkiteCI Reviewed-by: tazjin Reviewed-by: flokli --- tvix/eval/benches/eval.rs | 2 +- tvix/eval/src/lib.rs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tvix/eval/benches/eval.rs b/tvix/eval/benches/eval.rs index fecf0db1b..4e9be8f8f 100644 --- a/tvix/eval/benches/eval.rs +++ b/tvix/eval/benches/eval.rs @@ -2,7 +2,7 @@ use criterion::{black_box, criterion_group, criterion_main, Criterion}; use itertools::Itertools; fn interpret(code: &str) { - tvix_eval::Evaluation::new(code, None).evaluate(); + tvix_eval::Evaluation::default().evaluate(code, None); } fn eval_literals(c: &mut Criterion) { diff --git a/tvix/eval/src/lib.rs b/tvix/eval/src/lib.rs index ddc281323..f852b1a32 100644 --- a/tvix/eval/src/lib.rs +++ b/tvix/eval/src/lib.rs @@ -154,8 +154,7 @@ impl<'co, 'ro> Default for Evaluation<'co, 'ro> { impl<'co, 'ro> Evaluation<'co, 'ro> { #[cfg(feature = "impure")] - /// Initialise an `Evaluation` for the given snippet, with all - /// impure features turned on by default. + /// Initialise an `Evaluation`, with all impure features turned on by default. pub fn new_impure() -> Self { let mut eval = Self { enable_import: true,