From e09b44bdec0167a6e1fec23e5ca294033814dbeb Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Mon, 12 Apr 2021 19:30:17 +0200 Subject: [PATCH] chore(besadii): Stop passing explicit messages to Buildkite Dropping the message field will make Buildkite use the commit messages instead, which makes for much more readable build logs. Change-Id: I1849f811632526893b700f117c9f6cf64888c329 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2949 Tested-by: BuildkiteCI Reviewed-by: sterni --- ops/besadii/main.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ops/besadii/main.go b/ops/besadii/main.go index 998c67701..7972df74d 100644 --- a/ops/besadii/main.go +++ b/ops/besadii/main.go @@ -56,28 +56,22 @@ type Author struct { type Build struct { Commit string `json:"commit"` Branch string `json:"branch"` - Message string `json:"message"` Author Author `json:"author"` Env map[string]string `json:"env"` } // Trigger a build of a given branch & commit on Buildkite func triggerBuild(log *syslog.Writer, token string, update *refUpdated) error { - var message string env := make(map[string]string) if update.changeId != nil && update.patchset != nil { env["GERRIT_CHANGE_ID"] = *update.changeId env["GERRIT_PATCHSET"] = *update.patchset - message = fmt.Sprintf(":llama: depot @ https://cl.tvl.fyi/c/depot/+/%s/%s", *update.changeId, *update.patchset) - } else { - message = fmt.Sprintf(":llama: depot @ %s", update.commit) } build := Build{ Commit: update.commit, Branch: update.ref, - Message: message, Env: env, Author: Author{ Name: update.submitter,