diff --git a/tvix/nar-bridge/pkg/writer/writer.go b/tvix/nar-bridge/pkg/exporter/export.go similarity index 98% rename from tvix/nar-bridge/pkg/writer/writer.go rename to tvix/nar-bridge/pkg/exporter/export.go index fd154e061..40ccc4b63 100644 --- a/tvix/nar-bridge/pkg/writer/writer.go +++ b/tvix/nar-bridge/pkg/exporter/export.go @@ -1,4 +1,4 @@ -package writer +package exporter import ( "fmt" @@ -13,7 +13,7 @@ import ( type DirectoryLookupFn func([]byte) (*castorev1pb.Directory, error) type BlobLookupFn func([]byte) (io.ReadCloser, error) -// Export will traverse a given pathInfo structure, and write the contents +// Export will traverse a given PathInfo structure, and write the contents // in NAR format to the passed Writer. // It uses directoryLookupFn and blobLookupFn to resolve references. func Export( diff --git a/tvix/nar-bridge/pkg/writer/writer_test.go b/tvix/nar-bridge/pkg/exporter/export_test.go similarity index 93% rename from tvix/nar-bridge/pkg/writer/writer_test.go rename to tvix/nar-bridge/pkg/exporter/export_test.go index 881045b17..ffee62f29 100644 --- a/tvix/nar-bridge/pkg/writer/writer_test.go +++ b/tvix/nar-bridge/pkg/exporter/export_test.go @@ -1,4 +1,4 @@ -package writer_test +package exporter_test import ( "bytes" @@ -10,8 +10,8 @@ import ( "testing" castorev1pb "code.tvl.fyi/tvix/castore/protos" + "code.tvl.fyi/tvix/nar-bridge/pkg/exporter" "code.tvl.fyi/tvix/nar-bridge/pkg/importer" - "code.tvl.fyi/tvix/nar-bridge/pkg/writer" storev1pb "code.tvl.fyi/tvix/store/protos" "github.com/stretchr/testify/require" "lukechampine.com/blake3" @@ -49,7 +49,7 @@ func TestSymlink(t *testing.T) { var buf bytes.Buffer - err := writer.Export(&buf, pathInfo, func([]byte) (*castorev1pb.Directory, error) { + err := exporter.Export(&buf, pathInfo, func([]byte) (*castorev1pb.Directory, error) { panic("no directories expected") }, func([]byte) (io.ReadCloser, error) { panic("no files expected") @@ -90,7 +90,7 @@ func TestRegular(t *testing.T) { var buf bytes.Buffer - err := writer.Export(&buf, pathInfo, func([]byte) (*castorev1pb.Directory, error) { + err := exporter.Export(&buf, pathInfo, func([]byte) (*castorev1pb.Directory, error) { panic("no directories expected") }, func(blobRef []byte) (io.ReadCloser, error) { if !bytes.Equal(blobRef, BLAKE3_DIGEST_0X01) { @@ -134,7 +134,7 @@ func TestEmptyDirectory(t *testing.T) { var buf bytes.Buffer - err := writer.Export(&buf, pathInfo, func(directoryRef []byte) (*castorev1pb.Directory, error) { + err := exporter.Export(&buf, pathInfo, func(directoryRef []byte) (*castorev1pb.Directory, error) { if !bytes.Equal(directoryRef, emptyDirectoryDigest) { panic("unexpected directoryRef") } @@ -196,7 +196,7 @@ func TestFull(t *testing.T) { // done populating everything, now actually test the export :-) var buf bytes.Buffer - err = writer.Export( + err = exporter.Export( &buf, pathInfo, func(directoryDgst []byte) (*castorev1pb.Directory, error) { diff --git a/tvix/nar-bridge/pkg/writer/writer_pick_next_node_test.go b/tvix/nar-bridge/pkg/exporter/pick_next_node_test.go similarity index 98% rename from tvix/nar-bridge/pkg/writer/writer_pick_next_node_test.go rename to tvix/nar-bridge/pkg/exporter/pick_next_node_test.go index d69adca89..c80261ae6 100644 --- a/tvix/nar-bridge/pkg/writer/writer_pick_next_node_test.go +++ b/tvix/nar-bridge/pkg/exporter/pick_next_node_test.go @@ -1,4 +1,4 @@ -package writer +package exporter import ( "testing" diff --git a/tvix/nar-bridge/pkg/server/nar_get.go b/tvix/nar-bridge/pkg/server/nar_get.go index 739799261..3ccb8d658 100644 --- a/tvix/nar-bridge/pkg/server/nar_get.go +++ b/tvix/nar-bridge/pkg/server/nar_get.go @@ -13,7 +13,7 @@ import ( "sync" castorev1pb "code.tvl.fyi/tvix/castore/protos" - "code.tvl.fyi/tvix/nar-bridge/pkg/writer" + "code.tvl.fyi/tvix/nar-bridge/pkg/exporter" storev1pb "code.tvl.fyi/tvix/store/protos" "github.com/go-chi/chi/v5" nixhash "github.com/nix-community/go-nix/pkg/hash" @@ -94,7 +94,7 @@ func renderNar( } // render the NAR file - err := writer.Export( + err := exporter.Export( w, pathInfo, func(directoryDigest []byte) (*castorev1pb.Directory, error) {