From cbd22af2b5577d588815e8b59b27c98befc57c46 Mon Sep 17 00:00:00 2001 From: Ryan Lahfa Date: Tue, 26 Dec 2023 01:05:46 +0100 Subject: [PATCH] chore(tvix/eval): note on context-aware `hashString` It must propagate context too. Change-Id: If57c22c9723ea02aa013f69d3dcf96054476d8de Reviewed-on: https://cl.tvl.fyi/c/depot/+/10433 Tested-by: BuildkiteCI Autosubmit: raitobezarius Reviewed-by: tazjin --- tvix/eval/src/builtins/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 89ab5edb1..fa84afb70 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -588,6 +588,7 @@ mod pure_builtins { _algo: Value, _string: Value, ) -> Result { + // FIXME: propagate contexts here. Ok(Value::Catchable(CatchableErrorKind::UnimplementedFeature( "hashString".to_string(), )))