From 962df219f76014816404e2ee4c82db01c899877b Mon Sep 17 00:00:00 2001 From: sterni Date: Mon, 2 Dec 2024 23:54:45 +0100 Subject: [PATCH] chore(3p/lisp/closure-*): disable on ECL for now As it turns out, some of the load/compile time set up the package does doesn't work in ECL for unknown reasons at the moment. Executables using closure-* will crash after starting up: ;;; Checking for wide character support... WARNING: Lisp implementation doesn't use UTF-16, but accepts surrogate code points. yes, using code points. ;;; Building Closure with CHARACTER RUNES Condition of type: SIMPLE-ERROR Invalid relative pathname #P"package.lisp" for component ("closure-common" "package") Change-Id: I4b4bf96835a39696884ec6fea9c249fdeb53c853 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12863 Reviewed-by: sterni Autosubmit: sterni Tested-by: BuildkiteCI --- third_party/lisp/closure-common.nix | 5 +++++ third_party/lisp/closure-html/default.nix | 6 +++++- users/sterni/mblog/default.nix | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/third_party/lisp/closure-common.nix b/third_party/lisp/closure-common.nix index 7f7f79f85..164e75233 100644 --- a/third_party/lisp/closure-common.nix +++ b/third_party/lisp/closure-common.nix @@ -33,4 +33,9 @@ depot.nix.buildLisp.library { depot.third_party.lisp.trivial-gray-streams depot.third_party.lisp.babel #+rune-is-character ]; + + brokenOn = [ + # TODO(sterni): fails when loading because it tries to access package.lisp at runtime + "ecl" + ]; } diff --git a/third_party/lisp/closure-html/default.nix b/third_party/lisp/closure-html/default.nix index 1886ea2ec..5e9eacdcb 100644 --- a/third_party/lisp/closure-html/default.nix +++ b/third_party/lisp/closure-html/default.nix @@ -9,7 +9,7 @@ let # delete unexported and unused double defun in sgml-dtd.lisp # which reference undefined CL-USER:*HTML-DTD* (!) which # unlike CLOSURE-HTML:*HTML-DTD* is not involved in the - # packages operation. + # package's operation. ./no-double-defun.patch # Patches html-parser.lisp to look for the distributed # dtd files and catalog in this source derivations out @@ -62,4 +62,8 @@ depot.nix.buildLisp.library { depot.third_party.lisp.flexi-streams depot.third_party.lisp.closure-common ]; + + brokenOn = [ + "ecl" # see closure-common + ]; } diff --git a/users/sterni/mblog/default.nix b/users/sterni/mblog/default.nix index e9a1d304f..1211dea01 100644 --- a/users/sterni/mblog/default.nix +++ b/users/sterni/mblog/default.nix @@ -32,7 +32,7 @@ main = "cli:main"; brokenOn = [ - "ecl" + "ecl" # closure-common fails to start up ]; }).overrideAttrs (super: { # The built binary dispatches based on argv[0]. Building two executables would