From 8b870c7ec91eb85f7e37eba8cffe022067865ab7 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Mon, 24 Jul 2023 11:55:57 +0300 Subject: [PATCH] feat(nix/buildkite): add meta.ci.buildkiteExtraStepArgs This allows setting / overwriting arbitrary step arguments, such as setting [Retry attributes](https://buildkite.com/docs/pipelines/command-step#retry-attributes) for a specific readTree target. It's intended to be used for cases where modelling each and every option in a custom meta.ci attribute would be unfeasible. Change-Id: I3352d5353b26a41a16760a7df37cd5ffee1665bb Reviewed-on: https://cl.tvl.fyi/c/depot/+/8983 Autosubmit: flokli Reviewed-by: tazjin Tested-by: BuildkiteCI --- nix/buildkite/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nix/buildkite/default.nix b/nix/buildkite/default.nix index 08be8f38c..c53d58eec 100644 --- a/nix/buildkite/default.nix +++ b/nix/buildkite/default.nix @@ -86,7 +86,9 @@ rec { depends_on = [ ":init:" ] ++ lib.optionals (target ? meta.ci.buildkiteExtraDeps) target.meta.ci.buildkiteExtraDeps; } // lib.optionalAttrs (target ? meta.timeout) { timeout_in_minutes = target.meta.timeout / 60; - }; + # Additional arguments to set on the step. + # Keep in mind these *overwrite* existing step args, not extend. Use with caution. + } // lib.optionalAttrs (target ? meta.ci.buildkiteExtraStepArgs) target.meta.ci.buildkiteExtraStepArgs; # Helper function to inelegantly divide a list into chunks of at # most n elements.