From 86a205220fdc0e3789f8f42eb30e93115777a0b0 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 14 Jan 2022 23:21:56 +0300 Subject: [PATCH] fix(gerrit-tvl): Explicitly specify patchset on check runs Since we now group patchsets inside of Buildkite, the results are no longer guaranteed to be for the right patchset. There might be some metadata passed in from Gerrit that would let us do this with the commit ID instead, but I haven't checked. Change-Id: I5b74a17697511160fcc89d3dbef23517d974dc6f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4890 Tested-by: BuildkiteCI Reviewed-by: lukegb Autosubmit: tazjin --- ops/gerrit-tvl/static/tvl.js | 1 + 1 file changed, 1 insertion(+) diff --git a/ops/gerrit-tvl/static/tvl.js b/ops/gerrit-tvl/static/tvl.js index 899e01965..7019624b5 100644 --- a/ops/gerrit-tvl/static/tvl.js +++ b/ops/gerrit-tvl/static/tvl.js @@ -113,6 +113,7 @@ const tvlChecksProvider = { for (let job of build.jobs) { // TODO(lukegb): add the ability to retry these const checkRun = { + patchset: parseInt(build.env.GERRIT_PATCHSET, 10), attempt: attempt, externalId: job.id, checkName: job.name,