From 76839683a7ab0453afcdc3374a5cc80cca2f9510 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 17 Aug 2024 20:03:44 +0300 Subject: [PATCH] fix(tvix/boot): workaround test flakiness The boot tests are sometimes flaky, and we don't want them to periodically fail other build. Have Buildkite auto-retry them 2 times on failure. Logs for individual failures are still available, so it won't hinder flakiness debuggability. See https://buildkite.com/docs/pipelines/command-step#retry-attributes for a documentation of a parameter, and cl/8983 for the introduction of that feature to //nix/buildkite. Change-Id: I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12228 Autosubmit: flokli Reviewed-by: Ilan Joselevich Tested-by: BuildkiteCI --- tvix/boot/tests/default.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tvix/boot/tests/default.nix b/tvix/boot/tests/default.nix index 7b9fbbbf8..d078287a7 100644 --- a/tvix/boot/tests/default.nix +++ b/tvix/boot/tests/default.nix @@ -119,6 +119,14 @@ let grep "${assertVMOutput}" output.txt ''; requiredSystemFeatures = [ "kvm" ]; + # HACK: The boot tests are sometimes flaky, and we don't want them to + # periodically fail other build. Have Buildkite auto-retry them 2 times + # on failure. + # Logs for individual failures are still available, so it won't hinder + # flakiness debuggability. + meta.ci.buildkiteExtraStepArgs = { + retry.automatic = true; + }; } // lib.optionalAttrs (isClosure && !useNarBridge) { __structuredAttrs = true; exportReferencesGraph.closure = [ path ];