From 761f9ce38462f2b6333f614969daecc0310d42d6 Mon Sep 17 00:00:00 2001 From: sterni Date: Thu, 2 Sep 2021 01:17:50 +0200 Subject: [PATCH] docs(3p/lisp/closure-common): mention need for ASDF, feature macros MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Luckily we don't need to deal with this mess since all our implementations work similarly wrt streams and “wide” characters. Change-Id: I3ccc606a59c42791f2591d752673c867d848a332 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3485 Tested-by: BuildkiteCI Reviewed-by: grfn --- third_party/lisp/closure-common.nix | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/third_party/lisp/closure-common.nix b/third_party/lisp/closure-common.nix index de983dda3..591620e48 100644 --- a/third_party/lisp/closure-common.nix +++ b/third_party/lisp/closure-common.nix @@ -14,25 +14,30 @@ in depot.nix.buildLisp.library { name = "closure-common"; - # feature specific file inclusions in closure-common.asd; - # including all relevant fails for SBCL, may not build with - # other implementations in this form. + # closure-common.asd surpresses some warnings otherwise breaking + # compilation. Feature macros across implementations: + # + # ECL #+rune-is-character #-rune-is-integer #-x&y-streams-are-stream + # CCL #+rune-is-character #-rune-is-integer #-x&y-streams-are-stream + # SBCL #+rune-is-character #-rune-is-integer #-x&y-streams-are-stream + # + # Since all implementations agree, the alternative files aren't encoded here. srcs = getSrcs [ "closure-common.asd" "package.lisp" "definline.lisp" - "characters.lisp" + "characters.lisp" #+rune-is-character "syntax.lisp" - "encodings.lisp" - "encodings-data.lisp" - "xstream.lisp" - "ystream.lisp" + "encodings.lisp" #-x&y-streams-are-stream + "encodings-data.lisp" #-x&y-streams-are-stream + "xstream.lisp" #-x&y-streams-are-stream + "ystream.lisp" #-x&y-streams-are-stream "hax.lisp" ]; deps = [ (depot.nix.buildLisp.bundled "asdf") depot.third_party.lisp.trivial-gray-streams - depot.third_party.lisp.babel + depot.third_party.lisp.babel #+rune-is-character ]; }