diff --git a/tvix/castore/src/fs/mod.rs b/tvix/castore/src/fs/mod.rs index 52355bdfb..21c6f020a 100644 --- a/tvix/castore/src/fs/mod.rs +++ b/tvix/castore/src/fs/mod.rs @@ -553,7 +553,7 @@ where // drop it, which will close it. Some(rx) => drop(rx), None => { - debug!("dir handle not found"); + warn!("dir handle not found"); } } } @@ -623,7 +623,7 @@ where } } - #[tracing::instrument(skip_all, fields(rq.inode = inode, fh = handle))] + #[tracing::instrument(skip_all, fields(rq.inode = inode, rq.handle = handle))] fn release( &self, _ctx: &Context, @@ -634,13 +634,12 @@ where _flock_release: bool, _lock_owner: Option, ) -> io::Result<()> { - // remove and get ownership on the blob reader match self.file_handles.write().remove(&handle) { - // drop it, which will close it. + // drop the blob reader, which will close it. Some(blob_reader) => drop(blob_reader), None => { // These might already be dropped if a read error occured. - debug!("file_handle {} not found", handle); + warn!("file handle not found"); } }