From 2f73d1db6c2ec107a9af1572f023b6c95133229c Mon Sep 17 00:00:00 2001
From: William Carroll <wpcarro@gmail.com>
Date: Tue, 28 Jul 2020 10:12:25 +0100
Subject: [PATCH] Prefer NoContent response to Bool

When I first wrote this handler I wasn't aware of the NoContent response
option.
---
 src/API.hs | 2 +-
 src/App.hs | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/API.hs b/src/API.hs
index f858e6d7a..ef185e246 100644
--- a/src/API.hs
+++ b/src/API.hs
@@ -17,4 +17,4 @@ type API = "user"
            :> Get  '[JSON] (Maybe T.Account)
       :<|> "trip"
            :> ReqBody '[JSON] T.Trip
-           :> Post '[JSON] Bool
+           :> Post '[JSON] NoContent
diff --git a/src/App.hs b/src/App.hs
index 20d99e385..d244c9b56 100644
--- a/src/App.hs
+++ b/src/App.hs
@@ -42,11 +42,11 @@ server dbFile = userAddH
         [x] -> pure (Just x)
         _   -> pure Nothing
 
-    createTrip :: T.Trip -> IO Bool
+    createTrip :: T.Trip -> IO NoContent
     createTrip trip = withConnection dbFile $ \conn -> do
       execute conn "INSERT INTO Trips (username,destination,startDate,endDate,comment) VALUES (?,?,?,?,?)"
         (trip & T.tripFields)
-      pure True
+      pure NoContent
 
 mkApp :: FilePath -> IO Application
 mkApp dbFile = do