From 29c02242ad24396fd67a18c73a973e7f0ba97fa4 Mon Sep 17 00:00:00 2001 From: Kane York Date: Thu, 23 Jul 2020 15:46:10 -0700 Subject: [PATCH] docs(REVIEWS): recommend remote.origin.push config Change-Id: I090841101b9ee0295aabb2097f953bf149f39a9d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1403 Tested-by: BuildkiteCI Reviewed-by: lukegb --- docs/REVIEWS.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/docs/REVIEWS.md b/docs/REVIEWS.md index cb6d32845..244c0b1fa 100644 --- a/docs/REVIEWS.md +++ b/docs/REVIEWS.md @@ -54,10 +54,23 @@ of your commit and want to submit it for review, you push it to a git ref called `refs/for/canon`. This designates the commits as changelists (CLs) targeted for the `canon` branch. +Sending a change for review is done by pushing to a special target. You can set +this to be the default push target through your git configuration: + +``` +git config remote.origin.url "ssh://$USER@code.tvl.fyi:29418/depot" +git config remote.origin.push HEAD:refs/for/canon +``` + +Then, after making your change, push to the default, or to a special target: + ``` Example: git commit -m 'docs(REVIEWS): Fixed all the errors in the reviews docs' -git push origin HEAD:refs/for/canon +git push origin + +# Uploading a work-in-progress CL: +git push origin HEAD:refs/for/canon%wip ``` TIP: Every individual commit will become a separate change. We do not merge