From 283c3f0de4142157a8ea089d78eb11d2d439c28a Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Tue, 19 Mar 2024 22:57:18 +0200 Subject: [PATCH] fix(tvix): allow trace level log messages in debug builds We had max_level_debug, not max_level_trace, so it was not possible to have `RUST_LOG` emit trace-level values (at least for our crates). release_max_level_info still controls the level for release builds, so that's not affected. Change-Id: I1f127ab63f13b1622d6616e06759a9414d9bb201 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11208 Tested-by: BuildkiteCI Reviewed-by: raitobezarius Autosubmit: flokli --- tvix/Cargo.nix | 4 ++-- tvix/cli/Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tvix/Cargo.nix b/tvix/Cargo.nix index d3272843c..08caa2e7c 100644 --- a/tvix/Cargo.nix +++ b/tvix/Cargo.nix @@ -11601,7 +11601,7 @@ rec { "tracing-attributes" = [ "dep:tracing-attributes" ]; "valuable" = [ "tracing-core/valuable" ]; }; - resolvedDefaultFeatures = [ "attributes" "default" "log" "max_level_debug" "release_max_level_info" "std" "tracing-attributes" ]; + resolvedDefaultFeatures = [ "attributes" "default" "log" "max_level_trace" "release_max_level_info" "std" "tracing-attributes" ]; }; "tracing-attributes" = rec { crateName = "tracing-attributes"; @@ -12301,7 +12301,7 @@ rec { { name = "tracing"; packageId = "tracing"; - features = [ "max_level_debug" "release_max_level_info" ]; + features = [ "max_level_trace" "release_max_level_info" ]; } { name = "tracing-subscriber"; diff --git a/tvix/cli/Cargo.toml b/tvix/cli/Cargo.toml index bb561f198..d15165383 100644 --- a/tvix/cli/Cargo.toml +++ b/tvix/cli/Cargo.toml @@ -20,7 +20,7 @@ dirs = "4.0.0" rustyline = "10.0.0" thiserror = "1.0.38" tokio = "1.28.0" -tracing = { version = "0.1.37", features = ["max_level_debug", "release_max_level_info"] } +tracing = { version = "0.1.37", features = ["max_level_trace", "release_max_level_info"] } tracing-subscriber = { version = "0.3.16", features = ["json"] } [dependencies.wu-manber]