From 14f11823ff9b08d627460bee96964dc64ae22dff Mon Sep 17 00:00:00 2001 From: William Carroll Date: Sun, 19 Apr 2020 18:23:01 +0100 Subject: [PATCH] Drop support for PracticeMode For now, I'd like to support selecting keys and whitelisting inversions. --- .../learnpianochords/src/Preferences.elm | 10 +----- .../sandbox/learnpianochords/src/State.elm | 36 ++----------------- 2 files changed, 3 insertions(+), 43 deletions(-) diff --git a/website/sandbox/learnpianochords/src/Preferences.elm b/website/sandbox/learnpianochords/src/Preferences.elm index 83d4f97e2..6594e6c52 100644 --- a/website/sandbox/learnpianochords/src/Preferences.elm +++ b/website/sandbox/learnpianochords/src/Preferences.elm @@ -150,13 +150,5 @@ render model = { tempo = model.tempo , handleInput = State.SetTempo } - , case model.practiceMode of - State.KeyMode -> - keyCheckboxes model - - State.FineTuneMode -> - div [] - [ inversionCheckboxes model.whitelistedInversions - , chordTypeCheckboxes model.whitelistedChordTypes - ] + , keyCheckboxes model ] diff --git a/website/sandbox/learnpianochords/src/State.elm b/website/sandbox/learnpianochords/src/State.elm index d81e5b26b..0c23d3a5a 100644 --- a/website/sandbox/learnpianochords/src/State.elm +++ b/website/sandbox/learnpianochords/src/State.elm @@ -16,7 +16,6 @@ type Msg | TogglePitchClass Theory.PitchClass | ToggleKey Theory.Key | DoNothing - | SetPracticeMode PracticeMode | SetView View | ToggleFlashCard @@ -27,13 +26,6 @@ type View | Overview -{-| Control the type of practice you'd like. --} -type PracticeMode - = KeyMode - | FineTuneMode - - type alias Model = { whitelistedChords : List Theory.Chord , whitelistedChordTypes : List Theory.ChordType @@ -45,7 +37,6 @@ type alias Model = , tempo : Int , firstNote : Theory.Note , lastNote : Theory.Note - , practiceMode : PracticeMode , view : View , showFlashCard : Bool } @@ -70,24 +61,9 @@ init = keys = [ { pitchClass = Theory.C, mode = Theory.MajorMode } ] - - practiceMode = - KeyMode in - { practiceMode = practiceMode - , whitelistedChords = - case practiceMode of - KeyMode -> - keys |> List.concatMap Theory.chordsForKey - - FineTuneMode -> - Theory.allChords - { start = firstNote - , end = lastNote - , inversions = inversions - , chordTypes = chordTypes - , pitchClasses = pitchClasses - } + { whitelistedChords = + keys |> List.concatMap Theory.chordsForKey , whitelistedChordTypes = chordTypes , whitelistedInversions = inversions , whitelistedPitchClasses = pitchClasses @@ -110,14 +86,6 @@ update msg model = DoNothing -> ( model, Cmd.none ) - SetPracticeMode practiceMode -> - ( { model - | practiceMode = practiceMode - , isPaused = True - } - , Cmd.none - ) - SetView x -> ( { model | view = x