diff --git a/corp/tvixbolt/src/main.rs b/corp/tvixbolt/src/main.rs index 8dad534a3..ed5dada4c 100644 --- a/corp/tvixbolt/src/main.rs +++ b/corp/tvixbolt/src/main.rs @@ -256,7 +256,7 @@ fn eval(trace: bool, code: &str) -> Output { let result = tvix_eval::compile( root_expr, Some("/nixbolt".into()), - &file, + file.clone(), tvix_eval::global_builtins(), &mut compilation_observer, ) diff --git a/tvix/eval/src/compiler/attrs.rs b/tvix/eval/src/compiler/attrs.rs index f1441cff6..1584d5017 100644 --- a/tvix/eval/src/compiler/attrs.rs +++ b/tvix/eval/src/compiler/attrs.rs @@ -3,7 +3,7 @@ use super::*; -impl Compiler<'_, '_> { +impl Compiler<'_> { pub(super) fn compile_attr(&mut self, slot: LocalIdx, node: ast::Attr) { match node { ast::Attr::Dynamic(dynamic) => { diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs index 4d6728b6d..160433904 100644 --- a/tvix/eval/src/compiler/mod.rs +++ b/tvix/eval/src/compiler/mod.rs @@ -24,6 +24,7 @@ use smol_str::SmolStr; use std::collections::HashMap; use std::path::{Path, PathBuf}; use std::rc::Rc; +use std::sync::Arc; use crate::chunk::Chunk; use crate::errors::{Error, ErrorKind, EvalResult}; @@ -73,7 +74,7 @@ impl LambdaCtx { /// implicitly be resolvable in the global scope. type GlobalsMap = HashMap<&'static str, Rc>; -struct Compiler<'code, 'observer> { +struct Compiler<'observer> { contexts: Vec, warnings: Vec, errors: Vec, @@ -90,7 +91,7 @@ struct Compiler<'code, 'observer> { /// File reference in the codemap contains all known source code /// and is used to track the spans from which instructions where /// derived. - file: &'code codemap::File, + file: Arc, /// Carry an observer for the compilation process, which is called /// whenever a chunk is emitted. @@ -99,7 +100,7 @@ struct Compiler<'code, 'observer> { // Helper functions for emitting code and metadata to the internal // structures of the compiler. -impl Compiler<'_, '_> { +impl Compiler<'_> { fn context(&self) -> &LambdaCtx { &self.contexts[self.contexts.len() - 1] } @@ -137,7 +138,7 @@ impl Compiler<'_, '_> { } // Actual code-emitting AST traversal methods. -impl Compiler<'_, '_> { +impl Compiler<'_> { fn compile(&mut self, slot: LocalIdx, expr: ast::Expr) { match expr { ast::Expr::Literal(literal) => self.compile_literal(literal), @@ -1386,7 +1387,7 @@ fn prepare_globals(additional: HashMap<&'static str, Value>) -> GlobalsMap { pub fn compile( expr: ast::Expr, location: Option, - file: &codemap::File, + file: Arc, globals: HashMap<&'static str, Value>, observer: &mut dyn Observer, ) -> EvalResult { diff --git a/tvix/eval/src/compiler/spans.rs b/tvix/eval/src/compiler/spans.rs index a972a17ed..6c11961e0 100644 --- a/tvix/eval/src/compiler/spans.rs +++ b/tvix/eval/src/compiler/spans.rs @@ -77,8 +77,8 @@ expr_to_span!(ast::Str); expr_to_span!(ast::UnaryOp); expr_to_span!(ast::With); -impl Compiler<'_, '_> { +impl Compiler<'_> { pub(super) fn span_for(&self, to_span: &S) -> Span { - to_span.span_for(self.file) + to_span.span_for(&self.file) } } diff --git a/tvix/eval/src/eval.rs b/tvix/eval/src/eval.rs index 4ed97b329..6510ef0af 100644 --- a/tvix/eval/src/eval.rs +++ b/tvix/eval/src/eval.rs @@ -45,7 +45,7 @@ pub fn interpret(code: &str, location: Option) -> EvalResult { crate::compiler::compile( root_expr, location, - &file, + file.clone(), global_builtins(), &mut DisassemblingObserver::new(codemap.clone(), std::io::stderr()), ) @@ -53,7 +53,7 @@ pub fn interpret(code: &str, location: Option) -> EvalResult { crate::compiler::compile( root_expr, location, - &file, + file.clone(), global_builtins(), &mut NoOpObserver::default(), )