From 0b01c409516b5efb81ba97d927066fdc3cdf995a Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Fri, 17 Jul 2020 23:00:00 +0000 Subject: [PATCH] docs(REVIEWS): mention adding SSH keys to Gerrit Change-Id: I75ecc0c9209b80ab3ae692013f4b075764e13218 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1262 Tested-by: BuildkiteCI Reviewed-by: tazjin --- docs/REVIEWS.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/REVIEWS.md b/docs/REVIEWS.md index d9e283e31..cb6d32845 100644 --- a/docs/REVIEWS.md +++ b/docs/REVIEWS.md @@ -27,8 +27,10 @@ Gerrit uses the concept of change IDs to track commits across rebases and other operations that might change their hashes, and link them to unique changes in Gerrit. -To make this process smooth for users, the repository should be cloned and a -commit hook should be installed as follows: +First, [tell Gerrit][Gerrit SSH] about your SSH keys. + +Then, to make using Gerrit smooth for users, the repository should be cloned and +a commit hook should be installed as follows: ``` git clone "ssh://$USER@code.tvl.fyi:29418/depot" @@ -130,6 +132,7 @@ Create an appropriate commit locally and send it us using either of these option The email address is a [public group][]. +[Gerrit SSH]: https://cl.tvl.fyi/settings/#SSHKeys [Gerrit walkthrough]: https://gerrit-review.googlesource.com/Documentation/intro-gerrit-walkthrough.html [OWNERS]: https://cl.tvl.fyi/plugins/owners/Documentation/config.md [guidelines]: ./CONTRIBUTING.md#commit-messages