From 03076c3977bad32c017810e13adb428411be63cd Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 1 Jul 2020 01:16:27 +0100 Subject: [PATCH] fix(besadii): Do not pass on update values for meta refs Before this change, besadii would skip further processing of meta refs (which happen for every CL metadata change), but it would still schedule a build by returning an update - which would then inevitably fail. This change makes besadii skip meta refs the same way it skips non-depot builds, i.e. completely. Move *on* from meta refs, do *not* collect $100. Change-Id: I269d2299f4d3cb1f9c041da8c92fa00ae7794b38 Reviewed-on: https://cl.tvl.fyi/c/depot/+/825 Reviewed-by: eta Reviewed-by: BuildkiteCI Tested-by: BuildkiteCI --- ops/besadii/main.go2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ops/besadii/main.go2 b/ops/besadii/main.go2 index 8fada435e..dac711ce2 100644 --- a/ops/besadii/main.go2 +++ b/ops/besadii/main.go2 @@ -154,12 +154,12 @@ func refUpdatedFromFlags() (*refUpdated, error) { return nil, fmt.Errorf("'ref-updated' hook invoked without required arguments") } - if update.project != "depot" { + if update.project != "depot" || metaRegexp.MatchString(update.ref) { // this is not an error, but also not something we handle. return nil, nil } - if branchRegexp.MatchString(update.ref) || metaRegexp.MatchString(update.ref) { + if branchRegexp.MatchString(update.ref) { // these refs don't need special handling, just move on return &update, nil }