From eee64b7aeca1ed265f553377491732e01d9cbb06 Mon Sep 17 00:00:00 2001 From: Ryan Lahfa Date: Fri, 24 May 2024 20:57:12 +0200 Subject: [PATCH] chore: add some TODOs on what to do Signed-off-by: Ryan Lahfa --- src/nix/deployment/mod.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/nix/deployment/mod.rs b/src/nix/deployment/mod.rs index 7b19dca..2ba4d63 100644 --- a/src/nix/deployment/mod.rs +++ b/src/nix/deployment/mod.rs @@ -370,6 +370,9 @@ impl Deployment { for (name, profile_drv) in profile_drvs.iter() { let mut target = chunk.remove(name).unwrap(); + // TODO: look if target's system type support build on target. + // hard fail if the build on target. + if let Some(force_build_on_target) = self.options.force_build_on_target { target.config.set_build_on_target(force_build_on_target); } @@ -439,6 +442,9 @@ impl Deployment { return Err(ColmenaError::Unsupported); } + // TODO: add to check if there's support to upload keys. + // If not, warn about it but do nothing. + let host = target.host.as_mut().unwrap(); host.set_job(Some(job)); host.upload_keys(&target.config.keys, true).await?; @@ -621,6 +627,8 @@ impl Deployment { let host = target.host.as_mut().unwrap(); host.set_job(Some(job.clone())); + // TODO: certain system types does not have a concept of profile. + // generalize the profile algorithm if !target.config.replace_unknown_profiles { job.message("Checking remote profile...".to_string())?;