require File.dirname(__FILE__) + '/../test_helper' require 'way_controller' # Re-raise errors caught by the controller. class WayController; def rescue_action(e) raise e end; end class WayControllerTest < Test::Unit::TestCase api_fixtures def setup @controller = WayController.new @request = ActionController::TestRequest.new @response = ActionController::TestResponse.new end def basic_authorization(user, pass) @request.env["HTTP_AUTHORIZATION"] = "Basic %s" % Base64.encode64("#{user}:#{pass}") end def content(c) @request.env["RAW_POST_DATA"] = c.to_s end # ------------------------------------- # Test reading ways. # ------------------------------------- def test_read # check that a visible way is returned properly get :read, :id => current_ways(:visible_way).id assert_response :success # check that an invisible way is not returned get :read, :id => current_ways(:invisible_way).id assert_response :gone # check chat a non-existent way is not returned get :read, :id => 0 assert_response :not_found # check the "ways for node" mode get :ways_for_node, :id => current_nodes(:used_node_1).id assert_response :success # FIXME check whether this contains the stuff we want! #print @response.body # Needs to be updated when changing fixtures # The generator should probably be defined in the environment.rb file # in the same place as the api version assert_select "osm[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1 assert_select "osm way", 3 assert_select "osm way nd", 3 assert_select "osm way tag", 3 # check the "full" mode get :full, :id => current_ways(:visible_way).id assert_response :success # FIXME check whether this contains the stuff we want! #print @response.body # Check the way is correctly returned way = current_ways(:visible_way) assert_select "osm way[id=#{way.id}][version=#{way.version}][visible=#{way.visible}]", 1 assert_select "osm way nd[ref=#{way.way_nodes[0].node_id}]", 1 # Check that the node is correctly returned nd = current_ways(:visible_way).nodes assert_equal 1, nd.count nda = nd[0] assert_select "osm node[id=#{nda.id}][version=#{nda.version}][lat=#{nda.lat}][lon=#{nda.lon}]", 1 end # ------------------------------------- # Test simple way creation. # ------------------------------------- def test_create nid1 = current_nodes(:used_node_1).id nid2 = current_nodes(:used_node_2).id basic_authorization "test@openstreetmap.org", "test" # use the first user's open changeset changeset_id = changesets(:normal_user_first_change).id # create a way with pre-existing nodes content "" + "" + "" put :create # hope for success assert_response :success, "way upload did not return success status" # read id of created way and search for it wayid = @response.body checkway = Way.find(wayid) assert_not_nil checkway, "uploaded way not found in data base after upload" # compare values assert_equal checkway.nds.length, 2, "saved way does not contain exactly one node" assert_equal checkway.nds[0], nid1, "saved way does not contain the right node on pos 0" assert_equal checkway.nds[1], nid2, "saved way does not contain the right node on pos 1" assert_equal checkway.changeset_id, changeset_id, "saved way does not belong to the correct changeset" assert_equal users(:normal_user).id, checkway.changeset.user_id, "saved way does not belong to user that created it" assert_equal true, checkway.visible, "saved way is not visible" end # ------------------------------------- # Test creating some invalid ways. # ------------------------------------- def test_create_invalid basic_authorization "test@openstreetmap.org", "test" # use the first user's open changeset open_changeset_id = changesets(:normal_user_first_change).id closed_changeset_id = changesets(:normal_user_closed_change).id nid1 = current_nodes(:used_node_1).id # create a way with non-existing node content "" + "" put :create # expect failure assert_response :precondition_failed, "way upload with invalid node did not return 'precondition failed'" # create a way with no nodes content "" + "" put :create # expect failure assert_response :precondition_failed, "way upload with no node did not return 'precondition failed'" # create a way inside a closed changeset content "" + "" put :create # expect failure assert_response :conflict, "way upload to closed changeset did not return 'conflict'" end # ------------------------------------- # Test deleting ways. # ------------------------------------- def test_delete # first try to delete way without auth delete :delete, :id => current_ways(:visible_way).id assert_response :unauthorized # now set auth basic_authorization("test@openstreetmap.org", "test"); # this shouldn't work as with the 0.6 api we need pay load to delete delete :delete, :id => current_ways(:visible_way).id assert_response :bad_request # Now try without having a changeset content "" delete :delete, :id => current_ways(:visible_way).id assert_response :bad_request # Now try and get a changeset changeset_id = changesets(:normal_user_first_change).id content current_ways(:visible_way).to_xml delete :delete, :id => current_ways(:visible_way).id assert_response :success # this won't work since the way is already deleted content current_ways(:invisible_way).to_xml delete :delete, :id => current_ways(:invisible_way).id assert_response :gone # this won't work since the way never existed delete :delete, :id => 0 assert_response :not_found end end