require File.dirname(__FILE__) + '/../test_helper' require 'changeset_controller' class ChangesetControllerTest < ActionController::TestCase api_fixtures def basic_authorization(user, pass) @request.env["HTTP_AUTHORIZATION"] = "Basic %s" % Base64.encode64("#{user}:#{pass}") end def content(c) @request.env["RAW_POST_DATA"] = c.to_s end # ----------------------- # Test simple changeset creation # ----------------------- def test_create basic_authorization "test@openstreetmap.org", "test" # Create the first user's changeset content "" + "" + "" put :create assert_response :success, "Creation of changeset did not return sucess status" newid = @response.body end def test_create_invalid basic_authorization "test@openstreetmap.org", "test" content "" put :create assert_response :bad_request, "creating a invalid changeset should fail" end def test_read end def test_close end ## # upload something simple, but valid and check that it can # be read back ok. def test_upload_simple_valid basic_authorization "test@openstreetmap.org", "test" # simple diff to change a node, way and relation by removing # their tags diff = < EOF # upload it content diff post :upload, :id => 1 assert_response :success, "can't upload a simple valid diff to changeset: #{@response.body}" # check that the changes made it into the database assert_equal 0, Node.find(1).tags.size, "node 1 should now have no tags" assert_equal 0, Way.find(1).tags.size, "way 1 should now have no tags" assert_equal 0, Relation.find(1).tags.size, "relation 1 should now have no tags" end ## # upload something which creates new objects using placeholders def test_upload_create_valid basic_authorization "test@openstreetmap.org", "test" # simple diff to create a node way and relation using placeholders diff = < EOF # upload it content diff post :upload, :id => 1 assert_response :success, "can't upload a simple valid creation to changeset: #{@response.body}" # check the returned payload assert_select "osm[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1 assert_select "osm>node", 1 assert_select "osm>way", 1 assert_select "osm>relation", 1 # inspect the response to find out what the new element IDs are doc = XML::Parser.string(@response.body).parse new_node_id = doc.find("//osm/node").first["new_id"].to_i new_way_id = doc.find("//osm/way").first["new_id"].to_i new_rel_id = doc.find("//osm/relation").first["new_id"].to_i # check the old IDs are all present and negative one assert_equal -1, doc.find("//osm/node").first["old_id"].to_i assert_equal -1, doc.find("//osm/way").first["old_id"].to_i assert_equal -1, doc.find("//osm/relation").first["old_id"].to_i # check the versions are present and equal one assert_equal 1, doc.find("//osm/node").first["new_version"].to_i assert_equal 1, doc.find("//osm/way").first["new_version"].to_i assert_equal 1, doc.find("//osm/relation").first["new_version"].to_i # check that the changes made it into the database assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags" assert_equal 0, Way.find(new_way_id).tags.size, "new way should have no tags" assert_equal 0, Relation.find(new_rel_id).tags.size, "new relation should have no tags" end ## # test a complex delete where we delete elements which rely on eachother # in the same transaction. def test_upload_delete basic_authorization "test@openstreetmap.org", "test" diff = XML::Document.new diff.root = XML::Node.new "osmChange" delete = XML::Node.new "delete" diff.root << delete delete << current_relations(:visible_relation).to_xml_node delete << current_relations(:used_relation).to_xml_node delete << current_ways(:used_way).to_xml_node delete << current_nodes(:node_used_by_relationship).to_xml_node # upload it content diff post :upload, :id => 1 assert_response :success, "can't upload a deletion diff to changeset: #{@response.body}" # check that everything was deleted assert_equal false, Node.find(current_nodes(:node_used_by_relationship).id).visible assert_equal false, Way.find(current_ways(:used_way).id).visible assert_equal false, Relation.find(current_relations(:visible_relation).id).visible assert_equal false, Relation.find(current_relations(:used_relation).id).visible end ## # test that deleting stuff in a transaction doesn't bypass the checks # to ensure that used elements are not deleted. def test_upload_delete_invalid basic_authorization "test@openstreetmap.org", "test" diff = XML::Document.new diff.root = XML::Node.new "osmChange" delete = XML::Node.new "delete" diff.root << delete delete << current_relations(:visible_relation).to_xml_node delete << current_ways(:used_way).to_xml_node delete << current_nodes(:node_used_by_relationship).to_xml_node # upload it content diff post :upload, :id => 1 assert_response :precondition_failed, "shouldn't be able to upload a invalid deletion diff: #{@response.body}" # check that nothing was, in fact, deleted assert_equal true, Node.find(current_nodes(:node_used_by_relationship).id).visible assert_equal true, Way.find(current_ways(:used_way).id).visible assert_equal true, Relation.find(current_relations(:visible_relation).id).visible end ## # upload something which creates new objects and inserts them into # existing containers using placeholders. def test_upload_complex basic_authorization "test@openstreetmap.org", "test" # simple diff to create a node way and relation using placeholders diff = < EOF # upload it content diff post :upload, :id => 1 assert_response :success, "can't upload a complex diff to changeset: #{@response.body}" # check the returned payload assert_select "osm[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1 assert_select "osm>node", 1 assert_select "osm>way", 1 assert_select "osm>relation", 1 # inspect the response to find out what the new element IDs are doc = XML::Parser.string(@response.body).parse new_node_id = doc.find("//osm/node").first["new_id"].to_i # check that the changes made it into the database assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags" assert_equal [new_node_id, 3], Way.find(1).nds, "way nodes should match" Relation.find(1).members.each do |type,id,role| if type == 'node' assert_equal new_node_id, id, "relation should contain new node" end end end ## # create a diff which references several changesets, which should cause # a rollback and none of the diff gets committed def test_upload_invalid_changesets basic_authorization "test@openstreetmap.org", "test" # simple diff to create a node way and relation using placeholders diff = < EOF # cache the objects before uploading them node = current_nodes(:visible_node) way = current_ways(:visible_way) rel = current_relations(:visible_relation) # upload it content diff post :upload, :id => 1 assert_response :conflict, "uploading a diff with multiple changsets should have failed" # check that objects are unmodified assert_nodes_are_equal(node, Node.find(1)) assert_ways_are_equal(way, Way.find(1)) end ## # upload multiple versions of the same element in the same diff. def test_upload_multiple_valid basic_authorization "test@openstreetmap.org", "test" # change the location of a node multiple times, each time referencing # the last version. doesn't this depend on version numbers being # sequential? diff = < EOF # upload it content diff post :upload, :id => 1 assert_response :success, "can't upload multiple versions of an element in a diff: #{@response.body}" end ## # upload multiple versions of the same element in the same diff, but # keep the version numbers the same. def test_upload_multiple_duplicate basic_authorization "test@openstreetmap.org", "test" diff = < EOF # upload it content diff post :upload, :id => 1 assert_response :conflict, "shouldn't be able to upload the same element twice in a diff: #{@response.body}" end ## # try to upload some elements without specifying the version def test_upload_missing_version basic_authorization "test@openstreetmap.org", "test" diff = < EOF # upload it content diff post :upload, :id => 1 assert_response :bad_request, "shouldn't be able to upload an element without version: #{@response.body}" end ## # when we make some simple changes we get the same changes back from the # diff download. def test_diff_download_simple basic_authorization(users(:normal_user).email, "test") # create a temporary changeset content "" + "" + "" put :create assert_response :success changeset_id = @response.body.to_i # add a diff to it diff = < EOF # upload it content diff post :upload, :id => changeset_id assert_response :success, "can't upload multiple versions of an element in a diff: #{@response.body}" get :download, :id => changeset_id assert_response :success assert_select "osmChange", 1 assert_select "osmChange>modify", 8 assert_select "osmChange>modify>node", 8 end ## # when we make some complex changes we get the same changes back from the # diff download. def test_diff_download_complex basic_authorization(users(:normal_user).email, "test") # create a temporary changeset content "" + "" + "" put :create assert_response :success changeset_id = @response.body.to_i # add a diff to it diff = < EOF # upload it content diff post :upload, :id => changeset_id assert_response :success, "can't upload multiple versions of an element in a diff: #{@response.body}" get :download, :id => changeset_id assert_response :success assert_select "osmChange", 1 assert_select "osmChange>create", 3 assert_select "osmChange>delete", 1 assert_select "osmChange>modify", 2 assert_select "osmChange>create>node", 3 assert_select "osmChange>delete>node", 1 assert_select "osmChange>modify>node", 1 assert_select "osmChange>modify>way", 1 end end