From 3a8b8af53b92d232ea3cfdff904b788affbb71b8 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 Aug 2024 12:55:20 +0300 Subject: [PATCH 1/6] Stop testing revoke block buttons --- test/controllers/user_blocks_controller_test.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/controllers/user_blocks_controller_test.rb b/test/controllers/user_blocks_controller_test.rb index 61440ae56..dfa6dd2d9 100644 --- a/test/controllers/user_blocks_controller_test.rb +++ b/test/controllers/user_blocks_controller_test.rb @@ -173,10 +173,10 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest block = create(:user_block, :creator => creator_user) session_for(other_moderator_user) - check_block_buttons block, :edit => 1, :revoke => 1 + check_block_buttons block, :edit => 1 session_for(creator_user) - check_block_buttons block, :edit => 1, :revoke => 1 + check_block_buttons block, :edit => 1 end ## @@ -973,12 +973,11 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest private - def check_block_buttons(block, edit: 0, revoke: 0) + def check_block_buttons(block, edit: 0) [user_blocks_path, user_block_path(block)].each do |path| get path assert_response :success assert_select "a[href='#{edit_user_block_path block}']", :count => edit - assert_select "a[href='#{revoke_user_block_path block}']", :count => revoke end end From 1baf64e7bc07abb7b917f54dde92cbd3e8382274 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 Aug 2024 12:55:53 +0300 Subject: [PATCH 2/6] Remove revoke buttons from block lists --- app/views/user_blocks/_block.html.erb | 3 --- app/views/user_blocks/_blocks.html.erb | 3 --- config/locales/en.yml | 1 - 3 files changed, 7 deletions(-) diff --git a/app/views/user_blocks/_block.html.erb b/app/views/user_blocks/_block.html.erb index b464b4ccd..1eb38f93f 100644 --- a/app/views/user_blocks/_block.html.erb +++ b/app/views/user_blocks/_block.html.erb @@ -16,7 +16,4 @@ <%= link_to t(".show"), block %> <% if can?(:edit, block) %><%= link_to t(".edit"), edit_user_block_path(block) %><% end %> - <% if can?(:revoke, UserBlock) %> - <% if block.active? %><%= link_to t(".revoke"), revoke_user_block_path(block) %><% end %> - <% end %> diff --git a/app/views/user_blocks/_blocks.html.erb b/app/views/user_blocks/_blocks.html.erb index 8816acb15..7f44b6bc3 100644 --- a/app/views/user_blocks/_blocks.html.erb +++ b/app/views/user_blocks/_blocks.html.erb @@ -13,9 +13,6 @@ <%= t ".revoker_name" %> - <% if can?(:revoke, UserBlock) %> - - <% end %> <%= render :partial => "block", :collection => @user_blocks %> diff --git a/config/locales/en.yml b/config/locales/en.yml index 80811cd1f..26182c3eb 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -3022,7 +3022,6 @@ en: not_revoked: "(not revoked)" show: "Show" edit: "Edit" - revoke: "Revoke!" blocks: display_name: "Blocked User" creator_name: "Creator" From ed1e5ebe7d1f25e2ac6589c3610e8aae2042e6b0 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 Aug 2024 13:01:20 +0300 Subject: [PATCH 3/6] Remove revoke buttons from block show pages --- app/views/user_blocks/show.html.erb | 11 ++--------- config/locales/en.yml | 1 - 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/app/views/user_blocks/show.html.erb b/app/views/user_blocks/show.html.erb index 06275c3f0..180406c74 100644 --- a/app/views/user_blocks/show.html.erb +++ b/app/views/user_blocks/show.html.erb @@ -26,15 +26,8 @@
<%= @user_block.reason.to_html %>
-<% if current_user && (current_user.id == @user_block.creator_id || - current_user.id == @user_block.revoker_id) || - can?(:revoke, UserBlock) && @user_block.active? %> +<% if can?(:edit, @user_block) %>
- <% if can?(:edit, @user_block) %> - <%= link_to t(".edit"), edit_user_block_path(@user_block), :class => "btn btn-outline-primary" %> - <% end %> - <% if can?(:revoke, UserBlock) && @user_block.active? %> - <%= link_to t(".revoke"), revoke_user_block_path(@user_block), :class => "btn btn-outline-danger" %> - <% end %> + <%= link_to t(".edit"), edit_user_block_path(@user_block), :class => "btn btn-outline-primary" %>
<% end %> diff --git a/config/locales/en.yml b/config/locales/en.yml index 26182c3eb..33bb0a292 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -3013,7 +3013,6 @@ en: status: "Status:" show: "Show" edit: "Edit" - revoke: "Revoke!" confirm: "Are you sure?" reason: "Reason for block:" revoker: "Revoker:" From a448c9d0e007462e9cef5a1c7102fea2d6fdea2e Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 Aug 2024 13:11:32 +0300 Subject: [PATCH 4/6] Update block-api integration test to revoke block by editing --- test/integration/user_blocks_test.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/integration/user_blocks_test.rb b/test/integration/user_blocks_test.rb index 13db86e28..96717e092 100644 --- a/test/integration/user_blocks_test.rb +++ b/test/integration/user_blocks_test.rb @@ -39,12 +39,13 @@ class UserBlocksTest < ActionDispatch::IntegrationTest # revoke the ban get "/login" assert_response :success - post "/login", :params => { "username" => moderator.email, "password" => "test", :referer => "/blocks/#{block.id}/revoke" } + post "/login", :params => { "username" => moderator.email, "password" => "test", :referer => "/user_blocks/#{block.id}/edit" } assert_response :redirect follow_redirect! assert_response :success - assert_template "user_blocks/revoke" - post "/blocks/#{block.id}/revoke", :params => { "confirm" => "yes" } + assert_template "user_blocks/edit" + put "/user_blocks/#{block.id}", :params => { :user_block_period => "0", + :user_block => { :needs_view => false, :reason => "Unblocked" } } assert_response :redirect follow_redirect! assert_response :success From cc2a72bdd7f8aa00cbf8d0e00fb8132f4698172e Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 Aug 2024 13:23:29 +0300 Subject: [PATCH 5/6] Remove revoke block pages --- app/views/user_blocks/revoke.html.erb | 31 --------------- config/locales/en.yml | 6 --- config/routes.rb | 2 +- .../user_blocks_controller_test.rb | 38 ------------------- 4 files changed, 1 insertion(+), 76 deletions(-) delete mode 100644 app/views/user_blocks/revoke.html.erb diff --git a/app/views/user_blocks/revoke.html.erb b/app/views/user_blocks/revoke.html.erb deleted file mode 100644 index 224e1e4bb..000000000 --- a/app/views/user_blocks/revoke.html.erb +++ /dev/null @@ -1,31 +0,0 @@ -<% @title = t(".title", - :block_on => @user_block.user.display_name, - :block_by => @user_block.creator.display_name) %> - -<% content_for :heading do %> -

<%= t(".heading_html", - :block_on => link_to(@user_block.user.display_name, @user_block.user), - :block_by => link_to(@user_block.creator.display_name, @user_block.creator)) %>

-<% end %> - -<% if @user_block.ends_at > Time.now %> -

- <%= t(".time_future_html", :time => friendly_date(@user_block.ends_at)) %> -

- - <%= bootstrap_form_for :revoke, :url => { :action => "revoke" } do |f| %> -
-
- <%= check_box_tag "confirm", "yes", false, { :class => "form-check-input" } %> - <%= label_tag "confirm", t(".confirm"), { :class => "form-check-label" } %> -
-
- - <%= f.submit t(".revoke"), :class => "btn btn-danger" %> - <% end %> - -<% else %> -

- <%= t(".past_html", :time => friendly_date_ago(@user_block.ends_at)) %> -

-<% end %> diff --git a/config/locales/en.yml b/config/locales/en.yml index 33bb0a292..215a96179 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -2959,12 +2959,6 @@ en: heading: "List of user blocks" empty: "No blocks have been made yet." revoke: - title: "Revoking block on %{block_on}" - heading_html: "Revoking block on %{block_on} by %{block_by}" - time_future_html: "This block will end in %{time}." - past_html: "This block ended %{time} and cannot be revoked now." - confirm: "Are you sure you wish to revoke this block?" - revoke: "Revoke!" flash: "This block has been revoked." revoke_all: title: "Revoking all blocks on %{block_on}" diff --git a/config/routes.rb b/config/routes.rb index 125d6f810..b6522a1ab 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -334,7 +334,7 @@ OpenStreetMap::Application.routes.draw do get "/user/:display_name/blocks_by" => "user_blocks#blocks_by", :as => "user_blocks_by" get "/blocks/new/:display_name" => "user_blocks#new", :as => "new_user_block" resources :user_blocks, :except => :new - match "/blocks/:id/revoke" => "user_blocks#revoke", :via => [:get, :post], :as => "revoke_user_block" + post "/blocks/:id/revoke" => "user_blocks#revoke", :as => "revoke_user_block" match "/user/:display_name/blocks/revoke_all" => "user_blocks#revoke_all", :via => [:get, :post], :as => "revoke_all_user_blocks" # issues and reports diff --git a/test/controllers/user_blocks_controller_test.rb b/test/controllers/user_blocks_controller_test.rb index dfa6dd2d9..6d99db1cd 100644 --- a/test/controllers/user_blocks_controller_test.rb +++ b/test/controllers/user_blocks_controller_test.rb @@ -33,10 +33,6 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest { :path => "/user_blocks/1", :method => :delete }, { :controller => "user_blocks", :action => "destroy", :id => "1" } ) - assert_routing( - { :path => "/blocks/1/revoke", :method => :get }, - { :controller => "user_blocks", :action => "revoke", :id => "1" } - ) assert_routing( { :path => "/blocks/1/revoke", :method => :post }, { :controller => "user_blocks", :action => "revoke", :id => "1" } @@ -558,48 +554,14 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest def test_revoke active_block = create(:user_block) - # Check that the block revoke page requires us to login - get revoke_user_block_path(:id => active_block) - assert_redirected_to login_path(:referer => revoke_user_block_path(:id => active_block)) - - # Login as a normal user - session_for(create(:user)) - - # Check that normal users can't load the block revoke page - get revoke_user_block_path(:id => active_block) - assert_redirected_to :controller => "errors", :action => "forbidden" - # Login as a moderator session_for(create(:moderator_user)) - # Check that the block revoke page loads for moderators - get revoke_user_block_path(:id => active_block) - assert_response :success - assert_template "revoke" - assert_select "h1 a[href='#{user_path active_block.user}']", :text => active_block.user.display_name - assert_select "form", :count => 1 do - assert_select "input#confirm[type='checkbox']", :count => 1 - assert_select "input[type='submit'][value='Revoke!']", :count => 1 - end - - # Check that revoking a block using GET should fail - get revoke_user_block_path(:id => active_block, :confirm => true) - assert_response :success - assert_template "revoke" - b = UserBlock.find(active_block.id) - assert_operator b.ends_at - Time.now.utc, :>, 100 - # Check that revoking a block works using POST post revoke_user_block_path(:id => active_block, :confirm => true) assert_redirected_to user_block_path(active_block) b = UserBlock.find(active_block.id) assert_in_delta Time.now.utc, b.ends_at, 1 - - # We should get an error if the block doesn't exist - get revoke_user_block_path(:id => 99999) - assert_response :not_found - assert_template "not_found" - assert_select "p", "Sorry, the user block with ID 99999 could not be found." end ## From 258104dfdfba612a1b507e040b072d417e5f8576 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 Aug 2024 13:34:08 +0300 Subject: [PATCH 6/6] Remove revoke block action --- app/abilities/ability.rb | 2 +- app/controllers/user_blocks_controller.rb | 13 ++----------- config/locales/en.yml | 2 -- config/routes.rb | 1 - .../user_blocks_controller_test.rb | 19 ------------------- 5 files changed, 3 insertions(+), 34 deletions(-) diff --git a/app/abilities/ability.rb b/app/abilities/ability.rb index 6baa67be5..7ee75f3bc 100644 --- a/app/abilities/ability.rb +++ b/app/abilities/ability.rb @@ -60,7 +60,7 @@ class Ability can [:index, :show, :resolve, :ignore, :reopen], Issue can :create, IssueComment can [:new, :create, :edit, :update, :destroy], Redaction - can [:new, :create, :revoke, :revoke_all], UserBlock + can [:new, :create, :revoke_all], UserBlock can :update, UserBlock, :creator => user can :update, UserBlock, :revoker => user can :update, UserBlock, :active? => true diff --git a/app/controllers/user_blocks_controller.rb b/app/controllers/user_blocks_controller.rb index 7027359cc..6bf86de3f 100644 --- a/app/controllers/user_blocks_controller.rb +++ b/app/controllers/user_blocks_controller.rb @@ -10,10 +10,10 @@ class UserBlocksController < ApplicationController authorize_resource before_action :lookup_user, :only => [:new, :create, :revoke_all, :blocks_on, :blocks_by] - before_action :lookup_user_block, :only => [:show, :edit, :update, :revoke] + before_action :lookup_user_block, :only => [:show, :edit, :update] before_action :require_valid_params, :only => [:create, :update] before_action :check_database_readable - before_action :check_database_writable, :only => [:create, :update, :revoke, :revoke_all] + before_action :check_database_writable, :only => [:create, :update, :revoke_all] def index @params = params.permit @@ -105,15 +105,6 @@ class UserBlocksController < ApplicationController end end - ## - # revokes the block, setting the end_time to now - def revoke - if request.post? && params[:confirm] && @user_block.revoke!(current_user) - flash[:notice] = t ".flash" - redirect_to(@user_block) - end - end - ## # revokes all active blocks def revoke_all diff --git a/config/locales/en.yml b/config/locales/en.yml index 215a96179..36698f02c 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -2958,8 +2958,6 @@ en: title: "User blocks" heading: "List of user blocks" empty: "No blocks have been made yet." - revoke: - flash: "This block has been revoked." revoke_all: title: "Revoking all blocks on %{block_on}" heading_html: "Revoking all blocks on %{block_on}" diff --git a/config/routes.rb b/config/routes.rb index b6522a1ab..b0e23301e 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -334,7 +334,6 @@ OpenStreetMap::Application.routes.draw do get "/user/:display_name/blocks_by" => "user_blocks#blocks_by", :as => "user_blocks_by" get "/blocks/new/:display_name" => "user_blocks#new", :as => "new_user_block" resources :user_blocks, :except => :new - post "/blocks/:id/revoke" => "user_blocks#revoke", :as => "revoke_user_block" match "/user/:display_name/blocks/revoke_all" => "user_blocks#revoke_all", :via => [:get, :post], :as => "revoke_all_user_blocks" # issues and reports diff --git a/test/controllers/user_blocks_controller_test.rb b/test/controllers/user_blocks_controller_test.rb index 6d99db1cd..ed310f52e 100644 --- a/test/controllers/user_blocks_controller_test.rb +++ b/test/controllers/user_blocks_controller_test.rb @@ -33,10 +33,6 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest { :path => "/user_blocks/1", :method => :delete }, { :controller => "user_blocks", :action => "destroy", :id => "1" } ) - assert_routing( - { :path => "/blocks/1/revoke", :method => :post }, - { :controller => "user_blocks", :action => "revoke", :id => "1" } - ) assert_routing( { :path => "/user/username/blocks", :method => :get }, @@ -549,21 +545,6 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest assert_equal other_moderator_user, block.revoker end - ## - # test the revoke action - def test_revoke - active_block = create(:user_block) - - # Login as a moderator - session_for(create(:moderator_user)) - - # Check that revoking a block works using POST - post revoke_user_block_path(:id => active_block, :confirm => true) - assert_redirected_to user_block_path(active_block) - b = UserBlock.find(active_block.id) - assert_in_delta Time.now.utc, b.ends_at, 1 - end - ## # test the revoke all page def test_revoke_all_page