From 0283bd4f1ae426175933973bdcad09d1ec2d3f69 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 9 Jul 2008 23:27:33 +0000 Subject: [PATCH 1/8] Branch the rails code for Potlatch 0.10 support. From 49637fed70c3cee22646c3f63ebbdc7261c07102 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 15 Jul 2008 18:05:22 +0000 Subject: [PATCH 2/8] Move Potlatch configuration to a separate initialiser file. --- config/environment.rb | 7 ------- config/initializers/potlatch.rb | 6 ++++++ 2 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 config/initializers/potlatch.rb diff --git a/config/environment.rb b/config/environment.rb index 6cf8b261d..e6af619eb 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -74,10 +74,3 @@ Rails::Initializer.run do |config| # Make Active Record use UTC-base instead of local time # config.active_record.default_timezone = :utc end - -# This has to be after the above block for some reason (doesnt pull in /lib/osm.rb?) -POTLATCH_PRESETS = Potlatch::Potlatch.get_presets() - -# Use SQL (faster) or Rails (more elegant) for common Potlatch reads -# getway speedup is approximately x2, whichways approximately x7 -POTLATCH_USE_SQL = true diff --git a/config/initializers/potlatch.rb b/config/initializers/potlatch.rb new file mode 100644 index 000000000..880947148 --- /dev/null +++ b/config/initializers/potlatch.rb @@ -0,0 +1,6 @@ +# Load presets +POTLATCH_PRESETS = Potlatch::Potlatch.get_presets() + +# Use SQL (faster) or Rails (more elegant) for common Potlatch reads +# getway speedup is approximately x2, whichways approximately x7 +POTLATCH_USE_SQL = true From 6fa8647855b81a2f518c4995969113038187759c Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 15 Jul 2008 18:18:37 +0000 Subject: [PATCH 3/8] Rename unique_nodes to unshared_node_ids to make it's purpose a bit clearer and rework it to be a bit tidier. --- app/controllers/amf_controller.rb | 4 ++-- app/models/way.rb | 22 ++++++++++------------ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/app/controllers/amf_controller.rb b/app/controllers/amf_controller.rb index 4ec4e660e..28e2e4b2b 100644 --- a/app/controllers/amf_controller.rb +++ b/app/controllers/amf_controller.rb @@ -295,7 +295,7 @@ class AmfController < ApplicationController uniques=[] else way=Way.find(originalway) - uniques=way.unique_nodes + uniques=way.unshared_node_ids end # -- Compare nodes and save changes to any that have changed @@ -415,7 +415,7 @@ class AmfController < ApplicationController # two nodes from the same relation user = User.find(uid) way = Way.find(way_id) - way.unique_nodes.each do |n| + way.unshared_node_ids.each do |n| deleteitemrelations(n,'node') end diff --git a/app/models/way.rb b/app/models/way.rb index 59988d88b..958944200 100644 --- a/app/models/way.rb +++ b/app/models/way.rb @@ -235,11 +235,8 @@ class Way < ActiveRecord::Base # delete a way and it's nodes that aren't part of other ways, with history def delete_with_relations_and_nodes_and_history(user) - - node_ids_to_delete = self.unique_nodes - # delete the nodes not used by other ways - node_ids_to_delete.each do |node_id| + self.unshared_node_ids.each do |node_id| n = Node.find(node_id) n.user_id = user.id n.visible = false @@ -249,17 +246,18 @@ class Way < ActiveRecord::Base self.user_id = user.id self.delete_with_relations_and_history(user) - end # Find nodes that belong to this way only - def unique_nodes - node_ids = self.nodes.collect {|node| node.id } - if node_ids.length==0 then return [] end - node_ids_in_other_ways = [] - way_nodes = WayNode.find(:all, :conditions => "node_id in (#{node_ids.join(',')}) and id != #{self.id}") - node_ids_in_other_ways = way_nodes.collect {|way_node| way_node.node_id} - return node_ids - node_ids_in_other_ways + def unshared_node_ids + node_ids = self.nodes.collect { |node| node.id } + + unless node_ids.empty? + way_nodes = WayNode.find(:all, :conditions => "node_id in (#{node_ids.join(',')}) and id != #{self.id}") + node_ids = node_ids - way_nodes.collect { |way_node| way_node.node_id } + end + + return node_ids end # Temporary method to match interface to nodes From 34d9360bee4c1f277bb908280ca3daa6f3d88aa9 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 15 Jul 2008 18:23:00 +0000 Subject: [PATCH 4/8] Minor tidyups. --- app/models/node.rb | 7 +++---- app/models/old_way_node.rb | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/app/models/node.rb b/app/models/node.rb index d61293e82..cec755f47 100644 --- a/app/models/node.rb +++ b/app/models/node.rb @@ -17,13 +17,12 @@ class Node < ActiveRecord::Base has_many :way_nodes has_many :ways, :through => :way_nodes - has_many :containing_relation_members, :class_name => "RelationMember", :as => :member - has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation, :extend => ObjectFinder - - # Atomic undelete support has_many :old_way_nodes has_many :ways_via_history, :class_name=> "Way", :through => :old_way_nodes, :source => :way + has_many :containing_relation_members, :class_name => "RelationMember", :as => :member + has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation, :extend => ObjectFinder + # Sanity check the latitude and longitude and add an error if it's broken def validate_position errors.add_to_base("Node is not in the world") unless in_world? diff --git a/app/models/old_way_node.rb b/app/models/old_way_node.rb index a6e65da85..7420b5cfc 100644 --- a/app/models/old_way_node.rb +++ b/app/models/old_way_node.rb @@ -3,6 +3,5 @@ class OldWayNode < ActiveRecord::Base set_primary_keys :id, :version, :sequence_id - # Atomic undelete support - belongs_to :way, :foreign_key=> :id + belongs_to :way, :foreign_key=> :id end From c878da25cf42d98f1666760549fd015c09f5dabe Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 15 Jul 2008 23:15:53 +0000 Subject: [PATCH 5/8] Remote Potlatch projection routines as they are no longer needed. --- lib/geo_record.rb | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/geo_record.rb b/lib/geo_record.rb index 025bbe4a8..f1a923c42 100644 --- a/lib/geo_record.rb +++ b/lib/geo_record.rb @@ -37,15 +37,6 @@ module GeoRecord return self.longitude.to_f / 10000000 end - # Potlatch projections - def lon_potlatch(baselong,masterscale) - (self.lon-baselong)*masterscale - end - - def lat_potlatch(basey,masterscale) - -(lat2y(self.lat)-basey)*masterscale - end - private def lat2y(a) From 1cd26357f024874b2c3bfbb332289fe3bb7622b8 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 16 Jul 2008 22:59:10 +0000 Subject: [PATCH 6/8] Default to using rails. --- config/initializers/potlatch.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/initializers/potlatch.rb b/config/initializers/potlatch.rb index 880947148..b98d60e1a 100644 --- a/config/initializers/potlatch.rb +++ b/config/initializers/potlatch.rb @@ -3,4 +3,4 @@ POTLATCH_PRESETS = Potlatch::Potlatch.get_presets() # Use SQL (faster) or Rails (more elegant) for common Potlatch reads # getway speedup is approximately x2, whichways approximately x7 -POTLATCH_USE_SQL = true +POTLATCH_USE_SQL = false From 66b0dd135e31c58a16ecfc7dc006cd84d884a238 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 16 Jul 2008 23:10:32 +0000 Subject: [PATCH 7/8] Tidy up AMF controller and optimise a few rails things. --- app/controllers/amf_controller.rb | 218 ++++++++++++++++-------------- 1 file changed, 119 insertions(+), 99 deletions(-) diff --git a/app/controllers/amf_controller.rb b/app/controllers/amf_controller.rb index 28e2e4b2b..1ff85888c 100644 --- a/app/controllers/amf_controller.rb +++ b/app/controllers/amf_controller.rb @@ -110,14 +110,14 @@ class AmfController < ApplicationController # in a given bounding box. Nodes are returned in full; ways and relations # are IDs only. - def whichways(xmin,ymin,xmax,ymax) #:doc: - xmin-=0.01; ymin-=0.01 - xmax+=0.01; ymax+=0.01 + def whichways(xmin, ymin, xmax, ymax) #:doc: + xmin -= 0.01; ymin -= 0.01 + xmax += 0.01; ymax += 0.01 if POTLATCH_USE_SQL then - way_ids=sql_find_way_ids_in_area(xmin,ymin,xmax,ymax) - points=sql_find_pois_in_area(xmin,ymin,xmax,ymax) - relation_ids=sql_find_relations_in_area_and_ways(xmin,ymin,xmax,ymax,way_ids) + way_ids = sql_find_way_ids_in_area(xmin, ymin, xmax, ymax) + points = sql_find_pois_in_area(xmin, ymin, xmax, ymax) + relation_ids = sql_find_relations_in_area_and_ways(xmin, ymin, xmax, ymax, way_ids) else # find the way ids in an area nodes_in_area = Node.find_by_area(ymin, xmin, ymax, xmax, :conditions => "current_nodes.visible = 1", :include => :ways) @@ -129,22 +129,23 @@ class AmfController < ApplicationController # find the relations used by those nodes and ways relations = nodes_in_area.collect { |node| node.containing_relations.visible }.flatten + - way_ids.collect { |id| Way.find(id).containing_relations.visible }.flatten + way_ids.collect { |id| Way.find(id).containing_relations.visible }.flatten relation_ids = relations.collect { |relation| relation.id }.uniq end - [way_ids,points,relation_ids] + [way_ids, points, relation_ids] end # Find deleted ways in current bounding box (similar to whichways, but ways # with a deleted node only - not POIs or relations). - def whichways_deleted(xmin,ymin,xmax,ymax) #:doc: - xmin-=0.01; ymin-=0.01 - xmax+=0.01; ymax+=0.01 + def whichways_deleted(xmin, ymin, xmax, ymax) #:doc: + xmin -= 0.01; ymin -= 0.01 + xmax += 0.01; ymax += 0.01 - nodes_in_area = Node.find_by_area(ymin, xmin, ymax,xmax, :conditions => "current_nodes.visible=0 AND current_ways.visible=0", :include => :ways_via_history ) + nodes_in_area = Node.find_by_area(ymin, xmin, ymax, xmax, :conditions => "current_nodes.visible = 0 AND current_ways.visible = 0", :include => :ways_via_history) way_ids = nodes_in_area.collect { |node| node.ways_via_history_ids }.flatten.uniq + [way_ids] end @@ -153,20 +154,20 @@ class AmfController < ApplicationController def getway(wayid) #:doc: if POTLATCH_USE_SQL then - points=sql_get_nodes_in_way(wayid) - tags=sql_get_tags_in_way(wayid) + points = sql_get_nodes_in_way(wayid) + tags = sql_get_tags_in_way(wayid) else # Ideally we would do ":include => :nodes" here but if we do that # then rails only seems to return the first copy of a node when a # way includes a node more than once - points = [] way = Way.find(wayid) - way.nodes.each do |node| - points << [node.lon, node.lat, node.id, nil, node.tags_as_hash] + points = way.nodes.collect do |node| + [node.lon, node.lat, node.id, nil, node.tags_as_hash] end - tags=way.tags + tags = way.tags end - [wayid,points,tags] + + [wayid, points, tags] end # Get an old version of a way, and all constituent nodes. @@ -176,27 +177,28 @@ class AmfController < ApplicationController # at the time, generating a new id if it's still visible and has been moved/ # retagged. - def getway_old(id,version) #:doc: - if version<0 - old_way = OldWay.find(:first, :conditions => ['visible=1 AND id=?', id], :order => 'version DESC') + def getway_old(id, version) #:doc: + if version < 0 + old_way = OldWay.find(:first, :conditions => ['visible = 1 AND id = ?', id], :order => 'version DESC') points = old_way.get_nodes_undelete else - old_way = OldWay.find(:first, :conditions => ['id=? AND version=?', id, version]) + old_way = OldWay.find(:first, :conditions => ['id = ? AND version = ?', id, version]) points = old_way.get_nodes_revert end - old_way.tags['history']="Retrieved from v#{old_way.version}" - [0,id,points,old_way.tags,old_way.version] + + old_way.tags['history'] = "Retrieved from v#{old_way.version}" + + [0, id, points, old_way.tags, old_way.version] end # Find history of a way. Returns an array of previous versions. def getway_history(wayid) #:doc: - history=[] - way=Way.find(wayid) - way.old_ways.each do |old_way| - if old_way.user.data_public then user=old_way.user.display_name else user='anonymous' end - history<<[old_way.version,old_way.timestamp.strftime("%d %b %Y, %H:%M"),old_way.visible ? 1 : 0,user] + history = Way.find(wayid).old_ways.collect do |old_way| + user = old_way.user.data_public? ? old_way.user.display_name : 'anonymous' + [old_way.version, old_way.timestamp.strftime("%d %b %Y, %H:%M"), old_way.visible ? 1 : 0, user] end + [history] end @@ -208,7 +210,8 @@ class AmfController < ApplicationController def getrelation(relid) #:doc: rel = Relation.find(relid) - [relid,rel.tags,rel.members] + + [relid, rel.tags, rel.members] end # Save a relation. @@ -217,9 +220,9 @@ class AmfController < ApplicationController # 1. original relation id (unchanged), # 2. new relation id. - def putrelation(renumberednodes, renumberedways, usertoken,relid,tags,members,visible) #:doc: - uid=getuserid(usertoken) - if !uid then return -1,"You are not logged in, so the point could not be saved." end + def putrelation(renumberednodes, renumberedways, usertoken, relid, tags, members, visible) #:doc: + uid = getuserid(usertoken) + if !uid then return -1,"You are not logged in, so the relation could not be saved." end relid = relid.to_i visible = visible.to_i @@ -261,7 +264,7 @@ class AmfController < ApplicationController rel.save_with_history! #end - [0,relid,rel.id] + [0, relid, rel.id] end # Save a way to the database, including all nodes. Any nodes in the previous @@ -273,87 +276,94 @@ class AmfController < ApplicationController # 2. new way id, # 3. hash of renumbered nodes (old id=>new id) - def putway(renumberednodes,usertoken,originalway,points,attributes) #:doc: + def putway(renumberednodes, usertoken, originalway, points, attributes) #:doc: # -- Initialise and carry out checks - uid=getuserid(usertoken) + uid = getuserid(usertoken) if !uid then return -1,"You are not logged in, so the way could not be saved." end - originalway=originalway.to_i + + originalway = originalway.to_i points.each do |a| - if a[2]==0 or a[2].nil? then return -2,"Server error - node with id 0 found in way #{originalway}." end - if a[1]==90 then return -2,"Server error - node with lat -90 found in way #{originalway}." end + if a[2] == 0 or a[2].nil? then return -2,"Server error - node with id 0 found in way #{originalway}." end + if a[1] == 90 then return -2,"Server error - node with lat -90 found in way #{originalway}." end end - if points.length<2 then return -2,"Server error - way is only #{points.length} points long." end + if points.length < 2 then return -2,"Server error - way is only #{points.length} points long." end # -- Get unique nodes - if originalway<0 - way=Way.new - uniques=[] + if originalway < 0 + way = Way.new + uniques = [] else - way=Way.find(originalway) - uniques=way.unshared_node_ids + way = Way.find(originalway) + uniques = way.unshared_node_ids end # -- Compare nodes and save changes to any that have changed - nodes=[] + nodes = [] points.each do |n| - lon=n[0].to_f - lat=n[1].to_f - id =n[2].to_i - savenode=false + lon = n[0].to_f + lat = n[1].to_f + id = n[2].to_i + savenode = false + if renumberednodes[id] - id=renumberednodes[id] - elsif id<0 + id = renumberednodes[id] + elsif id < 0 # Create new node - node=Node.new - savenode=true + node = Node.new + savenode = true else - node=Node.find(id) - if (!fpcomp(lat,node.lat) or !fpcomp(lon,node.lon) or \ - Tags.join(n[4])!=node.tags or node.visible==0) - savenode=true + node = Node.find(id) + if !fpcomp(lat, node.lat) or !fpcomp(lon, node.lon) or + Tags.join(n[4]) != node.tags or !node.visible? + savenode = true end end + if savenode - node.user_id=uid - node.lat=lat; node.lon=lon - node.tags=Tags.join(n[4]) - node.visible=true + node.user_id = uid + node.lat = lat + node.lon = lon + node.tags = Tags.join(n[4]) + node.visible = true node.save_with_history! - if id!=node.id - renumberednodes[id]=node.id - id=node.id + + if id != node.id + renumberednodes[id] = node.id + id = node.id end end - uniques=uniques-[id] + + uniques = uniques - [id] nodes.push(id) end # -- Delete any unique nodes uniques.each do |n| - deleteitemrelations(n,'node') - node=Node.find(n) - node.user_id=uid - node.visible=false + deleteitemrelations(n, 'node') + + node = Node.find(n) + node.user_id = uid + node.visible = false node.save_with_history! end # -- Save revised way - way.tags=attributes - way.nds=nodes - way.user_id=uid - way.visible=true + way.tags = attributes + way.nds = nodes + way.user_id = uid + way.visible = true way.save_with_history! - [0,originalway,way.id,renumberednodes] + [0, originalway, way.id, renumberednodes] end # Save POI to the database. @@ -363,31 +373,32 @@ class AmfController < ApplicationController # 1. original node id (unchanged), # 2. new node id. - def putpoi(usertoken,id,lon,lat,tags,visible) #:doc: - uid=getuserid(usertoken) + def putpoi(usertoken, id, lon, lat, tags, visible) #:doc: + uid = getuserid(usertoken) if !uid then return -1,"You are not logged in, so the point could not be saved." end - id=id.to_i - visible=(visible.to_i==1) + id = id.to_i + visible = (visible.to_i == 1) + + if id > 0 then + node = Node.find(id) - if (id>0) then - node=Node.find(id) if !visible then unless node.ways.empty? then return -1,"The point has since become part of a way, so you cannot save it as a POI." end - deleteitemrelations(id,'node') + deleteitemrelations(id, 'node') end else - node=Node.new + node = Node.new end node.user_id = uid - node.latitude = (lat*10000000).round - node.longitude = (lon*10000000).round + node.lat = lat + node.lon = lon node.tags = Tags.join(tags) - node.visible=visible + node.visible = visible node.save_with_history! - newid=node.id - [0,id,newid] + + [0, id, node.id] end # Read POI from database @@ -397,18 +408,19 @@ class AmfController < ApplicationController def getpoi(id) #:doc: n = Node.find(id) + if n return [n.id, n.lon, n.lat, n.tags_as_hash] else - return [nil,nil,nil,''] + return [nil, nil, nil, ''] end end # Delete way and all constituent nodes. Also removes from any relations. # Returns 0 (success), unchanged way id. - def deleteway(usertoken,way_id) #:doc: - uid=getuserid(usertoken) + def deleteway(usertoken, way_id) #:doc: + uid = getuserid(usertoken) if !uid then return -1,"You are not logged in, so the way could not be deleted." end # FIXME: would be good not to make two history entries when removing @@ -416,11 +428,12 @@ class AmfController < ApplicationController user = User.find(uid) way = Way.find(way_id) way.unshared_node_ids.each do |n| - deleteitemrelations(n,'node') + deleteitemrelations(n, 'node') end way.delete_with_relations_and_nodes_and_history(user) - return [0,way_id] + + [0, way_id] end @@ -429,11 +442,13 @@ class AmfController < ApplicationController # Remove a node or way from all relations - def deleteitemrelations(objid,type) #:doc: - relationids = RelationMember.find(:all, :conditions => ['member_type=? and member_id=?', type, objid]).collect { |ws| ws.id }.uniq - relationids.each do |relid| - rel=Relation.find(relid) - rel.members.delete_if {|x| x[0]==type and x[1]==objid} + def deleteitemrelations(objid, type) #:doc: + relations = RelationMember.find(:all, + :conditions => ['member_type = ? and member_id = ?', type, objid], + :include => :relation).collect { |rm| rm.relation }.uniq + + relations.each do |rel| + rel.members.delete_if { |x| x[0] == type and x[1] == objid } rel.save_with_history! end end @@ -545,3 +560,8 @@ class AmfController < ApplicationController end end + +# Local Variables: +# indent-tabs-mode: t +# tab-width: 4 +# End: From d6e047d7d45ea76d56dccb53cc1fe1f5b54734d5 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 16 Jul 2008 23:42:59 +0000 Subject: [PATCH 8/8] Optimise finding of relations, partially reversing change #8443 but in a more rails like way. --- app/controllers/amf_controller.rb | 4 ++-- app/controllers/api_controller.rb | 6 +++--- app/models/relation.rb | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/app/controllers/amf_controller.rb b/app/controllers/amf_controller.rb index 1ff85888c..ce3dc91d5 100644 --- a/app/controllers/amf_controller.rb +++ b/app/controllers/amf_controller.rb @@ -128,8 +128,8 @@ class AmfController < ApplicationController points = nodes_not_used_in_area.collect { |n| [n.id, n.lon, n.lat, n.tags_as_hash] } # find the relations used by those nodes and ways - relations = nodes_in_area.collect { |node| node.containing_relations.visible }.flatten + - way_ids.collect { |id| Way.find(id).containing_relations.visible }.flatten + relations = Relation.find_for_nodes(nodes_in_area.collect { |n| n.id }, :conditions => "visible = 1") + + Relation.find_for_ways(way_ids, :conditions => "visible = 1") relation_ids = relations.collect { |relation| relation.id }.uniq end diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb index 8b735600d..6b36b41ae 100644 --- a/app/controllers/api_controller.rb +++ b/app/controllers/api_controller.rb @@ -176,15 +176,15 @@ class ApiController < ApplicationController end end - relations = visible_nodes.values.collect { |node| node.containing_relations.visible }.flatten + - way_ids.collect { |id| Way.find(id).containing_relations.visible }.flatten + relations = Relation.find_for_nodes(visible_nodes.keys, :conditions => "visible = 1") + + Relation.find_for_ways(way_ids, :conditions => "visible = 1") # we do not normally return the "other" partners referenced by an relation, # e.g. if we return a way A that is referenced by relation X, and there's # another way B also referenced, that is not returned. But we do make # an exception for cases where an relation references another *relation*; # in that case we return that as well (but we don't go recursive here) - relations += relations.collect { |relation| relation.containing_relations.visible }.flatten + relations += Relation.find_for_relations(relations.collect { |r| r.id }, :conditions => "visible = 1") # this "uniq" may be slightly inefficient; it may be better to first collect and output # all node-related relations, then find the *not yet covered* way-related ones etc. diff --git a/app/models/relation.rb b/app/models/relation.rb index 9ee118f6e..5d7092908 100644 --- a/app/models/relation.rb +++ b/app/models/relation.rb @@ -105,6 +105,24 @@ class Relation < ActiveRecord::Base return el1 end + def self.find_for_nodes(ids, options = {}) + self.with_scope(:find => { :joins => "INNER JOIN current_relation_members ON current_relation_members.id = current_relations.id", :conditions => "current_relation_members.member_type = 'node' AND current_relation_members.member_id IN (#{ids.join(',')})" }) do + return self.find(:all, options) + end + end + + def self.find_for_ways(ids, options = {}) + self.with_scope(:find => { :joins => "INNER JOIN current_relation_members ON current_relation_members.id = current_relations.id", :conditions => "current_relation_members.member_type = 'way' AND current_relation_members.member_id IN (#{ids.join(',')})" }) do + return self.find(:all, options) + end + end + + def self.find_for_relations(ids, options = {}) + self.with_scope(:find => { :joins => "INNER JOIN current_relation_members ON current_relation_members.id = current_relations.id", :conditions => "current_relation_members.member_type = 'relation' AND current_relation_members.member_id IN (#{ids.join(',')})" }) do + return self.find(:all, options) + end + end + # FIXME is this really needed? def members unless @members