diff --git a/app/controllers/amf_controller.rb b/app/controllers/amf_controller.rb
index 11ddc3f7c..51e49849f 100644
--- a/app/controllers/amf_controller.rb
+++ b/app/controllers/amf_controller.rb
@@ -1,20 +1,28 @@
-# AMF Controller is a semi-standalone API for Flash clients, particularly Potlatch.
-# All interaction between Potlatch (as a .SWF application) and the
+# amf_controller is a semi-standalone API for Flash clients, particularly
+# Potlatch. All interaction between Potlatch (as a .SWF application) and the
# OSM database takes place using this controller. Messages are
# encoded in the Actionscript Message Format (AMF).
#
-# See Also Potlatch::Potlatch and Potlatch::AMF
+# Helper functions are in /lib/potlatch.
#
-# Public domain.
-# editions Systeme D / Richard Fairhurst 2004-2008
+# Author:: editions Systeme D / Richard Fairhurst 2004-2008
+# Licence:: public domain.
#
-# All in/out parameters are floats unless explicitly stated.
+# == General structure
+#
+# Apart from the talk method (which distributes the requests from the
+# AMF message), each method generally takes arguments in the order they were
+# sent by the Potlatch SWF. Do not assume typing has been preserved. Methods
+# all return an array to the SWF.
#
-# to trap errors (getway_old,putway,putpoi,deleteway only):
-# return(-1,"message") <-- just puts up a dialogue
-# return(-2,"message") <-- also asks the user to e-mail me
-# to log:
-# RAILS_DEFAULT_LOGGER.error("Args: #{args[0]}, #{args[1]}, #{args[2]}, #{args[3]}")
+# == Debugging
+#
+# Any method that returns a status code (0 for ok) can also send:
+# return(-1,"message") <-- just puts up a dialogue
+# return(-2,"message") <-- also asks the user to e-mail me
+#
+# To write to the Rails log, use RAILS_DEFAULT_LOGGER.info("message").
+
class AmfController < ApplicationController
require 'stringio'
@@ -23,312 +31,254 @@ class AmfController < ApplicationController
session :off
before_filter :check_write_availability
- # Main AMF handler. Tha talk method takes in AMF, figures out what to do and dispatched to the appropriate private method
+ # Main AMF handler: processes the raw AMF string (using AMF library) and
+ # calls each action (private method) accordingly.
+
def talk
- req=StringIO.new(request.raw_post+0.chr) # Get POST data as request
- # (cf http://www.ruby-forum.com/topic/122163)
- req.read(2) # Skip version indicator and client ID
- results={} # Results of each body
- renumberednodes={} # Shared across repeated putways
- renumberedways={} # Shared across repeated putways
+ req=StringIO.new(request.raw_post+0.chr) # Get POST data as request
+ # (cf http://www.ruby-forum.com/topic/122163)
+ req.read(2) # Skip version indicator and client ID
+ results={} # Results of each body
+ renumberednodes={} # Shared across repeated putways
+ renumberedways={} # Shared across repeated putways
- # -------------
- # Parse request
+ # Parse request
- headers=AMF.getint(req) # Read number of headers
+ headers=AMF.getint(req) # Read number of headers
- headers.times do # Read each header
- name=AMF.getstring(req) # |
- req.getc # | skip boolean
- value=AMF.getvalue(req) # |
- header["name"]=value # |
- end
+ headers.times do # Read each header
+ name=AMF.getstring(req) # |
+ req.getc # | skip boolean
+ value=AMF.getvalue(req) # |
+ header["name"]=value # |
+ end
- bodies=AMF.getint(req) # Read number of bodies
- bodies.times do # Read each body
- message=AMF.getstring(req) # | get message name
- index=AMF.getstring(req) # | get index in response sequence
- bytes=AMF.getlong(req) # | get total size in bytes
- args=AMF.getvalue(req) # | get response (probably an array)
+ bodies=AMF.getint(req) # Read number of bodies
+ bodies.times do # Read each body
+ message=AMF.getstring(req) # | get message name
+ index=AMF.getstring(req) # | get index in response sequence
+ bytes=AMF.getlong(req) # | get total size in bytes
+ args=AMF.getvalue(req) # | get response (probably an array)
- case message
- when 'getpresets'; results[index]=AMF.putdata(index,getpresets)
- when 'whichways'; results[index]=AMF.putdata(index,whichways(args))
- when 'whichways_deleted'; results[index]=AMF.putdata(index,whichways_deleted(args))
- when 'getway'; results[index]=AMF.putdata(index,getway(args))
- when 'getrelation'; results[index]=AMF.putdata(index,getrelation(args))
- when 'getway_old'; results[index]=AMF.putdata(index,getway_old(args))
- when 'getway_history'; results[index]=AMF.putdata(index,getway_history(args))
- when 'putway'; r=putway(args,renumberednodes)
- renumberednodes=r[3]
- if r[1] != r[2]
- renumberedways[r[1]] = r[2]
- end
- results[index]=AMF.putdata(index,r)
- when 'putrelation'; results[index]=AMF.putdata(index,putrelation(args, renumberednodes, renumberedways))
- when 'deleteway'; results[index]=AMF.putdata(index,deleteway(args))
- when 'putpoi'; results[index]=AMF.putdata(index,putpoi(args))
- when 'getpoi'; results[index]=AMF.putdata(index,getpoi(args))
- end
- end
+ case message
+ when 'getpresets'; results[index]=AMF.putdata(index,getpresets())
+ when 'whichways'; results[index]=AMF.putdata(index,whichways(*args))
+ when 'whichways_deleted'; results[index]=AMF.putdata(index,whichways_deleted(*args))
+ when 'getway'; results[index]=AMF.putdata(index,getway(args[0].to_i))
+ when 'getrelation'; results[index]=AMF.putdata(index,getrelation(args[0].to_i))
+ when 'getway_old'; results[index]=AMF.putdata(index,getway_old(args[0].to_i,args[1].to_i))
+ when 'getway_history'; results[index]=AMF.putdata(index,getway_history(args[0].to_i))
+ when 'getnode_history'; results[index]=AMF.putdata(index,getnode_history(args[0].to_i))
+ when 'putway'; r=putway(renumberednodes,*args)
+ renumberednodes=r[3]
+ if r[1] != r[2]
+ renumberedways[r[1]] = r[2]
+ end
+ results[index]=AMF.putdata(index,r)
+ when 'putrelation'; results[index]=AMF.putdata(index,putrelation(renumberednodes, renumberedways, *args))
+ when 'findrelations'; results[index]=AMF.putdata(index,findrelations(*args))
+ when 'deleteway'; results[index]=AMF.putdata(index,deleteway(args[0],args[1].to_i))
+ when 'putpoi'; results[index]=AMF.putdata(index,putpoi(*args))
+ when 'getpoi'; results[index]=AMF.putdata(index,getpoi(*args))
+ end
+ end
- # ------------------
- # Write out response
+ # Write out response
- RAILS_DEFAULT_LOGGER.info(" Response: start")
- a,b=results.length.divmod(256)
- render :content_type => "application/x-amf", :text => proc { |response, output|
- output.write 0.chr+0.chr+0.chr+0.chr+a.chr+b.chr
- results.each do |k,v|
- output.write(v)
- end
- }
- RAILS_DEFAULT_LOGGER.info(" Response: end")
+ a,b=results.length.divmod(256)
+ render :content_type => "application/x-amf", :text => proc { |response, output|
+ output.write 0.chr+0.chr+0.chr+0.chr+a.chr+b.chr
+ results.each do |k,v|
+ output.write(v)
+ end
+ }
end
private
- # Return presets (default tags and crap) to potlatch.
- # Uses POTLATCH_PRESETS global, set up in OSM::Potlatch
- def getpresets #:doc:
- return POTLATCH_PRESETS
+ # Return presets (default tags, localisation etc.):
+ # uses POTLATCH_PRESETS global, set up in OSM::Potlatch.
+
+ def getpresets() #:doc:
+ return POTLATCH_PRESETS
end
- # ----- whichways
- # Find all the way ids and nodes (including tags and projected lat/lng) which aren't part of those ways in an are
- #
- # The argument is an array containing the following, in order:
- # 0. minimum longitude
- # 1. minimum latitude
- # 2. maximum longitude
- # 3. maximum latitude
- # 4. baselong, 5. basey, 6. masterscale as above
- def whichways(args) #:doc:
- xmin = args[0].to_f-0.01
- ymin = args[1].to_f-0.01
- xmax = args[2].to_f+0.01
- ymax = args[3].to_f+0.01
- baselong = args[4]
- basey = args[5]
- masterscale = args[6]
+ # Find all the ways, POI nodes (i.e. not part of ways), and relations
+ # in a given bounding box. Nodes are returned in full; ways and relations
+ # are IDs only.
- RAILS_DEFAULT_LOGGER.info(" Message: whichways, bbox=#{xmin},#{ymin},#{xmax},#{ymax}")
+ def whichways(xmin, ymin, xmax, ymax) #:doc:
+ xmin -= 0.01; ymin -= 0.01
+ xmax += 0.01; ymax += 0.01
- # find the way ids in an area
- nodes_in_area = Node.find_by_area(ymin, xmin, ymax, xmax, :conditions => "current_nodes.visible = 1", :include => :ways)
- way_ids = nodes_in_area.collect { |node| node.way_ids }.flatten.uniq
+ if POTLATCH_USE_SQL then
+ way_ids = sql_find_way_ids_in_area(xmin, ymin, xmax, ymax)
+ points = sql_find_pois_in_area(xmin, ymin, xmax, ymax)
+ relation_ids = sql_find_relations_in_area_and_ways(xmin, ymin, xmax, ymax, way_ids)
+ else
+ # find the way ids in an area
+ nodes_in_area = Node.find_by_area(ymin, xmin, ymax, xmax, :conditions => "current_nodes.visible = 1", :include => :ways)
+ way_ids = nodes_in_area.collect { |node| node.way_ids }.flatten.uniq
- # find the node ids in an area that aren't part of ways
- nodes_not_used_in_area = nodes_in_area.select { |node| node.ways.empty? }
- points = nodes_not_used_in_area.collect { |n| [n.id, n.lon_potlatch(baselong,masterscale), n.lat_potlatch(basey,masterscale), n.tags_as_hash] }
+ # find the node ids in an area that aren't part of ways
+ nodes_not_used_in_area = nodes_in_area.select { |node| node.ways.empty? }
+ points = nodes_not_used_in_area.collect { |n| [n.id, n.lon, n.lat, n.tags_as_hash] }
- # find the relations used by those nodes and ways
- relations = nodes_in_area.collect { |node| node.containing_relations.visible }.flatten +
- way_ids.collect { |id| Way.find(id).containing_relations.visible }.flatten
- relation_ids = relations.collect { |relation| relation.id }.uniq
+ # find the relations used by those nodes and ways
+ relations = Relation.find_for_nodes(nodes_in_area.collect { |n| n.id }, :conditions => "visible = 1") +
+ Relation.find_for_ways(way_ids, :conditions => "visible = 1")
+ relation_ids = relations.collect { |relation| relation.id }.uniq
+ end
- [way_ids,points,relation_ids]
+ [way_ids, points, relation_ids]
end
- # ----- whichways_deleted
- # return array of deleted ways in current bounding box
- # in: as whichways
- # does: finds all deleted ways with a deleted node in bounding box
- # out: [0] array of way ids
- def whichways_deleted(args) #:doc:
- xmin = args[0].to_f-0.01
- ymin = args[1].to_f-0.01
- xmax = args[2].to_f+0.01
- ymax = args[3].to_f+0.01
- baselong = args[4]
- basey = args[5]
- masterscale = args[6]
+ # Find deleted ways in current bounding box (similar to whichways, but ways
+ # with a deleted node only - not POIs or relations).
- sql=<<-EOF
- SELECT DISTINCT current_ways.id
- FROM current_nodes,way_nodes,current_ways
- WHERE #{OSM.sql_for_area(ymin, xmin, ymax, xmax, "current_nodes.")}
- AND way_nodes.node_id=current_nodes.id
- AND way_nodes.id=current_ways.id
- AND current_nodes.visible=0
- AND current_ways.visible=0
- EOF
- waylist = ActiveRecord::Base.connection.select_all(sql)
- ways = waylist.collect {|a| a['id'].to_i }
- [ways]
+ def whichways_deleted(xmin, ymin, xmax, ymax) #:doc:
+ xmin -= 0.01; ymin -= 0.01
+ xmax += 0.01; ymax += 0.01
+
+ nodes_in_area = Node.find_by_area(ymin, xmin, ymax, xmax, :conditions => "current_nodes.visible = 0 AND current_ways.visible = 0", :include => :ways_via_history)
+ way_ids = nodes_in_area.collect { |node| node.ways_via_history_ids }.flatten.uniq
+
+ [way_ids]
end
- # ----- getway
- # Get a way with all of it's nodes and tags
- # The input is an array with the following components, in order:
- # 0. wayid - the ID of the way to get
- # 1. baselong - origin of SWF map (longitude)
- # 2. basey - origin of SWF map (latitude)
- # 3. masterscale - SWF map scale
+ # Get a way including nodes and tags.
+ # Returns 0 (success), a Potlatch-style array of points, and a hash of tags.
+
+ def getway(wayid) #:doc:
+ if POTLATCH_USE_SQL then
+ points = sql_get_nodes_in_way(wayid)
+ tags = sql_get_tags_in_way(wayid)
+ else
+ # Ideally we would do ":include => :nodes" here but if we do that
+ # then rails only seems to return the first copy of a node when a
+ # way includes a node more than once
+ way = Way.find(wayid)
+ points = way.nodes.collect do |node|
+ [node.lon, node.lat, node.id, nil, node.tags_as_hash]
+ end
+ tags = way.tags
+ end
+
+ [wayid, points, tags]
+ end
+
+ # Get an old version of a way, and all constituent nodes.
#
- # The output is an array which contains all the nodes (with projected
- # latitude and longitude) and tags for a way (and all the nodes tags).
- # It also has the way's unprojected (WGS84) bbox.
- #
- # FIXME: The server really shouldn't be figuring out a ways bounding box and doing projection for potlatch
- # FIXME: the argument splitting should be done in the 'talk' method, not here
- def getway(args) #:doc:
- wayid,baselong,basey,masterscale = args
- wayid = wayid.to_i
+ # For undelete (version=0), always uses the most recent version of each node,
+ # even if it's moved. For revert (version=1+), uses the node in existence
+ # at the time, generating a new id if it's still visible and has been moved/
+ # retagged.
- RAILS_DEFAULT_LOGGER.info(" Message: getway, id=#{wayid}")
+ def getway_old(id, version) #:doc:
+ if version < 0
+ old_way = OldWay.find(:first, :conditions => ['visible = 1 AND id = ?', id], :order => 'version DESC')
+ points = old_way.get_nodes_undelete
+ else
+ old_way = OldWay.find(:first, :conditions => ['id = ? AND version = ?', id, version])
+ points = old_way.get_nodes_revert
+ end
- # Ideally we would do ":include => :nodes" here but if we do that
- # then rails only seems to return the first copy of a node when a
- # way includes a node more than once
- way = Way.find(wayid)
+ old_way.tags['history'] = "Retrieved from v#{old_way.version}"
- long_array = []
- lat_array = []
- points = []
+ [0, id, points, old_way.tags, old_way.version]
+ end
+
+ # Find history of a way. Returns 'way', id, and
+ # an array of previous versions.
- way.nodes.each do |node|
- projected_longitude = node.lon_potlatch(baselong,masterscale) # do projection for potlatch
- projected_latitude = node.lat_potlatch(basey,masterscale)
- id = node.id
- tags_hash = node.tags_as_hash
+ def getway_history(wayid) #:doc:
+ history = Way.find(wayid).old_ways.reverse.collect do |old_way|
+ user = old_way.user.data_public? ? old_way.user.display_name : 'anonymous'
+ uid = old_way.user.data_public? ? old_way.user.id : 0
+ [old_way.version, old_way.timestamp.strftime("%d %b %Y, %H:%M"), old_way.visible ? 1 : 0, user, uid]
+ end
- points << [projected_longitude, projected_latitude, id, nil, tags_hash]
- long_array << projected_longitude
- lat_array << projected_latitude
- end
-
- [wayid,points,way.tags,long_array.min,long_array.max,lat_array.min,lat_array.max]
+ ['way',wayid,history]
end
- # ----- getway_old
- # returns old version of way
- # in: [0] way id,
- # [1] way version to get (or -1 for "last deleted version")
- # [2] baselong, [3] basey, [4] masterscale
- # does: gets old version of way and all constituent nodes
- # for undelete, always uses the most recent version of each node
- # (even if it's moved)
- # for revert, uses the historic version of each node, but if that node is
- # still visible and has been changed since, generates a new node id
- # out: [0] 0 (code for success), [1] SWF object name,
- # [2] array of points (as getway _except_ [3] is node.visible?, 0 or 1),
- # [4] xmin, [5] xmax, [6] ymin, [7] ymax (unprojected bbox),
- # [8] way version
- def getway_old(args) #:doc:
- RAILS_DEFAULT_LOGGER.info(" Message: getway_old (server is #{SERVER_URL})")
- # if SERVER_URL=="www.openstreetmap.org" then return -1,"Revert is not currently enabled on the OpenStreetMap server." end
+ # Find history of a node. Returns 'node', id, and
+ # an array of previous versions.
- wayid,version,baselong,basey,masterscale=args
- wayid = wayid.to_i
- version = version.to_i
- xmin = ymin = 999999
- xmax = ymax = -999999
- points=[]
- if version<0
- historic=false
- version=getlastversion(wayid,version)
- else
- historic=true
- end
- readwayquery_old(wayid,version,historic).each { |row|
- points<<[long2coord(row['longitude'].to_f,baselong,masterscale),lat2coord(row['latitude'].to_f,basey,masterscale),row['id'].to_i,row['visible'].to_i,tag2array(row['tags'].to_s)]
- xmin=[xmin,row['longitude'].to_f].min
- xmax=[xmax,row['longitude'].to_f].max
- ymin=[ymin,row['latitude' ].to_f].min
- ymax=[ymax,row['latitude' ].to_f].max
- }
+ def getnode_history(nodeid) #:doc:
+ history = Node.find(nodeid).old_nodes.reverse.collect do |old_node|
+ user = old_node.user.data_public? ? old_node.user.display_name : 'anonymous'
+ uid = old_node.user.data_public? ? old_node.user.id : 0
+ [old_node.timestamp.to_i, old_node.timestamp.strftime("%d %b %Y, %H:%M"), old_node.visible ? 1 : 0, user, uid]
+ end
- # get tags from this version
- attributes={}
- attrlist=ActiveRecord::Base.connection.select_all "SELECT k,v FROM way_tags WHERE id=#{wayid} AND version=#{version}"
- attrlist.each {|a| attributes[a['k'].gsub(':','|')]=a['v'] }
- attributes['history']="Retrieved from v"+version.to_s
-
- [0,wayid,points,attributes,xmin,xmax,ymin,ymax,version]
+ ['node',nodeid,history]
end
- # ----- getway_history
- # find history of a way
- # in: [0] way id
- # does: finds history of a way
- # out: [0] array of previous versions (where each is
- # [0] version, [1] db timestamp (string),
- # [2] visible 0 or 1,
- # [3] username or 'anonymous' (string))
- def getway_history(args) #:doc:
- wayid=args[0]
- history=[]
- sql=<<-EOF
- SELECT version,timestamp,visible,display_name,data_public
- FROM ways,users
- WHERE ways.id=#{wayid}
- AND ways.user_id=users.id
- AND ways.visible=1
- ORDER BY version DESC
- EOF
- histlist=ActiveRecord::Base.connection.select_all(sql)
- histlist.each { |row|
- if row['data_public'].to_i==1 then user=row['display_name'] else user='anonymous' end
- history<<[row['version'],row['timestamp'],row['visible'],user]
- }
- [history]
+ # Get a relation with all tags and members.
+ # Returns:
+ # 0. relation id,
+ # 1. hash of tags,
+ # 2. list of members.
+
+ def getrelation(relid) #:doc:
+ rel = Relation.find(relid)
+
+ [relid, rel.tags, rel.members]
end
- # ----- getrelation
- # Get a relation with all of it's tags, and member IDs
- # The input is an array with the following components, in order:
- # 0. relid - the ID of the relation to get
- #
- # The output is an array which contains:
- # [0] relation id, [1] hash of tags, [2] list of members
- def getrelation(args) #:doc:
- relid = args[0]
- relid = relid.to_i
-
- RAILS_DEFAULT_LOGGER.info(" Message: getrel, id=#{relid}")
-
- rel = Relation.find(relid)
-
- [relid,rel.tags,rel.members]#nodes,ways]
+ # Find relations with specified name/id.
+ # Returns array of relations, each in same form as getrelation.
+
+ def findrelations(searchterm)
+ rels = []
+ if searchterm.to_i>0 then
+ rel = Relation.find(searchterm.to_i)
+ if rel and rel.visible then
+ rels.push([rel.id, rel.tags, rel.members])
+ end
+ else
+ RelationTag.find(:all, :limit => 11, :conditions => ["match(v) against (?)", searchterm] ).each do |t|
+ if t.relation.visible then
+ rels.push([t.relation.id, t.relation.tags, t.relation.members])
+ end
+ end
+ end
+ rels
end
- # ----- getrelation
- # save relation to the database
- # in: [0] user token (string),
- # [1] original relation id (may be negative),
- # [2] hash of tags, [3] list of members,
- # [4] visible
- # out: [0] 0 (success), [1] original relation id (unchanged),
- # [2] new relation id
- def putrelation(args, renumberednodes, renumberedways) #:doc:
- usertoken,relid,tags,members,visible=args
- uid=getuserid(usertoken)
- if !uid then return -1,"You are not logged in, so the point could not be saved." end
+ # Save a relation.
+ # Returns
+ # 0. 0 (success),
+ # 1. original relation id (unchanged),
+ # 2. new relation id.
- relid = relid.to_i
+ def putrelation(renumberednodes, renumberedways, usertoken, relid, tags, members, visible) #:doc:
+ uid = getuserid(usertoken)
+ if !uid then return -1,"You are not logged in, so the relation could not be saved." end
+
+ relid = relid.to_i
visible = visible.to_i
# create a new relation, or find the existing one
- if relid <= 0
- rel = Relation.new
- else
- rel = Relation.find(relid)
- end
+ if relid <= 0
+ rel = Relation.new
+ else
+ rel = Relation.find(relid)
+ end
- # check the members are all positive, and correctly type
- typedmembers = []
- members.each do |m|
- mid = m[1].to_i
- if mid < 0
- mid = renumberednodes[mid] if m[0] == 'node'
- mid = renumberedways[mid] if m[0] == 'way'
- if mid < 0
- return -2, "Negative ID unresolved"
- end
- end
- typedmembers << [m[0], mid, m[2]]
- end
+ # check the members are all positive, and correctly type
+ typedmembers = []
+ members.each do |m|
+ mid = m[1].to_i
+ if mid < 0
+ mid = renumberednodes[mid] if m[0] == 'node'
+ mid = renumberedways[mid] if m[0] == 'way'
+ if mid < 0
+ return -2, "Negative ID unresolved"
+ end
+ end
+ typedmembers << [m[0], mid, m[2]]
+ end
# assign new contents
rel.members = typedmembers
@@ -336,491 +286,318 @@ class AmfController < ApplicationController
rel.visible = visible
rel.user_id = uid
- # check it then save it
- # BUG: the following is commented out because it always fails on my
- # install. I think it's a Rails bug.
+ # check it then save it
+ # BUG: the following is commented out because it always fails on my
+ # install. I think it's a Rails bug.
- #if !rel.preconditions_ok?
- # return -2, "Relation preconditions failed"
- #else
- rel.save_with_history!
- #end
+ #if !rel.preconditions_ok?
+ # return -2, "Relation preconditions failed"
+ #else
+ rel.save_with_history!
+ #end
- [0,relid,rel.id]
+ [0, relid, rel.id]
end
- # ----- putway
- # saves a way to the database
- # in: [0] user token (string),
- # [1] original way id (may be negative),
- # [2] array of points (as getway/getway_old),
- # [3] hash of way tags,
- # [4] original way version (0 if not a reverted/undeleted way),
- # [5] baselong, [6] basey, [7] masterscale
- # does: saves way to the database
- # all constituent nodes are created/updated as necessary
- # (or deleted if they were in the old version and are otherwise unused)
- # out: [0] 0 (code for success), [1] original way id (unchanged),
- # [2] new way id, [3] hash of renumbered nodes (old id=>new id),
- # [4] xmin, [5] xmax, [6] ymin, [7] ymax (unprojected bbox)
- def putway(args,renumberednodes) #:doc:
- RAILS_DEFAULT_LOGGER.info(" putway started")
- usertoken,originalway,points,attributes,oldversion,baselong,basey,masterscale=args
- uid=getuserid(usertoken)
- if !uid then return -1,"You are not logged in, so the way could not be saved." end
+ # Save a way to the database, including all nodes. Any nodes in the previous
+ # version and no longer used are deleted.
+ #
+ # Returns:
+ # 0. '0' (code for success),
+ # 1. original way id (unchanged),
+ # 2. new way id,
+ # 3. hash of renumbered nodes (old id=>new id)
- RAILS_DEFAULT_LOGGER.info(" putway authenticated happily")
- db_uqn='unin'+(rand*100).to_i.to_s+uid.to_s+originalway.to_i.abs.to_s+Time.new.to_i.to_s # temp uniquenodes table name, typically 51 chars
- db_now='@now'+(rand*100).to_i.to_s+uid.to_s+originalway.to_i.abs.to_s+Time.new.to_i.to_s # 'now' variable name, typically 51 chars
- ActiveRecord::Base.connection.execute("SET #{db_now}=NOW()")
- originalway=originalway.to_i
- oldversion=oldversion.to_i
+ def putway(renumberednodes, usertoken, originalway, points, attributes) #:doc:
- RAILS_DEFAULT_LOGGER.info(" Message: putway, id=#{originalway}")
+ # -- Initialise and carry out checks
+
+ uid = getuserid(usertoken)
+ if !uid then return -1,"You are not logged in, so the way could not be saved." end
- # -- Check for null IDs, short ways or lats=90
+ originalway = originalway.to_i
- points.each do |a|
- if a[2]==0 or a[2].nil? then return -2,"Server error - node with id 0 found in way #{originalway}." end
- if coord2lat(a[1],masterscale,basey)==90 then return -2,"Server error - node with lat -90 found in way #{originalway}." end
- end
-
- if points.length<2 then return -2,"Server error - way is only #{points.length} points long." end
+ points.each do |a|
+ if a[2] == 0 or a[2].nil? then return -2,"Server error - node with id 0 found in way #{originalway}." end
+ if a[1] == 90 then return -2,"Server error - node with lat -90 found in way #{originalway}." end
+ end
- # -- 3. read original way into memory
+ if points.length < 2 then return -2,"Server error - way is only #{points.length} points long." end
- xc={}; yc={}; tagc={}; vc={}
- if originalway>0
- way=originalway
- if oldversion==0 then r=readwayquery(way,false)
- else r=readwayquery_old(way,oldversion,true) end
- r.each { |row|
- id=row['id'].to_i
- if (id>0) then
- xc[id]=row['longitude'].to_f
- yc[id]=row['latitude' ].to_f
- tagc[id]=row['tags']
- vc[id]=row['visible'].to_i
- end
- }
- ActiveRecord::Base.connection.update("UPDATE current_ways SET timestamp=#{db_now},user_id=#{uid},visible=1 WHERE id=#{way}")
- else
- way=ActiveRecord::Base.connection.insert("INSERT INTO current_ways (user_id,timestamp,visible) VALUES (#{uid},#{db_now},1)")
- end
+ # -- Get unique nodes
- # -- 4. get version by inserting new row into ways
+ if originalway < 0
+ way = Way.new
+ uniques = []
+ else
+ way = Way.find(originalway)
+ uniques = way.unshared_node_ids
+ end
- version=ActiveRecord::Base.connection.insert("INSERT INTO ways (id,user_id,timestamp,visible) VALUES (#{way},#{uid},#{db_now},1)")
+ # -- Compare nodes and save changes to any that have changed
- # -- 5. compare nodes and update xmin,xmax,ymin,ymax
+ nodes = []
- xmin=ymin= 999999
- xmax=ymax=-999999
- insertsql=''
- nodelist=[]
+ points.each do |n|
+ lon = n[0].to_f
+ lat = n[1].to_f
+ id = n[2].to_i
+ savenode = false
- points.each_index do |i|
- xs=coord2long(points[i][0],masterscale,baselong)
- ys=coord2lat(points[i][1],masterscale,basey)
- xmin=[xs,xmin].min; xmax=[xs,xmax].max
- ymin=[ys,ymin].min; ymax=[ys,ymax].max
- node=points[i][2].to_i
- tagstr=array2tag(points[i][4])
- tagsql="'"+sqlescape(tagstr)+"'"
- lat=(ys * 10000000).round
- long=(xs * 10000000).round
- tile=QuadTile.tile_for_point(ys, xs)
-
- # compare node
- if node<0
- # new node - create
- if renumberednodes[node.to_s].nil?
- newnode=ActiveRecord::Base.connection.insert("INSERT INTO current_nodes ( latitude,longitude,timestamp,user_id,visible,tags,tile) VALUES ( #{lat},#{long},#{db_now},#{uid},1,#{tagsql},#{tile})")
- ActiveRecord::Base.connection.insert("INSERT INTO nodes (id,latitude,longitude,timestamp,user_id,visible,tags,tile) VALUES (#{newnode},#{lat},#{long},#{db_now},#{uid},1,#{tagsql},#{tile})")
- points[i][2]=newnode
- nodelist.push(newnode)
- renumberednodes[node.to_s]=newnode.to_s
- else
- points[i][2]=renumberednodes[node.to_s].to_i
- end
-
- elsif xc.has_key?(node)
- nodelist.push(node)
- # old node from original way - update
- if ((xs/0.0000001).round!=(xc[node]/0.0000001).round or (ys/0.0000001).round!=(yc[node]/0.0000001).round or tagstr!=tagc[node] or vc[node]==0)
- ActiveRecord::Base.connection.insert("INSERT INTO nodes (id,latitude,longitude,timestamp,user_id,visible,tags,tile) VALUES (#{node},#{lat},#{long},#{db_now},#{uid},1,#{tagsql},#{tile})")
- ActiveRecord::Base.connection.update("UPDATE current_nodes SET latitude=#{lat},longitude=#{long},timestamp=#{db_now},user_id=#{uid},tags=#{tagsql},visible=1,tile=#{tile} WHERE id=#{node}")
- end
- else
- # old node, created in another way and now added to this way
- end
- end
-
- # -- 6a. delete any nodes not in modified way
-
- createuniquenodes(way,db_uqn,nodelist) # nodes which appear in this way but no other
-
- sql=<<-EOF
- INSERT INTO nodes (id,latitude,longitude,timestamp,user_id,visible,tile)
- SELECT DISTINCT cn.id,cn.latitude,cn.longitude,#{db_now},#{uid},0,cn.tile
- FROM current_nodes AS cn,#{db_uqn}
- WHERE cn.id=node_id
- EOF
- ActiveRecord::Base.connection.insert(sql)
-
- sql=<<-EOF
- UPDATE current_nodes AS cn, #{db_uqn}
- SET cn.timestamp=#{db_now},cn.visible=0,cn.user_id=#{uid}
- WHERE cn.id=node_id
- EOF
- ActiveRecord::Base.connection.update(sql)
-
- deleteuniquenoderelations(db_uqn,uid,db_now)
- ActiveRecord::Base.connection.execute("DROP TEMPORARY TABLE #{db_uqn}")
-
- # 6b. insert new version of route into way_nodes
-
- insertsql =''
- currentsql=''
- sequence =1
- points.each do |p|
- if insertsql !='' then insertsql +=',' end
- if currentsql!='' then currentsql+=',' end
- insertsql +="(#{way},#{p[2]},#{sequence},#{version})"
- currentsql+="(#{way},#{p[2]},#{sequence})"
- sequence +=1
- end
-
- ActiveRecord::Base.connection.execute("DELETE FROM current_way_nodes WHERE id=#{way}");
- ActiveRecord::Base.connection.insert( "INSERT INTO way_nodes (id,node_id,sequence_id,version) VALUES #{insertsql}");
- ActiveRecord::Base.connection.insert( "INSERT INTO current_way_nodes (id,node_id,sequence_id ) VALUES #{currentsql}");
-
- # -- 7. insert new way tags
-
- insertsql =''
- currentsql=''
- attributes.each do |k,v|
- if v=='' or v.nil? then next end
- if v[0,6]=='(type ' then next end
- if insertsql !='' then insertsql +=',' end
- if currentsql!='' then currentsql+=',' end
- insertsql +="(#{way},'"+sqlescape(k.gsub('|',':'))+"','"+sqlescape(v)+"',#{version})"
- currentsql+="(#{way},'"+sqlescape(k.gsub('|',':'))+"','"+sqlescape(v)+"')"
- end
-
- ActiveRecord::Base.connection.execute("DELETE FROM current_way_tags WHERE id=#{way}")
- if (insertsql !='') then ActiveRecord::Base.connection.insert("INSERT INTO way_tags (id,k,v,version) VALUES #{insertsql}" ) end
- if (currentsql!='') then ActiveRecord::Base.connection.insert("INSERT INTO current_way_tags (id,k,v) VALUES #{currentsql}") end
-
- [0,originalway,way,renumberednodes,xmin,xmax,ymin,ymax]
- end
-
- # ----- putpoi
- # save POI to the database
- # in: [0] user token (string),
- # [1] original node id (may be negative),
- # [2] projected longitude, [3] projected latitude,
- # [4] hash of tags, [5] visible (0 to delete, 1 otherwise),
- # [6] baselong, [7] basey, [8] masterscale
- # does: saves POI node to the database
- # refuses save if the node has since become part of a way
- # out: [0] 0 (success), [1] original node id (unchanged),
- # [2] new node id
- def putpoi(args) #:doc:
- usertoken,id,x,y,tags,visible,baselong,basey,masterscale=args
- uid=getuserid(usertoken)
- if !uid then return -1,"You are not logged in, so the point could not be saved." end
-
- db_now='@now'+(rand*100).to_i.to_s+uid.to_s+id.to_i.abs.to_s+Time.new.to_i.to_s # 'now' variable name, typically 51 chars
- ActiveRecord::Base.connection.execute("SET #{db_now}=NOW()")
-
- id=id.to_i
- visible=visible.to_i
- if visible==0 then
- # if deleting, check node hasn't become part of a way
- inway=ActiveRecord::Base.connection.select_one("SELECT cw.id FROM current_ways cw,current_way_nodes cwn WHERE cw.id=cwn.id AND cw.visible=1 AND cwn.node_id=#{id} LIMIT 1")
- unless inway.nil? then return -1,"The point has since become part of a way, so you cannot save it as a POI." end
- deleteitemrelations(id,'node',uid,db_now)
- end
-
- x=coord2long(x.to_f,masterscale,baselong)
- y=coord2lat(y.to_f,masterscale,basey)
- tagsql="'"+sqlescape(array2tag(tags))+"'"
- lat=(y * 10000000).round
- long=(x * 10000000).round
- tile=QuadTile.tile_for_point(y, x)
-
- if (id>0) then
- ActiveRecord::Base.connection.insert("INSERT INTO nodes (id,latitude,longitude,timestamp,user_id,visible,tags,tile) VALUES (#{id},#{lat},#{long},#{db_now},#{uid},#{visible},#{tagsql},#{tile})");
- ActiveRecord::Base.connection.update("UPDATE current_nodes SET latitude=#{lat},longitude=#{long},timestamp=#{db_now},user_id=#{uid},visible=#{visible},tags=#{tagsql},tile=#{tile} WHERE id=#{id}");
- newid=id
- else
- newid=ActiveRecord::Base.connection.insert("INSERT INTO current_nodes (latitude,longitude,timestamp,user_id,visible,tags,tile) VALUES (#{lat},#{long},#{db_now},#{uid},#{visible},#{tagsql},#{tile})");
- ActiveRecord::Base.connection.update("INSERT INTO nodes (id,latitude,longitude,timestamp,user_id,visible,tags,tile) VALUES (#{newid},#{lat},#{long},#{db_now},#{uid},#{visible},#{tagsql},#{tile})");
- end
- [0,id,newid]
- end
-
- # ----- getpoi
- # read POI from database
- # (only called on revert: POIs are usually read by whichways)
- # in: [0] node id, [1] baselong, [2] basey, [3] masterscale
- # does: reads POI
- # out: [0] id (unchanged), [1] projected long, [2] projected lat,
- # [3] hash of tags
- def getpoi(args) #:doc:
- id,baselong,basey,masterscale = args
-
- n = Node.find(id.to_i)
- if n
- return [n.id, n.lon_potlatch(baselong,masterscale), n.lat_potlatch(basey,masterscale), n.tags_as_hash]
- else
- return [nil,nil,nil,'']
- end
- end
-
- # ----- deleteway
- # delete way and constituent nodes from database
- # in: [0] user token (string), [1] way id
- # does: deletes way from db and any constituent nodes not used elsewhere
- # also removes ways/nodes from any relations they're in
- # out: [0] 0 (success), [1] way id (unchanged)
-
- def deleteway(args) #:doc:
- usertoken,way_id=args
- RAILS_DEFAULT_LOGGER.info(" Message: deleteway, id=#{way_id}")
- uid=getuserid(usertoken)
- if !uid then return -1,"You are not logged in, so the way could not be deleted." end
-
- # FIXME
- # the next bit removes the way from any relations
- # the delete_with_relations_and_nodes_and_history method should do this,
- # but at present it just throws a 'precondition failed'
- way=way.to_i
- db_now='@now'+(rand*100).to_i.to_s+uid.to_s+way.abs.to_s+Time.new.to_i.to_s
- db_uqn='unin'+(rand*100).to_i.to_s+uid.to_s+way.abs.to_s+Time.new.to_i.to_s
- ActiveRecord::Base.connection.execute("SET #{db_now}=NOW()")
- createuniquenodes(way,db_uqn,[])
- deleteuniquenoderelations(db_uqn,uid,db_now)
- deleteitemrelations(way_id,'way',uid,db_now)
- ActiveRecord::Base.connection.execute("DROP TEMPORARY TABLE #{db_uqn}")
- # end of FIXME
-
- # now delete the way
- user = User.find(uid)
- way = Way.find(way_id)
- way.delete_with_relations_and_nodes_and_history(user)
- return [0,way_id]
- end
-
-
- def readwayquery(id,insistonvisible) #:doc:
- sql=<<-EOF
- SELECT latitude*0.0000001 AS latitude,longitude*0.0000001 AS longitude,current_nodes.id,tags,visible
- FROM current_way_nodes,current_nodes
- WHERE current_way_nodes.id=#{id}
- AND current_way_nodes.node_id=current_nodes.id
- EOF
- if insistonvisible then sql+=" AND current_nodes.visible=1 " end
- sql+=" ORDER BY sequence_id"
- ActiveRecord::Base.connection.select_all(sql)
- end
-
- # Get the latest version id of a way
- def getlastversion(id,version) #:doc:
- old_way = OldWay.find(:first, :conditions => ['visible=1 AND id=?' , id], :order => 'version DESC')
- old_way.version
- end
-
- def readwayquery_old(id,version,historic) #:doc:
- # Node handling on undelete (historic=false):
- # - always use the node specified, even if it's moved
-
- # Node handling on revert (historic=true):
- # - if it's a visible node, use a new node id (i.e. not mucking up the old one)
- # which means the SWF needs to allocate new ids
- # - if it's an invisible node, we can reuse the old node id
-
- # ----- get node list from specified version of way,
- # and the _current_ lat/long/tags of each node
-
- row=ActiveRecord::Base.connection.select_one("SELECT timestamp FROM ways WHERE version=#{version} AND id=#{id}")
- waytime=row['timestamp']
-
- sql=<<-EOF
- SELECT cn.id,visible,latitude*0.0000001 AS latitude,longitude*0.0000001 AS longitude,tags
- FROM way_nodes wn,current_nodes cn
- WHERE wn.version=#{version}
- AND wn.id=#{id}
- AND wn.node_id=cn.id
- ORDER BY sequence_id
- EOF
- rows=ActiveRecord::Base.connection.select_all(sql)
-
- # ----- if historic (full revert), get the old version of each node
- # - if it's in another way now, generate a new id
- # - if it's not in another way, use the old ID
-
- if historic then
- rows.each_index do |i|
- sql=<<-EOF
- SELECT latitude*0.0000001 AS latitude,longitude*0.0000001 AS longitude,tags,cwn.id AS currentway
- FROM nodes n
- LEFT JOIN current_way_nodes cwn
- ON cwn.node_id=n.id AND cwn.id!=#{id}
- WHERE n.id=#{rows[i]['id']}
- AND n.timestamp<="#{waytime}"
- ORDER BY n.timestamp DESC
- LIMIT 1
- EOF
- row=ActiveRecord::Base.connection.select_one(sql)
- nx=row['longitude'].to_f
- ny=row['latitude'].to_f
- if (!row.nil?)
- if (row['currentway'] && (nx!=rows[i]['longitude'].to_f or ny!=rows[i]['latitude'].to_f or row['tags']!=rows[i]['tags'])) then rows[i]['id']=-1 end
+ if renumberednodes[id]
+ id = renumberednodes[id]
+ elsif id < 0
+ # Create new node
+ node = Node.new
+ savenode = true
+ else
+ node = Node.find(id)
+ if !fpcomp(lat, node.lat) or !fpcomp(lon, node.lon) or
+ Tags.join(n[4]) != node.tags or !node.visible?
+ savenode = true
end
- rows[i]['longitude']=nx
- rows[i]['latitude' ]=ny
- rows[i]['tags' ]=row['tags']
- end
- end
- rows
+ end
+
+ if savenode
+ node.user_id = uid
+ node.lat = lat
+ node.lon = lon
+ node.tags = Tags.join(n[4])
+ node.visible = true
+ node.save_with_history!
+
+ if id != node.id
+ renumberednodes[id] = node.id
+ id = node.id
+ end
+ end
+
+ uniques = uniques - [id]
+ nodes.push(id)
+ end
+
+ # -- Delete any unique nodes
+
+ uniques.each do |n|
+ deleteitemrelations(n, 'node')
+
+ node = Node.find(n)
+ node.user_id = uid
+ node.visible = false
+ node.save_with_history!
+ end
+
+ # -- Save revised way
+
+ way.tags = attributes
+ way.nds = nodes
+ way.user_id = uid
+ way.visible = true
+ way.save_with_history!
+
+ [0, originalway, way.id, renumberednodes]
end
- def createuniquenodes(way,uqn_name,nodelist) #:doc:
- # Find nodes which appear in this way but no others
- sql=<<-EOF
- CREATE TEMPORARY TABLE #{uqn_name}
- SELECT a.node_id
- FROM (SELECT DISTINCT node_id FROM current_way_nodes
- WHERE id=#{way}) a
- LEFT JOIN current_way_nodes b
- ON b.node_id=a.node_id
- AND b.id!=#{way}
- WHERE b.node_id IS NULL
- EOF
- unless nodelist.empty? then
- sql+="AND a.node_id NOT IN ("+nodelist.join(',')+")"
- end
- ActiveRecord::Base.connection.execute(sql)
+ # Save POI to the database.
+ # Refuses save if the node has since become part of a way.
+ # Returns:
+ # 0. 0 (success),
+ # 1. original node id (unchanged),
+ # 2. new node id.
+
+ def putpoi(usertoken, id, lon, lat, tags, visible) #:doc:
+ uid = getuserid(usertoken)
+ if !uid then return -1,"You are not logged in, so the point could not be saved." end
+
+ id = id.to_i
+ visible = (visible.to_i == 1)
+
+ if id > 0 then
+ node = Node.find(id)
+
+ if !visible then
+ unless node.ways.empty? then return -1,"The point has since become part of a way, so you cannot save it as a POI." end
+ deleteitemrelations(id, 'node')
+ end
+ else
+ node = Node.new
+ end
+
+ node.user_id = uid
+ node.lat = lat
+ node.lon = lon
+ node.tags = Tags.join(tags)
+ node.visible = visible
+ node.save_with_history!
+
+ [0, id, node.id]
end
+ # Read POI from database
+ # (only called on revert: POIs are usually read by whichways).
+ #
+ # Returns array of id, long, lat, hash of tags.
+
+ def getpoi(id,timestamp) #:doc:
+ if timestamp>0 then
+ n = OldNode.find(id, :conditions=>['UNIX_TIMESTAMP(timestamp)=?',timestamp])
+ else
+ n = Node.find(id)
+ end
+
+ if n
+ return [n.id, n.lon, n.lat, n.tags_as_hash]
+ else
+ return [nil, nil, nil, '']
+ end
+ end
+
+ # Delete way and all constituent nodes. Also removes from any relations.
+ # Returns 0 (success), unchanged way id.
+
+ def deleteway(usertoken, way_id) #:doc:
+ uid = getuserid(usertoken)
+ if !uid then return -1,"You are not logged in, so the way could not be deleted." end
+
+ # FIXME: would be good not to make two history entries when removing
+ # two nodes from the same relation
+ user = User.find(uid)
+ way = Way.find(way_id)
+ way.unshared_node_ids.each do |n|
+ deleteitemrelations(n, 'node')
+ end
+
+ way.delete_with_relations_and_nodes_and_history(user)
+
+ [0, way_id]
+ end
# ====================================================================
- # Relations handling
- # deleteuniquenoderelations(uqn_name,uid,db_now)
- # deleteitemrelations(way|node,'way'|'node',uid,db_now)
+ # Support functions
- def deleteuniquenoderelations(uqn_name,uid,db_now) #:doc:
- sql=<<-EOF
- SELECT node_id,cr.id FROM #{uqn_name},current_relation_members crm,current_relations cr
- WHERE crm.member_id=node_id
- AND crm.member_type='node'
- AND crm.id=cr.id
- AND cr.visible=1
- EOF
+ # Remove a node or way from all relations
- relnodes=ActiveRecord::Base.connection.select_all(sql)
- relnodes.each do |a|
- removefromrelation(a['node_id'],'node',a['id'],uid,db_now)
- end
+ def deleteitemrelations(objid, type) #:doc:
+ relations = RelationMember.find(:all,
+ :conditions => ['member_type = ? and member_id = ?', type, objid],
+ :include => :relation).collect { |rm| rm.relation }.uniq
+
+ relations.each do |rel|
+ rel.members.delete_if { |x| x[0] == type and x[1] == objid }
+ rel.save_with_history!
+ end
end
- def deleteitemrelations(objid,type,uid,db_now) #:doc:
- sql=<<-EOF
- SELECT cr.id FROM current_relation_members crm,current_relations cr
- WHERE crm.member_id=#{objid}
- AND crm.member_type='#{type}'
- AND crm.id=cr.id
- AND cr.visible=1
- EOF
+ # Break out node tags into a hash
+ # (should become obsolete as of API 0.6)
- relways=ActiveRecord::Base.connection.select_all(sql)
- relways.each do |a|
- removefromrelation(objid,type,a['id'],uid,db_now)
- end
+ def tagstring_to_hash(a) #:doc:
+ tags={}
+ Tags.split(a) do |k, v|
+ tags[k]=v
+ end
+ tags
end
- def removefromrelation(objid,type,relation,uid,db_now) #:doc:
- rver=ActiveRecord::Base.connection.insert("INSERT INTO relations (id,user_id,timestamp,visible) VALUES (#{relation},#{uid},#{db_now},1)")
-
- tagsql=<<-EOF
- INSERT INTO relation_tags (id,k,v,version)
- SELECT id,k,v,#{rver} FROM current_relation_tags
- WHERE id=#{relation}
- EOF
- ActiveRecord::Base.connection.insert(tagsql)
-
- membersql=<<-EOF
- INSERT INTO relation_members (id,member_type,member_id,member_role,version)
- SELECT id,member_type,member_id,member_role,#{rver} FROM current_relation_members
- WHERE id=#{relation}
- AND (member_id!=#{objid} OR member_type!='#{type}')
- EOF
- ActiveRecord::Base.connection.insert(membersql)
-
- ActiveRecord::Base.connection.update("UPDATE current_relations SET user_id=#{uid},timestamp=#{db_now} WHERE id=#{relation}")
- ActiveRecord::Base.connection.execute("DELETE FROM current_relation_members WHERE id=#{relation} AND member_type='#{type}' AND member_id=#{objid}")
- end
-
- def sqlescape(a) #:doc:
- a.gsub(/[\000-\037]/,"").gsub("'","''").gsub(92.chr) {92.chr+92.chr}
- end
-
- def tag2array(a) #:doc:
- tags={}
- Tags.split(a) do |k, v|
- tags[k.gsub(':','|')]=v
- end
- tags
- end
-
- def array2tag(a) #:doc:
- tags = []
- a.each do |k,v|
- if v=='' then next end
- if v[0,6]=='(type ' then next end
- tags << [k.gsub('|',':'), v]
- end
- return Tags.join(tags)
- end
+ # Authenticate token
+ # (could be removed if no-one uses the username+password form)
def getuserid(token) #:doc:
- if (token =~ /^(.+)\+(.+)$/) then
- user = User.authenticate(:username => $1, :password => $2)
- else
- user = User.authenticate(:token => token)
- end
+ if (token =~ /^(.+)\+(.+)$/) then
+ user = User.authenticate(:username => $1, :password => $2)
+ else
+ user = User.authenticate(:token => token)
+ end
- return user ? user.id : nil;
+ return user ? user.id : nil;
end
+ # Compare two floating-point numbers to within 0.0000001
+
+ def fpcomp(a,b) #:doc:
+ return ((a/0.0000001).round==(b/0.0000001).round)
+ end
+
+
# ====================================================================
- # Co-ordinate conversion
+ # Alternative SQL queries for getway/whichways
- def lat2coord(a,basey,masterscale) #:doc:
- -(lat2y(a)-basey)*masterscale
+ def sql_find_way_ids_in_area(xmin,ymin,xmax,ymax)
+ sql=<<-EOF
+ SELECT DISTINCT current_way_nodes.id AS wayid
+ FROM current_way_nodes
+ INNER JOIN current_nodes ON current_nodes.id=current_way_nodes.node_id
+ INNER JOIN current_ways ON current_ways.id =current_way_nodes.id
+ WHERE current_nodes.visible=1
+ AND current_ways.visible=1
+ AND #{OSM.sql_for_area(ymin, xmin, ymax, xmax, "current_nodes.")}
+ EOF
+ return ActiveRecord::Base.connection.select_all(sql).collect { |a| a['wayid'].to_i }
end
-
- def long2coord(a,baselong,masterscale) #:doc:
- (a-baselong)*masterscale
+
+ def sql_find_pois_in_area(xmin,ymin,xmax,ymax)
+ sql=<<-EOF
+ SELECT current_nodes.id,current_nodes.latitude*0.0000001 AS lat,current_nodes.longitude*0.0000001 AS lon,current_nodes.tags
+ FROM current_nodes
+ LEFT OUTER JOIN current_way_nodes cwn ON cwn.node_id=current_nodes.id
+ WHERE current_nodes.visible=1
+ AND cwn.id IS NULL
+ AND #{OSM.sql_for_area(ymin, xmin, ymax, xmax, "current_nodes.")}
+ EOF
+ return ActiveRecord::Base.connection.select_all(sql).collect { |n| [n['id'].to_i,n['lon'].to_f,n['lat'].to_f,tagstring_to_hash(n['tags'])] }
end
-
- def lat2y(a) #:doc:
- 180/Math::PI * Math.log(Math.tan(Math::PI/4+a*(Math::PI/180)/2))
+
+ def sql_find_relations_in_area_and_ways(xmin,ymin,xmax,ymax,way_ids)
+ # ** It would be more Potlatchy to get relations for nodes within ways
+ # during 'getway', not here
+ sql=<<-EOF
+ SELECT DISTINCT cr.id AS relid
+ FROM current_relations cr
+ INNER JOIN current_relation_members crm ON crm.id=cr.id
+ INNER JOIN current_nodes cn ON crm.member_id=cn.id AND crm.member_type='node'
+ WHERE #{OSM.sql_for_area(ymin, xmin, ymax, xmax, "cn.")}
+ EOF
+ unless way_ids.empty?
+ sql+=<<-EOF
+ UNION
+ SELECT DISTINCT cr.id AS relid
+ FROM current_relations cr
+ INNER JOIN current_relation_members crm ON crm.id=cr.id
+ WHERE crm.member_type='way'
+ AND crm.member_id IN (#{way_ids.join(',')})
+ EOF
+ end
+ return ActiveRecord::Base.connection.select_all(sql).collect { |a| a['relid'].to_i }.uniq
end
-
- def coord2lat(a,masterscale,basey) #:doc:
- y2lat(a/-masterscale+basey)
+
+ def sql_get_nodes_in_way(wayid)
+ points=[]
+ sql=<<-EOF
+ SELECT latitude*0.0000001 AS lat,longitude*0.0000001 AS lon,current_nodes.id,tags
+ FROM current_way_nodes,current_nodes
+ WHERE current_way_nodes.id=#{wayid.to_i}
+ AND current_way_nodes.node_id=current_nodes.id
+ AND current_nodes.visible=1
+ ORDER BY sequence_id
+ EOF
+ ActiveRecord::Base.connection.select_all(sql).each do |row|
+ points << [row['lon'].to_f,row['lat'].to_f,row['id'].to_i,nil,tagstring_to_hash(row['tags'])]
+ end
+ points
end
-
- def coord2long(a,masterscale,baselong) #:doc:
- a/masterscale+baselong
- end
-
- def y2lat(a)
- 180/Math::PI * (2*Math.atan(Math.exp(a*Math::PI/180))-Math::PI/2)
+
+ def sql_get_tags_in_way(wayid)
+ tags={}
+ ActiveRecord::Base.connection.select_all("SELECT k,v FROM current_way_tags WHERE id=#{wayid.to_i}").each do |row|
+ tags[row['k']]=row['v']
+ end
+ tags
end
end
+
+# Local Variables:
+# indent-tabs-mode: t
+# tab-width: 4
+# End:
diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb
index 05dfb0133..2f040a92b 100644
--- a/app/controllers/api_controller.rb
+++ b/app/controllers/api_controller.rb
@@ -126,6 +126,14 @@ class ApiController < ApplicationController
doc = OSM::API.new.get_xml_doc
+ # add bounds
+ bounds = XML::Node.new 'bounds'
+ bounds['minlat'] = min_lat.to_s
+ bounds['minlon'] = min_lon.to_s
+ bounds['maxlat'] = max_lat.to_s
+ bounds['maxlon'] = max_lon.to_s
+ doc.root << bounds
+
# get ways
# find which ways are needed
ways = Array.new
@@ -168,15 +176,15 @@ class ApiController < ApplicationController
end
end
- relations = visible_nodes.values.collect { |node| node.containing_relations.visible }.flatten +
- way_ids.collect { |id| Way.find(id).containing_relations.visible }.flatten
+ relations = Relation.find_for_nodes(visible_nodes.keys, :conditions => "visible = 1") +
+ Relation.find_for_ways(way_ids, :conditions => "visible = 1")
# we do not normally return the "other" partners referenced by an relation,
# e.g. if we return a way A that is referenced by relation X, and there's
# another way B also referenced, that is not returned. But we do make
# an exception for cases where an relation references another *relation*;
# in that case we return that as well (but we don't go recursive here)
- relations += relations.collect { |relation| relation.containing_relations.visible }.flatten
+ relations += Relation.find_for_relations(relations.collect { |r| r.id }, :conditions => "visible = 1")
# this "uniq" may be slightly inefficient; it may be better to first collect and output
# all node-related relations, then find the *not yet covered* way-related ones etc.
diff --git a/app/controllers/application.rb b/app/controllers/application.rb
index 68359585e..1c27cb4d5 100644
--- a/app/controllers/application.rb
+++ b/app/controllers/application.rb
@@ -8,7 +8,7 @@ class ApplicationController < ActionController::Base
def authorize_web
if session[:user]
- @user = User.find(session[:user])
+ @user = User.find(session[:user], :conditions => "visible = 1")
elsif session[:token]
@user = User.authenticate(:token => session[:token])
session[:user] = @user.id
diff --git a/app/controllers/diary_entry_controller.rb b/app/controllers/diary_entry_controller.rb
index 5159f7362..b425ef4b6 100644
--- a/app/controllers/diary_entry_controller.rb
+++ b/app/controllers/diary_entry_controller.rb
@@ -2,16 +2,40 @@ class DiaryEntryController < ApplicationController
layout 'site', :except => :rss
before_filter :authorize_web
- before_filter :require_user, :only => [:new]
+ before_filter :require_user, :only => [:new, :edit]
before_filter :check_database_availability
def new
- @title = 'new diary entry'
+ @title = 'New diary entry'
+
if params[:diary_entry]
@diary_entry = DiaryEntry.new(params[:diary_entry])
@diary_entry.user = @user
+
if @diary_entry.save
redirect_to :controller => 'diary_entry', :action => 'list', :display_name => @user.display_name
+ else
+ render :action => 'edit'
+ end
+ else
+ render :action => 'edit'
+ end
+ end
+
+ def edit
+ @title= 'Edit diary entry'
+ @diary_entry = DiaryEntry.find(params[:id])
+
+ if @user != @diary_entry.user
+ redirect_to :controller => 'diary_entry', :action => 'view', :id => params[:id]
+ elsif params[:diary_entry]
+ @diary_entry.title = params[:diary_entry][:title]
+ @diary_entry.body = params[:diary_entry][:body]
+ @diary_entry.latitude = params[:diary_entry][:latitude]
+ @diary_entry.longitude = params[:diary_entry][:longitude]
+
+ if @diary_entry.save
+ redirect_to :controller => 'diary_entry', :action => 'view', :id => params[:id]
end
end
end
@@ -27,10 +51,11 @@ class DiaryEntryController < ApplicationController
render :action => 'view'
end
end
-
+
def list
if params[:display_name]
- @this_user = User.find_by_display_name(params[:display_name])
+ @this_user = User.find_by_display_name(params[:display_name], :conditions => "visible = 1")
+
if @this_user
@title = @this_user.display_name + "'s diary"
@entry_pages, @entries = paginate(:diary_entries,
@@ -39,6 +64,7 @@ class DiaryEntryController < ApplicationController
:per_page => 20)
else
@not_found_user = params[:display_name]
+
render :action => 'no_such_user', :status => :not_found
end
else
@@ -51,23 +77,37 @@ class DiaryEntryController < ApplicationController
def rss
if params[:display_name]
- user = User.find_by_display_name(params[:display_name])
- @entries = DiaryEntry.find(:all, :conditions => ['user_id = ?', user.id], :order => 'created_at DESC', :limit => 20)
- @title = "OpenStreetMap diary entries for #{user.display_name}"
- @description = "Recent OpenStreetmap diary entries from #{user.display_name}"
- @link = "http://www.openstreetmap.org/user/#{user.display_name}/diary"
+ user = User.find_by_display_name(params[:display_name], :conditions => "visible = 1")
+
+ if user
+ @entries = DiaryEntry.find(:all, :conditions => ['user_id = ?', user.id], :order => 'created_at DESC', :limit => 20)
+ @title = "OpenStreetMap diary entries for #{user.display_name}"
+ @description = "Recent OpenStreetmap diary entries from #{user.display_name}"
+ @link = "http://www.openstreetmap.org/user/#{user.display_name}/diary"
+
+ render :content_type => Mime::RSS
+ else
+ render :nothing => true, :status => :not_found
+ end
else
@entries = DiaryEntry.find(:all, :order => 'created_at DESC', :limit => 20)
@title = "OpenStreetMap diary entries"
@description = "Recent diary entries from users of OpenStreetMap"
@link = "http://www.openstreetmap.org/diary"
- end
- render :content_type => Mime::RSS
+ render :content_type => Mime::RSS
+ end
end
def view
- user = User.find_by_display_name(params[:display_name])
- @entry = DiaryEntry.find(:first, :conditions => ['user_id = ? AND id = ?', user.id, params[:id]])
+ user = User.find_by_display_name(params[:display_name], :conditions => "visible = 1")
+
+ if user
+ @entry = DiaryEntry.find(:first, :conditions => ['user_id = ? AND id = ?', user.id, params[:id]])
+ else
+ @not_found_user = params[:display_name]
+
+ render :action => 'no_such_user', :status => :not_found
+ end
end
end
diff --git a/app/controllers/swf_controller.rb b/app/controllers/swf_controller.rb
index 54f8382ea..a96e71d05 100644
--- a/app/controllers/swf_controller.rb
+++ b/app/controllers/swf_controller.rb
@@ -117,8 +117,8 @@ class SwfController < ApplicationController
def startShape
s =0.chr # No fill styles
s+=2.chr # Two line styles
- s+=packUI16(5) + 0.chr + 255.chr + 255.chr # Width 5, RGB #00FFFF
- s+=packUI16(5) + 255.chr + 0.chr + 255.chr # Width 5, RGB #FF00FF
+ s+=packUI16(0) + 0.chr + 255.chr + 255.chr # Width 5, RGB #00FFFF
+ s+=packUI16(0) + 255.chr + 0.chr + 255.chr # Width 5, RGB #FF00FF
s+=34.chr # 2 fill, 2 line index bits
s
end
diff --git a/app/controllers/trace_controller.rb b/app/controllers/trace_controller.rb
index 0467e66ba..899df05df 100644
--- a/app/controllers/trace_controller.rb
+++ b/app/controllers/trace_controller.rb
@@ -12,13 +12,13 @@ class TraceController < ApplicationController
# from display name, pick up user id if one user's traces only
display_name = params[:display_name]
if target_user.nil? and !display_name.blank?
- target_user = User.find(:first, :conditions => [ "display_name = ?", display_name])
+ target_user = User.find(:first, :conditions => [ "visible = 1 and display_name = ?", display_name])
end
# set title
if target_user.nil?
@title = "Public GPS traces"
- elsif @user and @user.id == target_user.id
+ elsif @user and @user == target_user
@title = "Your GPS traces"
else
@title = "Public GPS traces from #{target_user.display_name}"
@@ -38,7 +38,7 @@ class TraceController < ApplicationController
conditions = ["gpx_files.public = 1"] #2
end
else
- if @user and @user.id == target_user.id
+ if @user and @user == target_user
conditions = ["gpx_files.user_id = ?", @user.id] #3 (check vs user id, so no join + can't pick up non-public traces by changing name)
else
conditions = ["gpx_files.public = 1 AND gpx_files.user_id = ?", target_user.id] #4
@@ -88,7 +88,7 @@ class TraceController < ApplicationController
@trace = Trace.find(params[:id])
if @trace and @trace.visible? and
- (@trace.public? or @trace.user.id == @user.id)
+ (@trace.public? or @trace.user == @user)
@title = "Viewing trace #{@trace.name}"
else
flash[:notice] = "Trace not found!"
diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index 5d26708fe..df2a799c3 100644
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -2,8 +2,8 @@ class UserController < ApplicationController
layout 'site'
before_filter :authorize, :only => [:api_details, :api_gpx_files]
- before_filter :authorize_web, :only => [:account, :go_public, :view, :diary, :make_friend, :remove_friend, :upload_image]
- before_filter :require_user, :only => [:set_home, :account, :go_public, :make_friend, :remove_friend, :upload_image]
+ before_filter :authorize_web, :except => [:api_details, :api_gpx_files]
+ before_filter :require_user, :only => [:set_home, :account, :go_public, :make_friend, :remove_friend, :upload_image, :delete_image]
before_filter :check_database_availability, :except => [:api_details, :api_gpx_files]
before_filter :check_read_availability, :only => [:api_details, :api_gpx_files]
@@ -13,12 +13,13 @@ class UserController < ApplicationController
@title = 'create account'
@user = User.new(params[:user])
+ @user.visible = true
@user.data_public = true
-
+ @user.description = "" if @user.description.nil?
+
if @user.save
- token = @user.tokens.create
flash[:notice] = "User was successfully created. Check your email for a confirmation note, and you\'ll be mapping in no time :-)
Please note that you won't be able to login until you've received and confirmed your email address."
- Notifier::deliver_signup_confirm(@user, token)
+ Notifier.deliver_signup_confirm(@user, @user.tokens.create)
redirect_to :action => 'login'
else
render :action => 'new'
@@ -28,21 +29,28 @@ class UserController < ApplicationController
def account
@title = 'edit account'
if params[:user] and params[:user][:display_name] and params[:user][:description]
- home_lat = params[:user][:home_lat]
- home_lon = params[:user][:home_lon]
+ if params[:user][:email] != @user.email
+ @user.new_email = params[:user][:email]
+ end
@user.display_name = params[:user][:display_name]
+
if params[:user][:pass_crypt].length > 0 or params[:user][:pass_crypt_confirmation].length > 0
@user.pass_crypt = params[:user][:pass_crypt]
@user.pass_crypt_confirmation = params[:user][:pass_crypt_confirmation]
end
+
@user.description = params[:user][:description]
- @user.home_lat = home_lat
- @user.home_lon = home_lon
+ @user.home_lat = params[:user][:home_lat]
+ @user.home_lon = params[:user][:home_lon]
+
if @user.save
- flash[:notice] = "User information updated successfully."
- else
- flash.delete(:notice)
+ if params[:user][:email] == @user.new_email
+ @notice = "User information updated successfully. Check your email for a note to confirm your new email address."
+ Notifier.deliver_email_confirm(@user, @user.tokens.create)
+ else
+ @notice = "User information updated successfully."
+ end
end
end
end
@@ -68,16 +76,15 @@ class UserController < ApplicationController
def lost_password
@title = 'lost password'
if params[:user] and params[:user][:email]
- user = User.find_by_email(params[:user][:email])
+ user = User.find_by_email(params[:user][:email], :conditions => "visible = 1")
+
if user
token = user.tokens.create
- Notifier::deliver_lost_password(user, token)
- flash[:notice] = "Sorry you lost it :-( but an email is on its way so you can reset it soon."
+ Notifier.deliver_lost_password(user, token)
+ @notice = "Sorry you lost it :-( but an email is on its way so you can reset it soon."
else
- flash[:notice] = "Couldn't find that email address, sorry."
+ @notice = "Couldn't find that email address, sorry."
end
- else
- render :action => 'lost_password'
end
end
@@ -91,14 +98,16 @@ class UserController < ApplicationController
user.pass_crypt = pass
user.pass_crypt_confirmation = pass
user.active = true
+ user.email_valid = true
user.save!
token.destroy
- Notifier::deliver_reset_password(user, pass)
+ Notifier.deliver_reset_password(user, pass)
flash[:notice] = "Your password has been changed and is on its way to your mailbox :-)"
else
flash[:notice] = "Didn't find that token, check the URL maybe?"
end
end
+
redirect_to :action => 'login'
end
@@ -121,9 +130,9 @@ class UserController < ApplicationController
end
return
elsif User.authenticate(:username => email_or_display_name, :password => pass, :inactive => true)
- flash[:notice] = "Sorry, your account is not active yet.
Please click on the link in the account confirmation email to activate your account."
+ @notice = "Sorry, your account is not active yet.
Please click on the link in the account confirmation email to activate your account."
else
- flash[:notice] = "Sorry, couldn't log in with those details."
+ @notice = "Sorry, couldn't log in with those details."
end
end
end
@@ -150,13 +159,34 @@ class UserController < ApplicationController
if token and !token.user.active?
@user = token.user
@user.active = true
+ @user.email_valid = true
@user.save!
token.destroy
flash[:notice] = 'Confirmed your account, thanks for signing up!'
session[:user] = @user.id
redirect_to :action => 'account', :display_name => @user.display_name
else
- flash[:notice] = 'Something went wrong confirming that user.'
+ @notice = 'Something went wrong confirming that user.'
+ end
+ end
+ end
+
+ def confirm_email
+ if params[:confirm_action]
+ token = UserToken.find_by_token(params[:confirm_string])
+ if token and token.user.new_email?
+ @user = token.user
+ @user.email = @user.new_email
+ @user.new_email = nil
+ @user.active = true
+ @user.email_valid = true
+ @user.save!
+ token.destroy
+ flash[:notice] = 'Confirmed your email address, thanks for signing up!'
+ session[:user] = @user.id
+ redirect_to :action => 'account', :display_name => @user.display_name
+ else
+ @notice = 'Something went wrong confirming that email address.'
end
end
end
@@ -167,6 +197,12 @@ class UserController < ApplicationController
redirect_to :controller => 'user', :action => 'view', :display_name => @user.display_name
end
+ def delete_image
+ @user.image = nil
+ @user.save!
+ redirect_to :controller => 'user', :action => 'view', :display_name => @user.display_name
+ end
+
def api_details
render :text => @user.to_xml.to_s, :content_type => "text/xml"
end
@@ -180,7 +216,7 @@ class UserController < ApplicationController
end
def view
- @this_user = User.find_by_display_name(params[:display_name])
+ @this_user = User.find_by_display_name(params[:display_name], :conditions => "visible = 1")
if @this_user
@title = @this_user.display_name
@@ -193,20 +229,21 @@ class UserController < ApplicationController
def make_friend
if params[:display_name]
name = params[:display_name]
- new_friend = User.find_by_display_name(name)
+ new_friend = User.find_by_display_name(name, :conditions => "visible = 1")
friend = Friend.new
friend.user_id = @user.id
friend.friend_user_id = new_friend.id
unless @user.is_friends_with?(new_friend)
if friend.save
flash[:notice] = "#{name} is now your friend."
- Notifier::deliver_friend_notification(friend)
+ Notifier.deliver_friend_notification(friend)
else
friend.add_error("Sorry, failed to add #{name} as a friend.")
end
else
flash[:notice] = "You are already friends with #{name}."
end
+
redirect_to :controller => 'user', :action => 'view'
end
end
@@ -214,16 +251,15 @@ class UserController < ApplicationController
def remove_friend
if params[:display_name]
name = params[:display_name]
- friend = User.find_by_display_name(name)
+ friend = User.find_by_display_name(name, :conditions => "visible = 1")
if @user.is_friends_with?(friend)
Friend.delete_all "user_id = #{@user.id} AND friend_user_id = #{friend.id}"
flash[:notice] = "#{friend.display_name} was removed from your friends."
else
- flash[:notice] = "#{friend.display_name} was not already one of your friends."
+ flash[:notice] = "#{friend.display_name} is not one of your friends."
end
+
redirect_to :controller => 'user', :action => 'view'
end
end
-
end
-
diff --git a/app/models/friend.rb b/app/models/friend.rb
index 242b74251..d740a711c 100644
--- a/app/models/friend.rb
+++ b/app/models/friend.rb
@@ -1,4 +1,4 @@
class Friend < ActiveRecord::Base
- belongs_to :user
-
+ belongs_to :befriender, :class_name => "User", :foreign_key => :user_id
+ belongs_to :befriendee, :class_name => "User", :foreign_key => :friend_user_id
end
diff --git a/app/models/node.rb b/app/models/node.rb
index c8770922d..677023179 100644
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -19,6 +19,9 @@ class Node < ActiveRecord::Base
has_many :node_tags, :foreign_key => :id
+ has_many :old_way_nodes
+ has_many :ways_via_history, :class_name=> "Way", :through => :old_way_nodes, :source => :way
+
has_many :containing_relation_members, :class_name => "RelationMember", :as => :member
has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation, :extend => ObjectFinder
diff --git a/app/models/notifier.rb b/app/models/notifier.rb
index 84d097341..3cc0f4cab 100644
--- a/app/models/notifier.rb
+++ b/app/models/notifier.rb
@@ -1,4 +1,3 @@
-
class Notifier < ActionMailer::Base
def signup_confirm(user, token)
recipients user.email
@@ -10,6 +9,17 @@ class Notifier < ActionMailer::Base
:confirm_string => token.token)
end
+ def email_confirm(user, token)
+ recipients user.new_email
+ from "webmaster@openstreetmap.org"
+ subject "[OpenStreetMap] Confirm your email address"
+ headers "Auto-Submitted" => "auto-generated"
+ body :address => user.new_email,
+ :url => url_for(:host => SERVER_URL,
+ :controller => "user", :action => "confirm_email",
+ :confirm_string => token.token)
+ end
+
def lost_password(user, token)
recipients user.email
from "webmaster@openstreetmap.org"
@@ -29,7 +39,7 @@ class Notifier < ActionMailer::Base
end
def gpx_success(trace, possible_points)
- recipients trace.user.email
+ recipients trace.user.email if trace.user.email_valid
from "webmaster@openstreetmap.org"
subject "[OpenStreetMap] GPX Import success"
headers "Auto-Submitted" => "auto-generated"
@@ -41,7 +51,7 @@ class Notifier < ActionMailer::Base
end
def gpx_failure(trace, error)
- recipients trace.user.email
+ recipients trace.user.email if trace.user.email_valid
from "webmaster@openstreetmap.org"
subject "[OpenStreetMap] GPX Import failure"
headers "Auto-Submitted" => "auto-generated"
@@ -52,7 +62,7 @@ class Notifier < ActionMailer::Base
end
def message_notification(message)
- recipients message.recipient.email
+ recipients message.recipient.email if message.recipient.email_valid
from "webmaster@openstreetmap.org"
subject "[OpenStreetMap] #{message.sender.display_name} sent you a new message"
headers "Auto-Submitted" => "auto-generated"
@@ -69,7 +79,7 @@ class Notifier < ActionMailer::Base
end
def diary_comment_notification(comment)
- recipients comment.diary_entry.user.email
+ recipients comment.diary_entry.user.email if comment.diary_entry.user.email_valid
from "webmaster@openstreetmap.org"
subject "[OpenStreetMap] #{comment.user.display_name} commented on your diary entry"
headers "Auto-Submitted" => "auto-generated"
@@ -100,7 +110,7 @@ class Notifier < ActionMailer::Base
befriender = User.find_by_id(friend.user_id)
befriendee = User.find_by_id(friend.friend_user_id)
- recipients befriendee.email
+ recipients befriendee.email if befriendee.email_valid
from "webmaster@openstreetmap.org"
subject "[OpenStreetMap] #{befriender.display_name} added you as a friend"
headers "Auto-Submitted" => "auto-generated"
diff --git a/app/models/old_way.rb b/app/models/old_way.rb
index edf66aac3..3c88c4673 100644
--- a/app/models/old_way.rb
+++ b/app/models/old_way.rb
@@ -112,6 +112,35 @@ class OldWay < ActiveRecord::Base
return el1
end
+ # Read full version of old way
+ # For get_nodes_undelete, uses same nodes, even if they've moved since
+ # For get_nodes_revert, allocates new ids
+ # Currently returns Potlatch-style array
+
+ def get_nodes_undelete
+ points = []
+ self.nds.each do |n|
+ node=Node.find(n)
+ points << [node.lon, node.lat, n, node.visible ? 1 : 0, node.tags_as_hash]
+ end
+ points
+ end
+
+ def get_nodes_revert
+ points=[]
+ self.nds.each do |n|
+ oldnode=OldNode.find(:first, :conditions=>['id=? AND timestamp<=?',n,self.timestamp], :order=>"timestamp DESC")
+ curnode=Node.find(n)
+ id=n; v=curnode.visible ? 1 : 0
+ if oldnode.lat!=curnode.lat or oldnode.lon!=curnode.lon or oldnode.tags!=curnode.tags then
+ # node has changed: if it's in other ways, give it a new id
+ if curnode.ways-[self.id] then id=-1; v=nil end
+ end
+ points << [oldnode.lon, oldnode.lat, id, v, oldnode.tags_as_hash]
+ end
+ points
+ end
+
# Temporary method to match interface to nodes
def tags_as_hash
return self.tags
diff --git a/app/models/old_way_node.rb b/app/models/old_way_node.rb
index 85a6f3c1c..7420b5cfc 100644
--- a/app/models/old_way_node.rb
+++ b/app/models/old_way_node.rb
@@ -2,4 +2,6 @@ class OldWayNode < ActiveRecord::Base
set_table_name 'way_nodes'
set_primary_keys :id, :version, :sequence_id
+
+ belongs_to :way, :foreign_key=> :id
end
diff --git a/app/models/relation.rb b/app/models/relation.rb
index eb3b06a13..e46da5ade 100644
--- a/app/models/relation.rb
+++ b/app/models/relation.rb
@@ -112,6 +112,36 @@ class Relation < ActiveRecord::Base
return el1
end
+ def self.find_for_nodes(ids, options = {})
+ if ids.empty?
+ return []
+ else
+ self.with_scope(:find => { :joins => "INNER JOIN current_relation_members ON current_relation_members.id = current_relations.id", :conditions => "current_relation_members.member_type = 'node' AND current_relation_members.member_id IN (#{ids.join(',')})" }) do
+ return self.find(:all, options)
+ end
+ end
+ end
+
+ def self.find_for_ways(ids, options = {})
+ if ids.empty?
+ return []
+ else
+ self.with_scope(:find => { :joins => "INNER JOIN current_relation_members ON current_relation_members.id = current_relations.id", :conditions => "current_relation_members.member_type = 'way' AND current_relation_members.member_id IN (#{ids.join(',')})" }) do
+ return self.find(:all, options)
+ end
+ end
+ end
+
+ def self.find_for_relations(ids, options = {})
+ if ids.empty?
+ return []
+ else
+ self.with_scope(:find => { :joins => "INNER JOIN current_relation_members ON current_relation_members.id = current_relations.id", :conditions => "current_relation_members.member_type = 'relation' AND current_relation_members.member_id IN (#{ids.join(',')})" }) do
+ return self.find(:all, options)
+ end
+ end
+ end
+
# FIXME is this really needed?
def members
unless @members
diff --git a/app/models/trace.rb b/app/models/trace.rb
index d28c2c6f4..10e867bad 100644
--- a/app/models/trace.rb
+++ b/app/models/trace.rb
@@ -58,18 +58,16 @@ class Trace < ActiveRecord::Base
data
end
- # FIXME change to permanent filestore area
def large_picture_name
- "/home/osm/icons/#{id}.gif"
+ "#{GPX_IMAGE_DIR}/#{id}.gif"
end
- # FIXME change to permanent filestore area
def icon_picture_name
- "/home/osm/icons/#{id}_icon.gif"
+ "#{GPX_IMAGE_DIR}/#{id}_icon.gif"
end
def trace_name
- "/home/osm/gpx/#{id}.gpx"
+ "#{GPX_TRACE_DIR}/#{id}.gpx"
end
def mime_type
@@ -158,7 +156,7 @@ class Trace < ActiveRecord::Base
elsif bzipped
system("bunzip2 -c #{trace_name} > #{tmpfile.path}")
elsif zipped
- system("unzip -p #{trace_name} > #{tmpfile.path}")
+ system("unzip -p #{trace_name} -x '__MACOSX/*' > #{tmpfile.path}")
end
tmpfile.unlink
@@ -174,7 +172,7 @@ class Trace < ActiveRecord::Base
def import
logger.info("GPX Import importing #{name} (#{id}) from #{user.email}")
- gpx = OSM::GPXImporter.new(self.xml_file)
+ gpx = GPX::File.new(self.xml_file)
f_lat = 0
f_lon = 0
@@ -189,18 +187,18 @@ class Trace < ActiveRecord::Base
gpx.points do |point|
if first
- f_lat = point['latitude']
- f_lon = point['longitude']
+ f_lat = point.latitude
+ f_lon = point.longitude
first = false
end
tp = Tracepoint.new
- tp.lat = point['latitude'].to_f
- tp.lon = point['longitude'].to_f
- tp.altitude = point['altitude'].to_f
- tp.timestamp = point['timestamp']
+ tp.lat = point.latitude
+ tp.lon = point.longitude
+ tp.altitude = point.altitude
+ tp.timestamp = point.timestamp
tp.gpx_id = id
- tp.trackid = point['segment'].to_i
+ tp.trackid = point.segment
tp.save!
end
@@ -217,8 +215,8 @@ class Trace < ActiveRecord::Base
self.latitude = f_lat
self.longitude = f_lon
- self.large_picture = gpx.get_picture(min_lat, min_lon, max_lat, max_lon, gpx.actual_points)
- self.icon_picture = gpx.get_icon(min_lat, min_lon, max_lat, max_lon)
+ self.large_picture = gpx.picture(min_lat, min_lon, max_lat, max_lon, gpx.actual_points)
+ self.icon_picture = gpx.icon(min_lat, min_lon, max_lat, max_lon)
self.size = gpx.actual_points
self.inserted = true
self.save!
diff --git a/app/models/user.rb b/app/models/user.rb
index 61c76898a..9b5bfd595 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -6,7 +6,7 @@ class User < ActiveRecord::Base
has_many :messages, :foreign_key => :to_user_id, :order => 'sent_on DESC'
has_many :new_messages, :class_name => "Message", :foreign_key => :to_user_id, :conditions => "message_read = 0", :order => 'sent_on DESC'
has_many :sent_messages, :class_name => "Message", :foreign_key => :from_user_id, :order => 'sent_on DESC'
- has_many :friends
+ has_many :friends, :include => :befriendee, :conditions => "users.visible = 1"
has_many :tokens, :class_name => "UserToken"
has_many :preferences, :class_name => "UserPreference"
@@ -48,7 +48,7 @@ class User < ActiveRecord::Base
end
if user
- user = nil unless user.active? or options[:inactive]
+ user = nil unless user.visible? and (user.active? or options[:inactive])
end
token.update_attribute(:expiry, 1.week.from_now) if token and user
@@ -80,7 +80,7 @@ class User < ActiveRecord::Base
if self.home_lon and self.home_lat
gc = OSM::GreatCircle.new(self.home_lat, self.home_lon)
bounds = gc.bounds(radius)
- nearby = User.find(:all, :conditions => "home_lat between #{bounds[:minlat]} and #{bounds[:maxlat]} and home_lon between #{bounds[:minlon]} and #{bounds[:maxlon]} and data_public = 1 and id != #{self.id}")
+ nearby = User.find(:all, :conditions => "visible = 1 and home_lat between #{bounds[:minlat]} and #{bounds[:maxlat]} and home_lon between #{bounds[:minlon]} and #{bounds[:maxlon]} and data_public = 1 and id != #{self.id}")
nearby.delete_if { |u| gc.distance(u.home_lat, u.home_lon) > radius }
nearby.sort! { |u1,u2| gc.distance(u1.home_lat, u1.home_lon) <=> gc.distance(u2.home_lat, u2.home_lon) }
else
diff --git a/app/models/way.rb b/app/models/way.rb
index 34afc6585..3bc8bcebe 100644
--- a/app/models/way.rb
+++ b/app/models/way.rb
@@ -252,17 +252,8 @@ class Way < ActiveRecord::Base
# FIXME: merge the potlatch code to delete the relations
def delete_with_relations_and_nodes_and_history(user)
-
- node_ids = self.nodes.collect {|node| node.id }
- node_ids_not_to_delete = []
- way_nodes = WayNode.find(:all, :conditions => "node_id in (#{node_ids.join(',')}) and id != #{self.id}")
-
- node_ids_not_to_delete = way_nodes.collect {|way_node| way_node.node_id}
-
- node_ids_to_delete = node_ids - node_ids_not_to_delete
-
# delete the nodes not used by other ways
- node_ids_to_delete.each do |node_id|
+ self.unshared_node_ids.each do |node_id|
n = Node.find(node_id)
n.user_id = user.id
n.visible = false
@@ -272,7 +263,18 @@ class Way < ActiveRecord::Base
self.user_id = user.id
self.delete_with_history(user)
+ end
+ # Find nodes that belong to this way only
+ def unshared_node_ids
+ node_ids = self.nodes.collect { |node| node.id }
+
+ unless node_ids.empty?
+ way_nodes = WayNode.find(:all, :conditions => "node_id in (#{node_ids.join(',')}) and id != #{self.id}")
+ node_ids = node_ids - way_nodes.collect { |way_node| way_node.node_id }
+ end
+
+ return node_ids
end
# Temporary method to match interface to nodes
diff --git a/app/views/diary_entry/_diary_entry.rhtml b/app/views/diary_entry/_diary_entry.rhtml
index 372ec35f7..fe73155ac 100644
--- a/app/views/diary_entry/_diary_entry.rhtml
+++ b/app/views/diary_entry/_diary_entry.rhtml
@@ -3,13 +3,17 @@
<% if diary_entry.latitude and diary_entry.longitude %>
Coordinates:
Hi,
+ +Someone (hopefully you) would like to change their email address over at + <%= SERVER_URL %> to <%= @address %>.
+ +If this is you, please click the link below to confirm the change.
+ + diff --git a/app/views/notifier/email_confirm.text.plain.rhtml b/app/views/notifier/email_confirm.text.plain.rhtml new file mode 100644 index 000000000..28589dfbc --- /dev/null +++ b/app/views/notifier/email_confirm.text.plain.rhtml @@ -0,0 +1,8 @@ +Hi, + +Someone (hopefully you) would like to change their email address over at +<%= SERVER_URL %> to <%= @address %>. + +If this is you, please click the link below to confirm the change. + +<%= @url %> diff --git a/app/views/notifier/message_notification.rhtml b/app/views/notifier/message_notification.rhtml index 55e464e15..7192e3884 100644 --- a/app/views/notifier/message_notification.rhtml +++ b/app/views/notifier/message_notification.rhtml @@ -4,7 +4,7 @@ * Use the OpenStreetMap web site to reply. * * * * Bitte antworten Sie nicht auf diese E-Mail. * -* Verwenden Sie die OpenStreetMap Website zum antworten. * +* Verwenden Sie die OpenStreetMap Website zum Antworten. * * * * Por favor, no responda a este mensaje. * * Utilice el OpenStreetMap sitio web para responder. * @@ -31,7 +31,7 @@ and you can reply at <%= @replyurl %> * Use the OpenStreetMap web site to reply. * * * * Bitte antworten Sie nicht auf diese E-Mail. * -* Verwenden Sie die OpenStreetMap Website zum antworten. * +* Verwenden Sie die OpenStreetMap Website zum Antworten. * * * * Por favor, no responda a este mensaje. * * Utilice el OpenStreetMap sitio web para responder. * diff --git a/app/views/site/edit.rhtml b/app/views/site/edit.rhtml index a3896bc48..7f542bb60 100644 --- a/app/views/site/edit.rhtml +++ b/app/views/site/edit.rhtml @@ -48,7 +48,7 @@ <%= javascript_include_tag 'swfobject.js' %> " unless @header_red - @header_red = true - @output.puts " " unless @example_group_red - @example_group_red = true - move_progress - @output.puts "#{format_backtrace(failure.exception.backtrace)}
#{@snippet_extractor.snippet(failure.exception)}
"
- end
-
- def move_progress
- @output.puts " "
- @output.flush
- end
-
- def percent_done
- result = 100.0
- if @example_count != 0
- result = ((current_example_number).to_f / @example_count.to_f * 1000).to_i / 10.0
- end
- result
- end
-
- def dump_failure(counter, failure)
- end
-
- def dump_summary(duration, example_count, failure_count, pending_count)
- if dry_run?
- totals = "This was a dry-run"
- else
- totals = "#{example_count} example#{'s' unless example_count == 1}, #{failure_count} failure#{'s' unless failure_count == 1}"
- totals << ", #{pending_count} pending" if pending_count > 0
- end
- @output.puts ""
- @output.puts ""
- @output.puts "