diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 71d949dae..03c2e3d6f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -75,7 +75,7 @@ Metrics/CyclomaticComplexity: # Offense count: 2535 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: - Max: 694 + Max: 878 # Offense count: 628 # Configuration parameters: CountComments. diff --git a/app/helpers/user_roles_helper.rb b/app/helpers/user_roles_helper.rb index 690cccdca..2d3d49d77 100644 --- a/app/helpers/user_roles_helper.rb +++ b/app/helpers/user_roles_helper.rb @@ -6,26 +6,28 @@ module UserRolesHelper def role_icon(user, role) if @user && @user.administrator? if user.has_role?(role) - image = "roles/#{role}.png" + image = "roles/#{role}" alt = t("user.view.role.revoke.#{role}") title = t("user.view.role.revoke.#{role}") url = revoke_role_path(:display_name => user.display_name, :role => role) confirm = t("user_role.revoke.are_you_sure", :name => user.display_name, :role => role) else - image = "roles/blank_#{role}.png" + image = "roles/blank_#{role}" alt = t("user.view.role.grant.#{role}") title = t("user.view.role.grant.#{role}") url = grant_role_path(:display_name => user.display_name, :role => role) confirm = t("user_role.grant.are_you_sure", :name => user.display_name, :role => role) end elsif user.has_role?(role) - image = "roles/#{role}.png" + image = "roles/#{role}" alt = t("user.view.role.#{role}") title = t("user.view.role.#{role}") end if image - icon = image_tag(image, :size => "20x20", :border => 0, :alt => alt, :title => title) + svg_icon = tag("source", :srcset => image_path("#{image}.svg"), :type => "image/svg+xml") + png_icon = image_tag("#{image}.png", :size => "20x20", :border => 0, :alt => alt, :title => title) + icon = content_tag("picture", svg_icon + png_icon) icon = link_to(icon, url, :method => :post, :confirm => confirm) if url end diff --git a/app/views/layouts/_flash.html.erb b/app/views/layouts/_flash.html.erb index e72185101..2ba8ee95d 100644 --- a/app/views/layouts/_flash.html.erb +++ b/app/views/layouts/_flash.html.erb @@ -1,20 +1,29 @@ <% if flash[:error] %>