diff --git a/app/controllers/message_controller.rb b/app/controllers/message_controller.rb index fc7a9101b..d2fa9bd5f 100644 --- a/app/controllers/message_controller.rb +++ b/app/controllers/message_controller.rb @@ -7,11 +7,13 @@ class MessageController < ApplicationController # Allow the user to write a new message to another user. This action also # deals with the sending of that message to the other user when the user # clicks send. + # The user_id param is the id of the user that the message is being sent to. def new @title = 'send message' + @to_user = User.find(params[:user_id]) if params[:message] @message = Message.new(params[:message]) - @message.to_user_id = params[:user_id] + @message.to_user_id = @to_user.id @message.from_user_id = @user.id @message.sent_on = Time.now @@ -23,6 +25,8 @@ class MessageController < ApplicationController else @title = params[:title] end + rescue ActiveRecord::RecordNotFound + render :action => 'no_such_user', :status => :not_found end # Allow the user to reply to another message. @@ -33,7 +37,7 @@ class MessageController < ApplicationController @user_id = message.from_user_id render :action => 'new' rescue ActiveRecord::RecordNotFound - render :nothing => true, :status => :not_found + render :action => 'no_such_user', :status => :not_found end # Show a message @@ -43,7 +47,7 @@ class MessageController < ApplicationController @message.message_read = true if @message.to_user_id == @user.id @message.save rescue ActiveRecord::RecordNotFound - render :nothing => true, :status => :not_found + render :action => 'no_such_user', :status => :not_found end # Display the list of messages that have been sent to the user. @@ -82,5 +86,7 @@ class MessageController < ApplicationController redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name end end + rescue ActiveRecord::RecordNotFound + render :action => 'no_such_user', :status => :not_found end end diff --git a/app/views/message/_message_summary.rhtml b/app/views/message/_message_summary.rhtml index 6d45d33dd..263e30e64 100644 --- a/app/views/message/_message_summary.rhtml +++ b/app/views/message/_message_summary.rhtml @@ -1,9 +1,10 @@ -<% this_colour = cycle('lightgrey', 'white') # can only call once for some dumb reason %> +<% this_colour = cycle('lightgrey', 'white') # can only call once for some dumb reason +%>
Writing a new message to <%= h(params[:display_name]) %>
@@ -10,7 +7,7 @@ <%= error_messages_for 'message' %> -<% form_for :message, :url => { :action => "new", :user_id => user_id } do |f| %> +<% form_for :message, :url => { :action => "new", :user_id => @to_user.id } do |f| %>Subject |
---|