From f0f15856615600de2f8e3ecf0d10b81a531c13be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20P=C3=A9pin?= Date: Tue, 23 May 2017 05:41:57 +0100 Subject: [PATCH] Registration: remove success var, fix message `member.profile` was not up-to-date where we used to send the success message => move it to the place where the success var is set tu `True` and remove the success var was which becomes irrelevant. --- gestioncof/views.py | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/gestioncof/views.py b/gestioncof/views.py index 227a3e0a..6a728ea6 100644 --- a/gestioncof/views.py +++ b/gestioncof/views.py @@ -402,7 +402,6 @@ def registration(request): request_dict = request.POST.copy() member = None login_clipper = None - success = False # ----- # Remplissage des formulaires @@ -492,16 +491,18 @@ def registration(request): for club in clubs_form.cleaned_data['clubs']: club.membres.add(member) club.save() - success = True - # Messages - if success: - msg = ("L'inscription de {:s} ({:s}) a été " - "enregistrée avec succès." - .format(member.get_full_name(), member.email)) - if member.profile.is_cof: - msg += "\nIl est désormais membre du COF n°{:d} !".format( - member.profile.id) - messages.success(request, msg, extra_tags='safe') + + # --- + # Success + # --- + + msg = ("L'inscription de {:s} ({:s}) a été " + "enregistrée avec succès." + .format(member.get_full_name(), member.email)) + if profile.is_cof: + msg += "\nIl est désormais membre du COF n°{:d} !".format( + member.profile.id) + messages.success(request, msg, extra_tags='safe') return render(request, "gestioncof/registration_post.html", {"user_form": user_form, "profile_form": profile_form,