From a9d1a6aae928d6839b5becce73e39d2d9658fde1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Fri, 24 Mar 2017 21:24:06 +0100
Subject: [PATCH 1/8] clean array iteration

---
 kfet/static/kfet/js/kfet.api.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kfet/static/kfet/js/kfet.api.js b/kfet/static/kfet/js/kfet.api.js
index 7836fcb9..cc499c57 100644
--- a/kfet/static/kfet/js/kfet.api.js
+++ b/kfet/static/kfet/js/kfet.api.js
@@ -525,15 +525,15 @@ class Formatter {
         var prefix_prop = options.prefix_prop !== undefined ? options.prefix_prop : '.';
         var prefix_attr = options.prefix_attr !== undefined ? options.prefix_attr : '';
 
-        for (var i in props) {
-            var selector = prefix_prop + props[i];
-            var html = options.empty_props ? '' : this.get_prop(object, props[i]);
+        for (let prop of props) {
+            var selector = prefix_prop + prop;
+            var html = options.empty_props ? '' : this.get_prop(object, prop);
             $container.find( selector ).html( html );
         }
 
-        for (var i in attrs) {
-            var name = prefix_attr + attrs[i];
-            var value = options.empty_attrs ? '' : this.get_attr(object, attrs[i]);
+        for (let attr of attrs) {
+            var name = prefix_attr + attr;
+            var value = options.empty_attrs ? '' : this.get_attr(object, attr);
             $container.attr( name, value );
         }
 

From abce961d9184e490d8b27b4a05af8aaedee2f586 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Fri, 24 Mar 2017 21:28:33 +0100
Subject: [PATCH 2/8] use django-js-reverse

---
 kfet/static/kfet/js/kpsul.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kfet/static/kfet/js/kpsul.js b/kfet/static/kfet/js/kpsul.js
index 9dd6ae19..7541e52e 100644
--- a/kfet/static/kfet/js/kpsul.js
+++ b/kfet/static/kfet/js/kpsul.js
@@ -50,7 +50,7 @@ class AccountManager {
         if (this.is_empty()) {
             var trigramme = this.selection.get();
             if (trigramme.isValidTri()) {
-                var url_base = "{% url 'kfet.account.create' %}";
+                var url_base = Urls['kfet.account.create']();
                 var url = url_base + '?trigramme=' + encodeURIComponent(trigramme);
                 buttons += '<a href="'+url+'" class="btn btn-primary" target="_blank" title="Créer ce compte"><span class="glyphicon glyphicon-plus"></span></a>';
             } else {  /* trigramme input is empty or invalid */
@@ -187,7 +187,7 @@ class AccountSearch {
         var that = this;
 
         this._$input.yourlabsAutocomplete({
-            url: '{% url "kfet.account.search.autocomplete" %}',
+            url: Urls['kfet.account.search.autocomplete'],
             minimumCharacters: 2,
             id: 'search_autocomplete',
             choiceSelector: '.choice',

From 2e3bd5bd7a077868f1be749a369429a6708fbdc6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Fri, 24 Mar 2017 21:41:34 +0100
Subject: [PATCH 3/8] fix search box

---
 kfet/static/kfet/js/kpsul.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kfet/static/kfet/js/kpsul.js b/kfet/static/kfet/js/kpsul.js
index 7541e52e..65b9006c 100644
--- a/kfet/static/kfet/js/kpsul.js
+++ b/kfet/static/kfet/js/kpsul.js
@@ -187,13 +187,14 @@ class AccountSearch {
         var that = this;
 
         this._$input.yourlabsAutocomplete({
-            url: Urls['kfet.account.search.autocomplete'],
+            url: Urls['kfet.account.search.autocomplete'](),
             minimumCharacters: 2,
             id: 'search_autocomplete',
             choiceSelector: '.choice',
             placeholder: "Chercher un utilisateur K-Fêt",
             container: that._$results_container,
             box: that._$results_container,
+            fixPosition: function() {},
         });
 
         return this;

From 0d02d47d33d1b17d7895503bb90e3c64540433ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Fri, 24 Mar 2017 22:05:04 +0100
Subject: [PATCH 4/8] move utils functions

---
 kfet/static/kfet/js/kfet.js    | 15 +++++++++++++++
 kfet/templates/kfet/kpsul.html | 15 ---------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/kfet/static/kfet/js/kfet.js b/kfet/static/kfet/js/kfet.js
index 455d2d95..0fb5c0e1 100644
--- a/kfet/static/kfet/js/kfet.js
+++ b/kfet/static/kfet/js/kfet.js
@@ -25,6 +25,21 @@ String.prototype.isValidTri = function() {
 }
 
 
+function intCheck(v) {
+    return Number.parseInt(v);
+}
+
+function floatCheck(v) {
+    if (typeof v === 'number')
+        return v;
+    return Number.parseFloat(v);
+}
+
+function booleanCheck(v) {
+    return v == true;
+}
+
+
 $(document).ready(function() {
     $(window).scroll(function() {
         if ($(window).width() >= 768 && $(this).scrollTop() > 72.6) {
diff --git a/kfet/templates/kfet/kpsul.html b/kfet/templates/kfet/kpsul.html
index 7fc56605..15f83076 100644
--- a/kfet/templates/kfet/kpsul.html
+++ b/kfet/templates/kfet/kpsul.html
@@ -175,21 +175,6 @@
 
 <script type="text/javascript">
 
-function intCheck(v) {
-    return Number.parseInt(v);
-}
-
-function floatCheck(v) {
-    if (typeof v === 'number')
-        return v;
-    return Number.parseFloat(v);
-}
-
-function booleanCheck(v) {
-    return v == true;
-}
-
-
 $(document).ready(function() {
     'use strict';
     // -----

From ac18cbd9d9c0f2644fff48cf64f6439b9604c4f6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Fri, 24 Mar 2017 22:10:34 +0100
Subject: [PATCH 5/8] fix by on last statement

---
 kfet/views.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kfet/views.py b/kfet/views.py
index 26ad88b4..1ca29eb1 100644
--- a/kfet/views.py
+++ b/kfet/views.py
@@ -858,6 +858,7 @@ def kpsul_checkout_data(request, pk):
             last_statement,
             fields=['id', 'at', 'balance_new', 'balance_old', 'by']
         )
+        last_statement_data['by'] = str(last_statement.by)
         # ``at`` is not editable, so skipped by ``model_to_dict``
         last_statement_data['at'] = last_statement.at
         data['laststatement'] = last_statement_data

From 72970c6be7b770f2176c169a0c28afcb1e57538f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Sat, 25 Mar 2017 09:44:55 +0100
Subject: [PATCH 6/8] Fix api call on new transfers

- Use django-js-reverse
- Replace old url (deleted) with standard url
---
 kfet/templates/kfet/transfers_create.html | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/kfet/templates/kfet/transfers_create.html b/kfet/templates/kfet/transfers_create.html
index 83a09762..4728121f 100644
--- a/kfet/templates/kfet/transfers_create.html
+++ b/kfet/templates/kfet/transfers_create.html
@@ -4,6 +4,7 @@
 {% block extra_head %}
 <link rel="stylesheet" type="text/css" href="{% static 'kfet/css/transfers_form.css' %}">
 <script type="text/javascript" src="{% static 'kfet/js/js.cookie.js' %}"></script>
+<script type="text/javascript" src="{% url 'js_reverse' %}"></script>
 {% endblock %}
 
 {% block title %}Nouveaux transferts{% endblock %}
@@ -51,14 +52,12 @@
 
 <script type="text/javascript">
 $(document).ready(function () {
-    function getAccountData(trigramme, callback = function() {}) {
-        $.ajax({
-            dataType: "json",
-            url     : "{% url 'kfet.account.read.json' %}",
-            method  : "POST",
-            data    : { trigramme: trigramme },
-            success : callback,
-        });
+    function getAccountData(trigramme, callback) {
+        callback = callback || $.noop;
+        $.getJSON(Urls['kfet.account.read'](trigramme), {
+            'format': 'json',
+        })
+        .done(callback);
     }
 
     function updateAccountData(trigramme, $input) {

From 967748ded30216274d01be6ef15d25d33487e715 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Sat, 25 Mar 2017 09:58:20 +0100
Subject: [PATCH 7/8] details link to read instead of update

- It was the old behaviour.
---
 kfet/static/kfet/js/kpsul.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kfet/static/kfet/js/kpsul.js b/kfet/static/kfet/js/kpsul.js
index 65b9006c..b6c7e4a6 100644
--- a/kfet/static/kfet/js/kpsul.js
+++ b/kfet/static/kfet/js/kpsul.js
@@ -57,8 +57,8 @@ class AccountManager {
                 buttons += '<button class="btn btn-primary search" title="Rechercher"><span class="glyphicon glyphicon-search"></span></button>';
             }
         } else {  /* an account is loaded */
-            var url = Urls['kfet.account.update'](encodeURIComponent(this.account.trigramme));
-            buttons += '<a href="'+url+'" class="btn btn-primary" target="_blank" title="Modifier ce compte"><span class="glyphicon glyphicon-cog"></span></a>';
+            var url = this.account.url_object;
+            buttons += '<a href="'+url+'" class="btn btn-primary" target="_blank" title="Détails du compte"><span class="glyphicon glyphicon-cog"></span></a>';
         }
 
         this._$container.find('.buttons').html(buttons);

From 6afbcb44a1e04277e00202eeab0c9d936eeb8194 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Delobelle?= <aurelien.delobelle@gmail.com>
Date: Sat, 25 Mar 2017 10:26:45 +0100
Subject: [PATCH 8/8] delete array comprehesion

---
 kfet/static/kfet/js/kpsul.js | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/kfet/static/kfet/js/kpsul.js b/kfet/static/kfet/js/kpsul.js
index b6c7e4a6..6052ad56 100644
--- a/kfet/static/kfet/js/kpsul.js
+++ b/kfet/static/kfet/js/kpsul.js
@@ -344,11 +344,10 @@ class CheckoutSelection {
 
         this._init_events();
 
-        this.choices = [
-            for (option of this._$input.find('option'))
-                if ($(option).attr('value') != '')
-                    parseInt($(option).attr('value'))
-        ];
+        this.choices = this._$input.find('option[value!=""]').toArray()
+            .map(function(opt) {
+                return parseInt($(opt).attr('value'));
+            });
     }
 
     _init_events() {