From 9dbb04431a4c105ff79e5a7e2cc108105b5b0b10 Mon Sep 17 00:00:00 2001 From: jesopo Date: Sat, 18 May 2019 22:51:55 +0100 Subject: [PATCH 1/2] Don't send an empty CTCP SOURCE response --- src/client/mod.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/client/mod.rs b/src/client/mod.rs index 011313b..94c589e 100644 --- a/src/client/mod.rs +++ b/src/client/mod.rs @@ -550,8 +550,7 @@ impl ClientState { self.send_ctcp_internal( resp, &format!("SOURCE {}", self.config().source()), - )?; - self.send_ctcp_internal(resp, "SOURCE") + ) } else if tokens[0].eq_ignore_ascii_case("PING") && tokens.len() > 1 { self.send_ctcp_internal(resp, &format!("PING {}", tokens[1])) } else if tokens[0].eq_ignore_ascii_case("TIME") { From 379a2db9fa7a30fbffaec94430d7c665992c13ad Mon Sep 17 00:00:00 2001 From: jesopo Date: Sat, 18 May 2019 23:01:40 +0100 Subject: [PATCH 2/2] Update `source_response` test --- src/client/mod.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/client/mod.rs b/src/client/mod.rs index 94c589e..b178021 100644 --- a/src/client/mod.rs +++ b/src/client/mod.rs @@ -1298,8 +1298,7 @@ mod test { }).unwrap(); assert_eq!( &get_client_value(client)[..], - "NOTICE test :\u{001}SOURCE https://github.com/aatxe/irc\u{001}\r\n\ - NOTICE test :\u{001}SOURCE\u{001}\r\n" + "NOTICE test :\u{001}SOURCE https://github.com/aatxe/irc\u{001}\r\n" ); }