From 5893cf78da4002eaf6caa01ff27134b3368c1161 Mon Sep 17 00:00:00 2001 From: Philip Prindeville Date: Fri, 14 Apr 2023 12:37:06 -0600 Subject: [PATCH] blobmsg: Don't do at run-time what can be done at compile-time Repeatedly calling a run-time function like strlen() on an invariant value is inefficient, especially if that value can be computed once (at initialization) or better yet, computed at compile-time. Signed-off-by: Philip Prindeville --- blobmsg_json.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/blobmsg_json.c b/blobmsg_json.c index dce81e9..ec8b482 100644 --- a/blobmsg_json.c +++ b/blobmsg_json.c @@ -151,15 +151,15 @@ static bool blobmsg_puts(struct strbuf *s, const char *c, int len) static void add_separator(struct strbuf *s) { - const char *indent_chars = "\n\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t"; + const char indent_chars[] = "\n\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t"; size_t len; if (!s->indent) return; len = s->indent_level + 1; - if (len > strlen(indent_chars)) - len = strlen(indent_chars); + if (len > sizeof(indent_chars) - 1) + len = sizeof(indent_chars) - 1; blobmsg_puts(s, indent_chars, len); }