diff --git a/hs20/client/est.c b/hs20/client/est.c index 97f913210..c3f27e1e9 100644 --- a/hs20/client/est.c +++ b/hs20/client/est.c @@ -17,9 +17,7 @@ #include #include #include -#ifdef OPENSSL_IS_BORINGSSL -#include -#endif /* OPENSSL_IS_BORINGSSL */ +#include #include "common.h" #include "utils/base64.h" @@ -220,9 +218,7 @@ typedef struct { } d; } AttrOrOID; -#if OPENSSL_VERSION_NUMBER >= 0x10100000L && !defined(OPENSSL_IS_BORINGSSL) DEFINE_STACK_OF(AttrOrOID) -#endif typedef struct { int type; @@ -340,30 +336,13 @@ static void add_csrattrs(struct hs20_osu_client *ctx, CsrAttrs *csrattrs, if (!csrattrs || ! csrattrs->attrs) return; -#ifdef OPENSSL_IS_BORINGSSL - num = sk_num(CHECKED_CAST(_STACK *, STACK_OF(AttrOrOID) *, - csrattrs->attrs)); - for (i = 0; i < num; i++) { - AttrOrOID *ao = sk_value( - CHECKED_CAST(_STACK *, const STACK_OF(AttrOrOID) *, - csrattrs->attrs), i); - switch (ao->type) { - case 0: - add_csrattrs_oid(ctx, ao->d.oid, exts); - break; - case 1: - add_csrattrs_attr(ctx, ao->d.attribute, exts); - break; - } - } -#else /* OPENSSL_IS_BORINGSSL */ -#if OPENSSL_VERSION_NUMBER >= 0x10100000L && !defined(OPENSSL_IS_BORINGSSL) +#if OPENSSL_VERSION_NUMBER >= 0x10100000L num = sk_AttrOrOID_num(csrattrs->attrs); #else num = SKM_sk_num(AttrOrOID, csrattrs->attrs); #endif for (i = 0; i < num; i++) { -#if OPENSSL_VERSION_NUMBER >= 0x10100000L && !defined(OPENSSL_IS_BORINGSSL) +#if OPENSSL_VERSION_NUMBER >= 0x10100000L AttrOrOID *ao = sk_AttrOrOID_value(csrattrs->attrs, i); #else AttrOrOID *ao = SKM_sk_value(AttrOrOID, csrattrs->attrs, i); @@ -377,7 +356,6 @@ static void add_csrattrs(struct hs20_osu_client *ctx, CsrAttrs *csrattrs, break; } } -#endif /* OPENSSL_IS_BORINGSSL */ } diff --git a/src/crypto/tls_openssl_ocsp.c b/src/crypto/tls_openssl_ocsp.c index 2e0334b64..4e4c2ac8e 100644 --- a/src/crypto/tls_openssl_ocsp.c +++ b/src/crypto/tls_openssl_ocsp.c @@ -216,13 +216,7 @@ ASN1_SEQUENCE(BasicOCSPResponse) = { IMPLEMENT_ASN1_FUNCTIONS(BasicOCSPResponse); -#define sk_SingleResponse_num(sk) \ -sk_num(CHECKED_CAST(_STACK *, STACK_OF(SingleResponse) *, sk)) - -#define sk_SingleResponse_value(sk, i) \ - ((SingleResponse *) \ - sk_value(CHECKED_CAST(_STACK *, STACK_OF(SingleResponse) *, sk), (i))) - +DEFINE_STACK_OF(SingleResponse) static char * mem_bio_to_str(BIO *out) { diff --git a/src/utils/http_curl.c b/src/utils/http_curl.c index 30b07f23d..77d5b3578 100644 --- a/src/utils/http_curl.c +++ b/src/utils/http_curl.c @@ -433,28 +433,6 @@ ASN1_SEQUENCE(LogotypeExtn) = { IMPLEMENT_ASN1_FUNCTIONS(LogotypeExtn); -#ifdef OPENSSL_IS_BORINGSSL -#define sk_LogotypeInfo_num(st) \ -sk_num(CHECKED_CAST(_STACK *, STACK_OF(LogotypeInfo) *, (st))) -#define sk_LogotypeInfo_value(st, i) (LogotypeInfo *) \ -sk_value(CHECKED_CAST(_STACK *, const STACK_OF(LogotypeInfo) *, (st)), (i)) -#define sk_LogotypeImage_num(st) \ -sk_num(CHECKED_CAST(_STACK *, STACK_OF(LogotypeImage) *, (st))) -#define sk_LogotypeImage_value(st, i) (LogotypeImage *) \ -sk_value(CHECKED_CAST(_STACK *, const STACK_OF(LogotypeImage) *, (st)), (i)) -#define sk_LogotypeAudio_num(st) \ -sk_num(CHECKED_CAST(_STACK *, STACK_OF(LogotypeAudio) *, (st))) -#define sk_LogotypeAudio_value(st, i) (LogotypeAudio *) \ -sk_value(CHECK_CAST(_STACK *, const STACK_OF(LogotypeAudio) *, (st)), (i)) -#define sk_HashAlgAndValue_num(st) \ -sk_num(CHECKED_CAST(_STACK *, STACK_OF(HashAlgAndValue) *, (st))) -#define sk_HashAlgAndValue_value(st, i) (HashAlgAndValue *) \ -sk_value(CHECKED_CAST(_STACK *, const STACK_OF(HashAlgAndValue) *, (st)), (i)) -#define sk_ASN1_IA5STRING_num(st) \ -sk_num(CHECKED_CAST(_STACK *, STACK_OF(ASN1_IA5STRING) *, (st))) -#define sk_ASN1_IA5STRING_value(st, i) (ASN1_IA5STRING *) \ -sk_value(CHECKED_CAST(_STACK *, const STACK_OF(ASN1_IA5STRING) *, (st)), (i)) -#else /* OPENSSL_IS_BORINGSSL */ #if OPENSSL_VERSION_NUMBER < 0x10100000L #define sk_LogotypeInfo_num(st) SKM_sk_num(LogotypeInfo, (st)) #define sk_LogotypeInfo_value(st, i) SKM_sk_value(LogotypeInfo, (st), (i)) @@ -473,7 +451,6 @@ DEFINE_STACK_OF(LogotypeAudio) DEFINE_STACK_OF(HashAlgAndValue) DEFINE_STACK_OF(ASN1_IA5STRING) #endif -#endif /* OPENSSL_IS_BORINGSSL */ static void add_logo(struct http_ctx *ctx, struct http_cert *hcert,