From f62415df8a948b62ba6f88c24f854d38626f8bb1 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sat, 14 Jun 2014 01:20:18 +0300 Subject: [PATCH] Note chmod() failure in debug log even in ignore case (CID 62843) If this chmod() call fails, the global control interface is allowed to be used since there was no change to its group. Anyway, it can be helpful to note the error case in debug log instead of silently ignoring it. Signed-off-by: Jouni Malinen --- wpa_supplicant/ctrl_iface_unix.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/wpa_supplicant/ctrl_iface_unix.c b/wpa_supplicant/ctrl_iface_unix.c index d4e45de77..40082e24a 100644 --- a/wpa_supplicant/ctrl_iface_unix.c +++ b/wpa_supplicant/ctrl_iface_unix.c @@ -990,7 +990,13 @@ static int wpas_global_ctrl_iface_open_sock(struct wpa_global *global, goto fail; } } else { - chmod(ctrl, S_IRWXU); + if (chmod(ctrl, S_IRWXU) < 0) { + wpa_printf(MSG_DEBUG, + "chmod[global_ctrl_interface=%s](S_IRWXU): %s", + ctrl, strerror(errno)); + /* continue anyway since group change was not required + */ + } } havesock: