From c8931afe2455895b0b0d4addc94d0a3691ec9ab5 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Thu, 18 Apr 2019 21:54:13 +0300 Subject: [PATCH] nl80211: Check nla_put_flag() failure for ext auth All nla_put*() operations should be verified to succeed, so check this recently added one for NL80211_ATTR_EXTERNAL_AUTH_SUPPORT. Fixes: 236e793e7b8b ("nl80211: External authentication in driver-based AP SME mode") Signed-off-by: Jouni Malinen --- src/drivers/driver_nl80211.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 21d1398ec..54fe39000 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -4171,8 +4171,10 @@ static int wpa_driver_nl80211_set_ap(void *priv, nla_put_flag(msg, NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT))) goto fail; - if (drv->device_ap_sme && (params->key_mgmt_suites & WPA_KEY_MGMT_SAE)) - nla_put_flag(msg, NL80211_ATTR_EXTERNAL_AUTH_SUPPORT); + if (drv->device_ap_sme && + (params->key_mgmt_suites & WPA_KEY_MGMT_SAE) && + nla_put_flag(msg, NL80211_ATTR_EXTERNAL_AUTH_SUPPORT)) + goto fail; wpa_printf(MSG_DEBUG, "nl80211: pairwise_ciphers=0x%x", params->pairwise_ciphers);