DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

nl80211: Skip interface down/up when setting MAC address

Browse source 
A driver may not support setting MAC address when interface is UP, so
wpa_supplicant used to always sets the interface down for MAC address
change.

Try to change the address first without setting the interface down and
then fall back to DOWN/set addr/UP if the first attempt failed. This can
reduce the interface setup time for time-critical use cases.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
This commit is contained in:
Hu Wang 2023-10-26 01:51:38 -07:00 • committed by Jouni Malinen
parent 9e426e068d
commit bffd2b3994
1 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/drivers/driver_nl80211.c
View file

@ -11609,6 +11609,15 @@ static int nl80211_set_mac_addr(void *priv, const u8 *addr)
if (!addr) if (!addr)
addr = drv->perm_addr; addr = drv->perm_addr;
/*
* Try to change the address first without setting the interface
* down and then fall back to DOWN/set addr/UP if the first
* attempt failed. This can reduce the interface setup time
* significantly with some drivers.
*/
if (!linux_set_ifhwaddr(drv->global->ioctl_sock, bss->ifname, addr))
goto done;
if (linux_set_iface_flags(drv->global->ioctl_sock, bss->ifname, 0) < 0) if (linux_set_iface_flags(drv->global->ioctl_sock, bss->ifname, 0) < 0)
return -1; return -1;
@ -11625,18 +11634,19 @@ static int nl80211_set_mac_addr(void *priv, const u8 *addr)
return -1; return -1;
} }
wpa_printf(MSG_DEBUG, "nl80211: set_mac_addr for %s to " MACSTR,
bss->ifname, MAC2STR(addr));
drv->addr_changed = new_addr;
os_memcpy(bss->prev_addr, bss->addr, ETH_ALEN);
os_memcpy(bss->addr, addr, ETH_ALEN);
if (linux_set_iface_flags(drv->global->ioctl_sock, bss->ifname, 1) < 0) if (linux_set_iface_flags(drv->global->ioctl_sock, bss->ifname, 1) < 0)
{ {
wpa_printf(MSG_DEBUG, wpa_printf(MSG_DEBUG,
"nl80211: Could not restore interface UP after set_mac_addr"); "nl80211: Could not restore interface UP after set_mac_addr");
} }
done:
wpa_printf(MSG_DEBUG, "nl80211: set_mac_addr for %s to " MACSTR,
bss->ifname, MAC2STR(addr));
drv->addr_changed = new_addr;
os_memcpy(bss->prev_addr, bss->addr, ETH_ALEN);
os_memcpy(bss->addr, addr, ETH_ALEN);
return 0; return 0;
} }