DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Replace "sanity" with "validity"

Browse source 
Replaced the word "sanity" with the inclusive word "validity". The
comment in acs_survey_interference_factor() was referring a function
that does not exist, so remove it instead of trying rename the function.

Signed-off-by: Arowa Suliman <arowa@chromium.org>
This commit is contained in:
Arowa Suliman 2021-09-18 23:24:27 -07:00 committed by Jouni Malinen
parent 891bb1305b
commit 7b50f2f04c
8 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ap/acs.c
View file

@ -309,8 +309,6 @@ acs_survey_interference_factor(struct freq_survey *survey, s8 min_nf)
else if (survey->filled & SURVEY_HAS_CHAN_TIME_RX) else if (survey->filled & SURVEY_HAS_CHAN_TIME_RX)
busy = survey->channel_time_rx; busy = survey->channel_time_rx;
else { else {
/* This shouldn't really happen as survey data is checked in
* acs_sanity_check() */
wpa_printf(MSG_ERROR, "ACS: Survey data missing"); wpa_printf(MSG_ERROR, "ACS: Survey data missing");
return 0; return 0;
} }

4
src/ap/wpa_auth_ft.c
View file

@ -455,7 +455,7 @@ static int wpa_ft_rrb_lin(const struct tlv_list *tlvs1,
pos += wpa_ft_tlv_lin(tlvs2, pos, endpos); pos += wpa_ft_tlv_lin(tlvs2, pos, endpos);
pos += wpa_ft_vlan_lin(vlan, pos, endpos); pos += wpa_ft_vlan_lin(vlan, pos, endpos);
/* sanity check */ /* validity check */
if (pos != endpos) { if (pos != endpos) {
wpa_printf(MSG_ERROR, "FT: Length error building RRB"); wpa_printf(MSG_ERROR, "FT: Length error building RRB");
goto err; goto err;
@ -3590,7 +3590,7 @@ int wpa_ft_action_rx(struct wpa_state_machine *sm, const u8 *data, size_t len)
} }
/* /*
* Do some sanity checking on the target AP address (not own and not * Do some validity checking on the target AP address (not own and not
* broadcast. This could be extended to filter based on a list of known * broadcast. This could be extended to filter based on a list of known
* APs in the MD (if such a list were configured). * APs in the MD (if such a list were configured).
*/ */

2
src/p2p/p2p_pd.c
View file

@ -1425,7 +1425,7 @@ void p2p_process_prov_disc_resp(struct p2p_data *p2p, const u8 *sa,
* Save the reported channel list and operating frequency. * Save the reported channel list and operating frequency.
* Note that the specification mandates that the responder * Note that the specification mandates that the responder
* should include in the channel list only channels reported by * should include in the channel list only channels reported by
* the initiator, so this is only a sanity check, and if this * the initiator, so this is only a validity check, and if this
* fails the flow would continue, although it would probably * fails the flow would continue, although it would probably
* fail. Same is true for the operating channel. * fail. Same is true for the operating channel.
*/ */

8
src/pae/ieee802_1x_kay.c
View file

@ -3057,11 +3057,11 @@ int ieee802_1x_kay_enable_new_info(struct ieee802_1x_kay *kay)
/** /**
* ieee802_1x_kay_mkpdu_sanity_check - * ieee802_1x_kay_mkpdu_validity_check -
* Sanity checks specified in IEEE Std 802.1X-2010, 11.11.2 (Validation of * Validity checks specified in IEEE Std 802.1X-2010, 11.11.2 (Validation of
* MKPDUs) * MKPDUs)
*/ */
static int ieee802_1x_kay_mkpdu_sanity_check(struct ieee802_1x_kay *kay, static int ieee802_1x_kay_mkpdu_validity_check(struct ieee802_1x_kay *kay,
const u8 *buf, size_t len) const u8 *buf, size_t len)
{ {
struct ieee8023_hdr *eth_hdr; struct ieee8023_hdr *eth_hdr;
@ -3215,7 +3215,7 @@ static int ieee802_1x_kay_decode_mkpdu(struct ieee802_1x_kay *kay,
wpa_printf(MSG_DEBUG, "KaY: Decode received MKPDU (ifname=%s)", wpa_printf(MSG_DEBUG, "KaY: Decode received MKPDU (ifname=%s)",
kay->if_name); kay->if_name);
if (ieee802_1x_kay_mkpdu_sanity_check(kay, buf, len)) if (ieee802_1x_kay_mkpdu_validity_check(kay, buf, len))
return -1; return -1;
/* handle basic parameter set */ /* handle basic parameter set */

2
tests/hwsim/test_fst_config.py
View file

@ -272,7 +272,7 @@ def parse_ies(iehex, el=-1):
iel = [iehex[i:i + 2] for i in range(0, len(iehex), 2)] iel = [iehex[i:i + 2] for i in range(0, len(iehex), 2)]
for i in range(0, len(iel)): for i in range(0, len(iel)):
iel[i] = int(iel[i], 16) iel[i] = int(iel[i], 16)
# Sanity check # Validity check
i = 0 i = 0
res = [] res = []
while i < len(iel): while i < len(iel):

2
tests/hwsim/test_wmediumd.py
View file

@ -1,4 +1,4 @@
# wmediumd sanity checks # wmediumd validity checks
# Copyright (c) 2015, Intel Deutschland GmbH # Copyright (c) 2015, Intel Deutschland GmbH
# #
# This software may be distributed under the terms of the BSD license. # This software may be distributed under the terms of the BSD license.

2
wpa_supplicant/ctrl_iface.c
View file

@ -5924,7 +5924,7 @@ static struct p2ps_provision * p2p_parse_asp_provision_cmd(const char *cmd)
for (i = 0; p2ps_prov->cpt_priority[i]; i++) for (i = 0; p2ps_prov->cpt_priority[i]; i++)
p2ps_prov->cpt_mask |= p2ps_prov->cpt_priority[i]; p2ps_prov->cpt_mask |= p2ps_prov->cpt_priority[i];
/* force conncap with tstCap (no sanity checks) */ /* force conncap with tstCap (no validity checks) */
pos = os_strstr(cmd, "tstCap="); pos = os_strstr(cmd, "tstCap=");
if (pos) { if (pos) {
role = strtol(pos + 7, NULL, 16); role = strtol(pos + 7, NULL, 16);

4
wpa_supplicant/p2p_supplicant_sd.c
View file

@ -826,7 +826,7 @@ static void wpas_sd_p2ps_serv_response(struct wpa_supplicant *wpa_s,
size_t buf_len; size_t buf_len;
u8 svc_len; u8 svc_len;
/* Sanity check fixed length+svc_str */ /* Validity check fixed length+svc_str */
if (6 >= tlv_end - pos) if (6 >= tlv_end - pos)
break; break;
svc_len = pos[6]; svc_len = pos[6];
@ -854,7 +854,7 @@ static void wpas_sd_p2ps_serv_response(struct wpa_supplicant *wpa_s,
buf_len = WPA_GET_LE16(pos); buf_len = WPA_GET_LE16(pos);
pos += sizeof(u16); pos += sizeof(u16);
/* Sanity check buffer length */ /* Validity check buffer length */
if (buf_len > (unsigned int) (tlv_end - pos)) if (buf_len > (unsigned int) (tlv_end - pos))
break; break;