From 770760454f9e5c221c2f89b2410524dfbdf58179 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Thu, 10 Aug 2023 12:12:01 +0300 Subject: [PATCH] wlantest: Do not update BSS entries for other AP MLDs in PTK cloning The new PTK migth need to be copied to another MLO STA entry, but that operation should not modify the MLD MAC address of unrelated AP MLDs. Signed-off-by: Jouni Malinen --- wlantest/sta.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/wlantest/sta.c b/wlantest/sta.c index d6110217c..6c6c6235a 100644 --- a/wlantest/sta.c +++ b/wlantest/sta.c @@ -345,6 +345,9 @@ void sta_new_ptk(struct wlantest *wt, struct wlantest_sta *sta, if (!match) continue; + if (os_memcmp(sta->bss->mld_mac_addr, + osta->bss->mld_mac_addr, ETH_ALEN) != 0) + continue; wpa_printf(MSG_DEBUG, "Add PTK to another MLO STA entry " MACSTR " (MLD " MACSTR " --> " MACSTR ") in BSS " @@ -358,8 +361,6 @@ void sta_new_ptk(struct wlantest *wt, struct wlantest_sta *sta, sta_copy_ptk(osta, ptk); os_memcpy(osta->mld_mac_addr, sta->mld_mac_addr, ETH_ALEN); - os_memcpy(osta->bss->mld_mac_addr, - sta->bss->mld_mac_addr, ETH_ALEN); } } }