From 6fad40df9eed9dceb9a9d17288a301341de6f88b Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Mon, 3 Aug 2015 18:52:10 +0300 Subject: [PATCH] tests: Make dbus_p2p_group_termination_by_go more robust Set peer_group_removed only if peer_group_added has already been set. This fixes an issue where a propertiesChanged event triggered by an earlier test case was able to get dbus_p2p_group_termination_by_go terminated too early. This happened, e.g., with sequence "dbus_p2p_two_groups dbus_p2p_group_termination_by_go". Signed-off-by: Jouni Malinen --- tests/hwsim/test_dbus.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hwsim/test_dbus.py b/tests/hwsim/test_dbus.py index ff888b78e..650c0d915 100644 --- a/tests/hwsim/test_dbus.py +++ b/tests/hwsim/test_dbus.py @@ -4237,7 +4237,7 @@ def test_dbus_p2p_group_termination_by_go(dev, apdev): return if len(changed_properties["Groups"]) > 0: self.peer_group_added = True - if len(changed_properties["Groups"]) == 0: + if len(changed_properties["Groups"]) == 0 and self.peer_group_added: self.peer_group_removed = True self.loop.quit()