From 6220fb52e301b5dee56fa08e5da823d19a99314c Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sat, 25 Nov 2023 11:13:42 +0200 Subject: [PATCH] dbus: Increase XML buffer size for an interface introspection data The current set of global configuration fields is getting close to the previously used 15000 byte limit, so increase this size to 16000 and add a note about the potential need to change this size when adding new fields. Signed-off-by: Jouni Malinen --- wpa_supplicant/config.c | 3 +++ wpa_supplicant/dbus/dbus_new_introspect.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/wpa_supplicant/config.c b/wpa_supplicant/config.c index 77467f00a..a0d151d7a 100644 --- a/wpa_supplicant/config.c +++ b/wpa_supplicant/config.c @@ -5519,6 +5519,9 @@ static const struct global_parse_data global_fields[] = { { INT_RANGE(pasn_corrupt_mic, 0, 1), 0 }, #endif /* CONFIG_TESTING_OPTIONS */ #endif /* CONFIG_PASN */ + /* NOTE: When adding new parameters here, add_interface() in + * wpa_supplicant/dbus_new_introspect.c may need to be modified to + * increase the size of the iface->xml buffer. */ }; #undef FUNC diff --git a/wpa_supplicant/dbus/dbus_new_introspect.c b/wpa_supplicant/dbus/dbus_new_introspect.c index 6c721bf55..a8c0d2839 100644 --- a/wpa_supplicant/dbus/dbus_new_introspect.c +++ b/wpa_supplicant/dbus/dbus_new_introspect.c @@ -38,7 +38,7 @@ static struct interfaces * add_interface(struct dl_list *list, if (!iface) return NULL; iface->dbus_interface = os_strdup(dbus_interface); - iface->xml = wpabuf_alloc(15000); + iface->xml = wpabuf_alloc(16000); if (iface->dbus_interface == NULL || iface->xml == NULL) { os_free(iface->dbus_interface); wpabuf_free(iface->xml);