DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

EAP-FAST peer: Remove fixed return value from eap_fast_parse_phase1()

Browse source 
This function was always returning 0, so the error path was unreachable.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2016-02-20 10:06:48 +02:00
parent d7ef6e6371
commit 5558b9980f
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/eap_peer/eap_fast.c
View file

@ -113,8 +113,8 @@ static int eap_fast_session_ticket_cb(void *ctx, const u8 *ticket, size_t len,
} }
static int eap_fast_parse_phase1(struct eap_fast_data *data, static void eap_fast_parse_phase1(struct eap_fast_data *data,
const char *phase1) const char *phase1)
{ {
const char *pos; const char *pos;
@ -140,8 +140,6 @@ static int eap_fast_parse_phase1(struct eap_fast_data *data,
wpa_printf(MSG_DEBUG, "EAP-FAST: Using binary format for PAC " wpa_printf(MSG_DEBUG, "EAP-FAST: Using binary format for PAC "
"list"); "list");
} }
return 0;
} }
@ -159,10 +157,8 @@ static void * eap_fast_init(struct eap_sm *sm)
data->fast_version = EAP_FAST_VERSION; data->fast_version = EAP_FAST_VERSION;
data->max_pac_list_len = 10; data->max_pac_list_len = 10;
if (config->phase1 && eap_fast_parse_phase1(data, config->phase1) < 0) { if (config->phase1)
eap_fast_deinit(sm, data); eap_fast_parse_phase1(data, config->phase1);
return NULL;
}
if (eap_peer_select_phase2_methods(config, "auth=", if (eap_peer_select_phase2_methods(config, "auth=",
&data->phase2_types, &data->phase2_types,