From 54706957e3e417f1b3cd8fe4a7935c9c38973da4 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Fri, 26 Aug 2022 00:25:17 +0300 Subject: [PATCH] DPP: Fix DPP_RELAY_ADD_CONTROLLER command parsing hostapd_dpp_add_controller() ended up trying to parse the IP address without nul terminating it. This might work with some C libraries, but not all. And anyway, this was already supposed to nul terminate the string since a temporary copy is created of the constant string. Fix this by adding the missed replacement of the space with nul. Fixes: bfe3cfc382d6 ("DPP: Allow Relay connections to Controllers to be added and removed") Signed-off-by: Jouni Malinen --- src/ap/dpp_hostapd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ap/dpp_hostapd.c b/src/ap/dpp_hostapd.c index 7055784c4..232b5fbbc 100644 --- a/src/ap/dpp_hostapd.c +++ b/src/ap/dpp_hostapd.c @@ -3427,7 +3427,7 @@ int hostapd_dpp_add_controller(struct hostapd_data *hapd, const char *cmd) pos = os_strchr(tmp, ' '); if (!pos) goto fail; - pos++; + *pos++ = '\0'; if (hostapd_parse_ip_addr(tmp, &addr) < 0 || hexstr2bin(pos, pkhash, SHA256_MAC_LEN) < 0) goto fail;