DGNum/hostapd
6
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

ERP: Silence static analyzer warning

Browse source 
The check for erp->keyname_nai within eap_erp_get_key() is apparently
too difficult for some static analyzers to notice. Add an explicit check
for os_strchr() return value being non-NULL to avoid false reports.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2017-05-01 22:06:53 +03:00
parent d912953e37
commit 01dd2b1054
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/eap_peer/eap.c
View file

@ -534,6 +534,8 @@ int eap_peer_get_erp_info(struct eap_sm *sm, struct eap_peer_config *config,
return -1; /* SEQ has range of 0..65535 */ return -1; /* SEQ has range of 0..65535 */
pos = os_strchr(erp->keyname_nai, '@'); pos = os_strchr(erp->keyname_nai, '@');
if (!pos)
return -1; /* this cannot really happen */
*username_len = pos - erp->keyname_nai; *username_len = pos - erp->keyname_nai;
*username = (u8 *) erp->keyname_nai; *username = (u8 *) erp->keyname_nai;