From 2c49b25d5913e7a13ebd452283530a479721e7c7 Mon Sep 17 00:00:00 2001 From: Ludovic Stephan Date: Mon, 25 Mar 2019 23:30:55 +0100 Subject: [PATCH] Cleaner error code management --- gestioncof/views.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/gestioncof/views.py b/gestioncof/views.py index 805c5576..f5000456 100644 --- a/gestioncof/views.py +++ b/gestioncof/views.py @@ -89,15 +89,9 @@ class LoginExtView(DjangoLoginView): def form_invalid(self, form): # forms.non_field_errors() returns strings for some reason non_field_errors = form.errors["__all__"].as_data() - exte_login_error = next( - (e for e in non_field_errors if e.code in ["has_clipper", "no_password"]), - None, - ) - - if exte_login_error is not None: - return render( - self.request, "login_error.html", {"error_code": exte_login_error.code} - ) + for e in non_field_errors: + if e.code in ["has_clipper", "no_password"]: + return render(self.request, "login_error.html", {"error_code": e.code}) return super().form_invalid(form)