Commit graph

14581 commits

Author SHA1 Message Date
Pierre de La Morinerie
087e438eb6 models: delete AdministrateursInstructeur when destroying Instructeur
By default, `has_and_belongs_to_many` properly deletes the record in
the join table.

However, as the association is declared manually with a
`has_many / through`, it doesn't delete the joined record automatically.

As we also lack a foreign-key contraint on the join table, that means
a dangling record remains in the join table.

To fix this, let's declare it a proper `has_and_belongs_to_many`
association, which will let the join record be deleted automatically
on destroy.
2022-03-02 11:26:53 +01:00
Paul Chavard
92e79027c4
Merge pull request #6997 from betagouv/fix-drom-phones-formatting
Correction de l'affichage des numéros de téléphone des DROM
2022-03-02 10:05:53 +00:00
Pierre de La Morinerie
e32c9a9f94 models: don't attempt to format invalid phone numbers
This is a defensive-programming measure, because formatting an
invalid phone number may truncate some leading numbers.
2022-03-02 09:57:03 +00:00
Pierre de La Morinerie
f35d18cd5c models: stop truncating DROM phone numbers
Fix #6996
2022-03-02 09:57:03 +00:00
Pierre de La Morinerie
5150e33212 models: ensure DROM phone numbers are valid
They were accepted before, because they were 'possible' – but now
they are explicitely considered as valid.
2022-03-02 09:57:03 +00:00
Paul Chavard
cb5561978a
Merge pull request #6999 from tchak/fix-multi-select
fix(multi-select): fix labels on multi select component
2022-03-02 09:56:07 +00:00
Paul Chavard
b8a22ae8b2 fix(multi-select): fix labels on multi select component 2022-03-02 09:48:54 +00:00
Paul Chavard
963bc90c94
Merge pull request #6998 from betagouv/dependabot/bundler/image_processing-1.12.2
chore(deps): bump image_processing from 1.12.1 to 1.12.2
2022-03-02 09:10:57 +00:00
dependabot[bot]
19cde3140e
chore(deps): bump image_processing from 1.12.1 to 1.12.2
Bumps [image_processing](https://github.com/janko/image_processing) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/janko/image_processing/releases)
- [Changelog](https://github.com/janko/image_processing/blob/master/CHANGELOG.md)
- [Commits](https://github.com/janko/image_processing/compare/v1.12.1...v1.12.2)

---
updated-dependencies:
- dependency-name: image_processing
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-01 23:35:43 +00:00
Pierre de La Morinerie
371d141fcd
Merge pull request #6971 from mfaure/Ajout_doc_deploiement
Ajout de documentation pour le déploiement
2022-03-01 17:09:30 +01:00
Pierre de La Morinerie
64a28cc8bd doc: move the ADR to their own directory 2022-03-01 17:05:06 +01:00
Pierre de La Morinerie
bbc45f25ef doc: add deployment notes 2022-03-01 17:05:05 +01:00
Matthieu FAURE
4fd9312fc9 DOC Ajout doc déploiement, avec montée de version et migration de données (afterparty) 2022-03-01 17:05:05 +01:00
Pierre de La Morinerie
98d087ab4d
Merge pull request #6992 from betagouv/admin-deletion
Suppression des AdministrateursProcedure quand un Administrateur est supprimé
2022-03-01 17:04:00 +01:00
Pierre de La Morinerie
3fde7021e7 db: add foreign key contraint to AdministrateursProcedure 2022-03-01 16:58:04 +01:00
Pierre de La Morinerie
71e1b6c973 models: delete AdministrateursProcedure when destroying Administrateur
By default, `has_and_belongs_to_many` properly deletes the record in
the join table.

However, as the association is declared manually with a
`has_many / through`, it doesn't delete the joined record automatically.

As we also lack a foreign-key contraint on the join table, that means
a dangling record remains in the join table.

To fix this, let's declare it a proper `has_and_belongs_to_many`
association, which will let the join record be deleted automatically
on destroy.
2022-03-01 16:58:04 +01:00
Paul Chavard
9bd1d128d4
Merge pull request #6987 from tchak/fix-map-spec
fix(carto): show map UI before loading map styles
2022-03-01 11:13:32 +00:00
Paul Chavard
2a42690388 fix(carto): show map UI before loading map styles 2022-03-01 11:08:07 +00:00
Pierre de La Morinerie
022fb04e2b
Merge pull request #6993 from betagouv/dependabot/bundler/nokogiri-1.13.3 2022-03-01 11:33:14 +01:00
simon lehericey
30a7fb25a7 update nokogiri 2022-03-01 10:01:33 +01:00
mfo
b7da406fe4
Merge pull request #6990 from betagouv/US/fix-avis
fix(avis_controller#*): missing ACL
2022-02-28 15:12:53 +01:00
mfo
4346775169
Merge branch 'main' into US/fix-avis 2022-02-28 15:08:25 +01:00
Martin
48612028f4 fix(avis_controller#*): missing ACL 2022-02-28 14:24:41 +01:00
mfo
43f8bbfb11
Merge pull request #6913 from betagouv/US/redirect-after-dossier-submitted
Possibilité de rediriger l'usager vers un site externe après dépôt de son dossier
2022-02-25 14:05:27 +01:00
Martin
b808b4db00 fix(relation): avoid double association between procedure/procedure_revision/dossier_submitted_message 2022-02-25 14:01:18 +01:00
Martin
35b9487897 feat(data.integrity): add foreign key to prevent orphan data 2022-02-25 14:01:18 +01:00
Martin
567d01478e fix(brakeman): prune absolete and ad a new one [surprise] 2022-02-25 14:01:18 +01:00
Martin
85a588541b feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap
wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook

refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers

refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook.

feat(wip): current progress
2022-02-25 14:01:18 +01:00
LeSim
7c45589ae6
Merge pull request #6986 from betagouv/fc-agent-2
Relooking agent connect v2
2022-02-25 10:42:48 +01:00
simon lehericey
83d2e44cd7 do not show connect button on agentconnect page 2022-02-24 12:23:12 +01:00
simon lehericey
0d74a6e45e compact display to show agentconnect to small screen 2022-02-24 12:23:12 +01:00
simon lehericey
28005db9aa do not show left column on small screen 2022-02-24 12:23:12 +01:00
simon lehericey
7883b08a5e apply new style to agent connect 2022-02-24 12:23:12 +01:00
Paul Chavard
a92c4c39b3
Merge pull request #6959 from tchak/chore-pin-node
[RFC] chore(node): use volta
2022-02-24 09:54:33 +01:00
Paul Chavard
c3fa55b9f4 chore(node): add yarn clean to help with webpacker caching issues 2022-02-24 08:48:27 +00:00
Paul Chavard
9bd0373aaa chore(node): add .node-version file 2022-02-24 08:48:27 +00:00
Paul Chavard
ffcff87103
Merge pull request #6985 from tchak/fix-eslint
Javascript : correction des avertissements ESLint
2022-02-24 09:48:01 +01:00
Paul Chavard
8ee6bdfac0 chore(eslint): make @typescript-eslint/no-explicit-any an error 2022-02-23 15:28:52 +01:00
Paul Chavard
7c8e97f084 chore(eslint): ignore type of global react-query queryFn 2022-02-23 15:28:51 +01:00
Paul Chavard
cd2273ba54 chore(eslint): ignore any types in maplibre styles 2022-02-23 15:28:51 +01:00
Paul Chavard
67bfeb261a chore(eslint): fix gon types 2022-02-23 15:28:51 +01:00
Paul Chavard
12ddaa0533 chore(eslint): disable types because we use mapbox plugin with maplibre 2022-02-23 15:28:51 +01:00
Paul Chavard
96e9024694 chore(eslint): disable types on complicated event handlers 2022-02-23 15:28:51 +01:00
Paul Chavard
4e218ba562 chore(eslint): fix react-query cancelable promise type 2022-02-23 15:28:51 +01:00
Paul Chavard
a914950982 chore(eslint): fix getJSON reponse type 2022-02-23 15:28:51 +01:00
Paul Chavard
beafa21796 chore(eslint): fix isNumeric types 2022-02-23 15:28:51 +01:00
Paul Chavard
95b9e47993 chore(eslint): fix flash message root element query 2022-02-23 15:28:51 +01:00
Paul Chavard
68e89af775 chore(eslint): make react-hooks/exhaustive-deps rule as an error 2022-02-23 15:28:51 +01:00
Pierre de La Morinerie
c6425cd1a6
Merge pull request #6984 from betagouv/fix-api-entreprise-error
Affichage d'un message clair en cas d'erreur `APIEntreprise::API::Error::ServiceUnavailable`
2022-02-23 14:58:02 +01:00
Pierre de La Morinerie
a2028e115b controllers: fix crash on APIEntreprise::API::Error::TimedOut
In that case we want to display the nicely formatted error message to the
user, instead of a "Error 500" page.
2022-02-23 11:36:25 +01:00