Commit graph

9525 commits

Author SHA1 Message Date
simon lehericey
e64ac79f05 tech(refactor): much nicer code, thx LeSim
root -> rooted_tree

depth_cach -> walk

smal refactor

comment

remove form for header_section

remove seen_at from header section

header_section: champ -> header_section

champ_subree: remove if not

remove root_depth use header_section_level_value instead

remove unused include

remove ChampTreeComponent

rename ChampsSubtreeComponent to SectionComponent

use TreeableConcern only in section component

remove fields_for_champ_component

champs -> tail

add split_section_champ helper

refactor(editable_champ::header_section): keep same interface everywhere

fix(repetition): add spec for SectionComponent on repetitions
2023-04-20 08:22:02 +02:00
Martin
cc2c856ec2 amelioration(bloc-repetable): wrap les blocs repetatable dans des fieldsets 2023-04-20 08:22:02 +02:00
Martin
88abefb370 tech(remaniement): isole la logique de rendu au champs_subtree_component 2023-04-20 08:22:02 +02:00
Martin
3b5d1bd55b tech(remaniement): extraction du passage d'une liste de champs a un simili arbre 2023-04-20 08:22:02 +02:00
Martin
ad77b9321b amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme 2023-04-20 08:22:02 +02:00
Martin
b9faa26560 amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3]. 2023-04-20 08:22:02 +02:00
Paul Chavard
38b806a1e0
Merge pull request #8929 from tchak/feat-display-procedure-state-in-manager
ETQ opérateur, je voudrais pouvoir consulter plus facilement l’état d’une démarche
2023-04-19 19:11:42 +00:00
Paul Chavard
39ba03783a
Merge pull request #8928 from tchak/feat-api-public-stats
ETQ citoyen, je voudrais avoir accès aux statistiques des démarches closes
2023-04-19 19:11:34 +00:00
Paul Chavard
ce466d072a feat(manager): display procedure state and unpublished date 2023-04-19 19:59:54 +02:00
Paul Chavard
418d3b55d0 feat(stats): give access to stats on closed procedures 2023-04-19 18:31:58 +02:00
Colin Darie
e5df31fd66 fix(yaml): yes & no are reserved keywords in yaml, so they have to be quoted 2023-04-19 18:26:40 +02:00
Paul Chavard
63b7a83689 feat(graphql): log dossier and procedure id on dossier fetch endoint 2023-04-19 18:00:08 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Paul Chavard
de858243c0
Merge pull request #8925 from tchak/fix-procedire-remove-duplicate-code
chore(procedure): remove duplicate code
2023-04-19 12:26:34 +00:00
simon lehericey
9c6af921e5 Use has_one defaut_procdre to avoid before destroy prepend 2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
aecd7559d2 feat(groupe instructeur): cannot disable default groupe instructeur 2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab feat(groupe instructeur): cannot delete defaut_groupe_instructeur 2023-04-19 13:52:42 +02:00
simon lehericey
79131cc294 fix spec 2023-04-19 13:52:42 +02:00
simon lehericey
3889bdac73 refactor(routing): remove unused routing_params 2023-04-19 13:52:42 +02:00
simon lehericey
86733248f3 wording pour coller a Routage et Gestion des groupes 2023-04-19 13:52:41 +02:00
simon lehericey
b3ce3820a9 refactor(ui): use proper title 2023-04-19 13:52:41 +02:00
simon lehericey
43b0eae3ee refactor(ui): enough space for button 2023-04-19 13:52:41 +02:00
simon lehericey
b38470368b feat(routing): can change defaut groupe 2023-04-19 13:52:41 +02:00
simon lehericey
95ab81fd1c feat(routing): use procedure.defaut_groupe_instructeur_id to find defaut_groupe_instructeur 2023-04-19 13:52:41 +02:00
mfo
73184c6dac
Merge pull request #8907 from mfo/US/dolist-silence-some-errors
amelioration(dolist): ne log erreurs pas les erreurs dans sentry lorsque le contact chez dolist est injoingable ou hardbounce
2023-04-19 11:49:01 +00:00
Paul Chavard
8904516b85 chore(procedure): remove duplicate code 2023-04-19 13:00:37 +02:00
Colin Darie
1af404c5e7
chore(rubocop): fix Rails/WhereMissing 2023-04-19 12:55:14 +02:00
Colin Darie
f4ad5289cd
chore(rubocop): fix Rails/RedundantPresenceValidationOnBelongsTo 2023-04-19 12:55:14 +02:00
Colin Darie
6eec42135d
chore(rubocop): fix Rails/DotSeparatedKeys 2023-04-19 12:55:14 +02:00
Colin Darie
20f0b64736
chore(rubocop): fix Rails/WhereNotWithMultipleConditions 2023-04-19 12:55:14 +02:00
Colin Darie
e9649b667e
chore(rubocop): fix Rails/IgnoredColumnsAssignment 2023-04-19 12:55:14 +02:00
Colin Darie
8fa5e0dbb8
chore(rubocop): fix Rails/UnusedIgnoredColumns 2023-04-19 12:55:14 +02:00
Colin Darie
7aba5ccc3e
chore(rubocop): fix Rails/DurationArithmetic 2023-04-19 12:55:13 +02:00
Colin Darie
160178b8f8
chore(rubocop): fix Rails/ExpandedDateRange 2023-04-19 12:55:13 +02:00
Colin Darie
bd8e8633e7
chore(rubocop): fix Rails/CompactBlank 2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops 2023-04-19 12:55:13 +02:00
Colin Darie
ca11ec8380
chore(rubocop): fix Rails/OutputSafety 2023-04-19 12:55:12 +02:00
Colin Darie
3317f19323
chore(rubocop): fix Rails/ContentTag 2023-04-19 12:55:12 +02:00
Paul Chavard
05cfb4055d fix(dossier): improuve dossier state display 2023-04-19 12:27:16 +02:00
Paul Chavard
7bf31c6278
Merge pull request #8850 from tchak/feat-refactor-drop-downs
Simplifie l'implémentation des champs "liste d'options" et "listes d'options liées"
2023-04-19 09:59:10 +00:00
Martin
534ce34f87 amelioration(Dolist::ApiSender): lève une Dolist::IgnorableError afin de l'inscrire dans l'historique des EmailEvent 2023-04-19 11:22:13 +02:00
Martin
8fa2bbb67d amelioration(dolist): ne log erreurs pas les erreurs dans sentry lorsque le contact chez dolist est injoingable ou hardbounce 2023-04-19 11:22:13 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
github-merge-queue[bot]
c439a286a8
Merge pull request #8902 from demarches-simplifiees/bug-disable-select-all-actions-multiples
[bug] actions multiples > désactiver la checkbox select_all quand action en cours
2023-04-18 21:52:21 +00:00
Julie Salha
c6aff63ce7 remove phone contact accessibility statement 2023-04-18 17:25:20 +02:00
github-merge-queue[bot]
82f81cef21
Merge pull request #8913 from demarches-simplifiees/fix-display-search-results
[bug display] Améliorer l'affichage des resultats de recherche
2023-04-18 13:35:02 +00:00
github-merge-queue[bot]
26e516ea72
Merge pull request #8888 from tchak/graphql-improuve-stored-query
ETQ intégrateur API, je voudrais avoir accès aux dossiers récemment supprimés d’un groupe instructeur
2023-04-18 13:25:31 +00:00
Paul Chavard
0912a30eb0 feat(dossier): use turbo on select with other 2023-04-18 15:24:23 +02:00
Paul Chavard
eb599394e0 feat(dossier): use turbo on linked lists 2023-04-18 15:24:23 +02:00
Paul Chavard
ae1ec87397 feat(graphql): add code to timeout errors 2023-04-18 15:22:11 +02:00
Paul Chavard
f70532a844 feat(graphql): global not found error handling 2023-04-18 15:22:11 +02:00
Paul Chavard
fbae6d941d feat(graphql): add error codes to graphql errors 2023-04-18 15:22:11 +02:00
Paul Chavard
2a09f1d505 fix(graphql): return empty arrays from loaders when loading collections 2023-04-18 15:20:43 +02:00
Julie Salha
f80cccba93 reset component yes no structure 2023-04-18 14:54:01 +02:00
Julie Salha
f039b6687a add translations account confirmation page 2023-04-18 14:11:58 +02:00
Julie Salha
b1dfc83c17 add translations upload group notice 2023-04-18 14:04:32 +02:00
Julie Salha
be16cb6f5e add missing translations footer email change password 2023-04-18 13:56:50 +02:00
github-merge-queue[bot]
110a8aec97
Merge pull request #8919 from tchak/graphql-stub-fake-files-meta
ETQ intégrateur API, je ne veux pas avoir d'erreurs lorsque j'interroge les métadonnées de certains fichiers
2023-04-18 11:56:32 +00:00
Julie Salha
c37a54b65b add translations profile identification tokens 2023-04-18 13:51:41 +02:00
github-merge-queue[bot]
7a2805d001
Merge pull request #8912 from demarches-simplifiees/user-dashboard/switch-place-for-searchbar
[refonte usager] Tableau de bord - Déplacer la barre de recherche proche des dossiers
2023-04-18 11:47:49 +00:00
Julie Salha
93c5c52e19 add translations for yes-no radios form and update dsfr styles 2023-04-18 13:43:11 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
Paul Chavard
bd07441b7e fix(graphql): stub metadata on fake files interfaces 2023-04-18 11:36:40 +02:00
Paul Chavard
ca9fa71667 feat(graphql): improuve stored query 2023-04-17 18:43:00 +02:00
Paul Chavard
bf6cc25063 feat(graphql): expose pendingDeletedDossiers on groupe instructeur 2023-04-17 18:43:00 +02:00
Paul Chavard
5437727517 chore(api-geo): bump cache keys 2023-04-17 14:29:24 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Lisa Durand
e140d1cc7a restore the hidden overflow from DSFR on table 2023-04-17 10:08:43 +02:00
Lisa Durand
4ed29268bf fix table display for search result 2023-04-14 17:42:37 +02:00
Paul Chavard
cb6875352e fix(dossier): désactiver la checkbox select_all quand action en cours 2023-04-14 17:41:22 +02:00
Lisa Durand
f762323017 change searchbar from header to dashboard for user 2023-04-14 16:28:37 +02:00
mfo
e8218821a0
Merge pull request #8908 from mfo/US/doc-dolist-tracking
amelioration(dolist): desactive le tracking http
2023-04-14 09:12:04 +00:00
Martin
a47b19bee9 amelioration(dolist): desactive le tracking http 2023-04-14 10:11:09 +02:00
Lisa Durand
229ce67a5d
Add 'visible_by_user' - review PR
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2023-04-14 10:10:22 +02:00
Paul Chavard
98caf41a36 fix(dossier): find communes outside of departement 2023-04-13 13:09:56 +02:00
Paul Chavard
21b548d32b fix(dossier): delete all champs starting with children 2023-04-13 11:08:10 +02:00
Paul Chavard
7054c2d9ef fix(demarche): always reset outside of transactions 2023-04-13 11:05:38 +02:00
simon lehericey
f6948cfd5e feat(routing): record first groupe as default_groupe_instructeur 2023-04-13 10:36:42 +02:00
Eric Leroy-Terquem
cade677355 feat(db): add defaut_groupe_instructeur_id column to procedures 2023-04-13 10:36:42 +02:00
simon lehericey
c02319aa56 feat(routing): reset value if target as changed 2023-04-13 10:28:53 +02:00
simon lehericey
9fe8f98a17 refactor(routing): add id to option to help morph 2023-04-13 10:28:53 +02:00
simon lehericey
e27e18fdaf refactor(routing): use selerialized logic in select value 2023-04-13 10:28:53 +02:00
simon lehericey
16565d099a refactor(routing): add groupe_instructeur helper 2023-04-13 10:28:52 +02:00
simon lehericey
8b832396a3 feat(routing): server side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
9ea75a5bd1 feat(routing): ui side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa feat(routing): server side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
3f55fddcef feat(routing): ui side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
213d463ff4 feat(routing): small UI polish 2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
c4d64d9775 feat(routing): add message if no type de champs routable 2023-04-13 10:28:52 +02:00
simon lehericey
80b5f6bc1d feat(champ_component): add errors banner 2023-04-13 10:28:52 +02:00
simon lehericey
362c220587 fix(champ_component): enable preview 2023-04-13 10:28:52 +02:00
simon lehericey
6e255489a5 feat(routing): fix test 2023-04-13 10:28:51 +02:00
Paul Chavard
8d89e2aec6
Merge pull request #8889 from tchak/chore-commune-remove-fallback
chore(dossier): remove fallback from commune champ
2023-04-12 17:33:14 +00:00
krichtof
6ed6f1ae58 add service siret filter in all demarches view 2023-04-12 18:53:57 +02:00
krichtof
78938b5a07 filter demarches by siret service 2023-04-12 18:53:57 +02:00
Lisa Durand
bf8c218d3a Disabled select_all checkbox if all checkboxes are disabled 2023-04-12 16:58:15 +02:00
Lisa Durand
b0df654346 add heading level customization to callout component to fix a11y issue 2023-04-11 16:32:57 +02:00
Lisa Durand
bc3e67ab94 add alert on user dashboard to edit last editable dossier 2023-04-11 15:50:17 +02:00
Eric Leroy-Terquem
eda48567ef fix link for csv example file 2023-04-11 14:36:35 +02:00
Paul Chavard
def32a3615 chore(dossier): remove fallback from commune champ 2023-04-11 10:49:01 +02:00
Colin Darie
54c9690289
Merge pull request #8886 from colinux/fix-delete-admin-without-published-procedure
fix(admin): peut supprimer un admin sans démarche publiée, sans service
2023-04-11 07:17:54 +00:00
Colin Darie
a413d2fa9c fix(admin): can delete an admin without published procedure 2023-04-07 16:10:10 +02:00
Paul Chavard
a6e3ea4839 fix(dossier): normalize champs commune data 2023-04-07 16:02:13 +02:00
Paul Chavard
0d1aa5cf96
Merge pull request #8867 from tchak/feat-graphql-commune-type
feat(graphql): expose commune and departement information on address
2023-04-07 10:35:32 +00:00
Paul Chavard
aaae3f461d feat(graphql): expose commune and departement information on address 2023-04-07 12:13:41 +02:00
Paul Chavard
207ce21327 fix(dossier): instructeur actions should be buttons and not links 2023-04-07 12:12:15 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
79fee39888
Merge pull request #8872 from tchak/fix-champ-multiselect
fix(dossier): selecting blank option should not empty selection
2023-04-06 14:32:35 +00:00
Paul Chavard
ffb332159f fix(dossier): selecting blank option should not empty selection 2023-04-06 15:24:52 +02:00
Paul Chavard
a2f7d1df72 fix(graphql): pendingDeletedSince should not crash 2023-04-06 15:07:48 +02:00
Paul Chavard
f9b7859bf7
Merge pull request #8868 from tchak/fix-api-entreprise-adapter
fix(api-entreprise): do not crash when siret not found
2023-04-06 10:00:59 +00:00
Paul Chavard
7ea443f86a
Merge pull request #8860 from demarches-simplifiees/ay11-actions-multiples
[a11y] actions multiples
2023-04-05 16:41:06 +00:00
Paul Chavard
d1d5bc2e67 fix(api-entreprise): do not crash when siret not found 2023-04-05 18:38:13 +02:00
Paul Chavard
6511836f2d
Merge pull request #8865 from tchak/graphql-improuve-logs
feat(graphql): improuve logs
2023-04-05 12:34:36 +00:00
Paul Chavard
a5733002ed feat(graphql): improuve logs 2023-04-05 13:56:26 +02:00
Paul Chavard
b8f639721e
Merge pull request #8864 from colinux/fix-date-not-parseable
fix(date): ne crash pas lorsqu'un champ date n'as pas une date standard
2023-04-05 11:48:48 +00:00
Colin Darie
5e62aa7d21 fix(date): don't crash when date value is not parseable 2023-04-05 12:42:28 +02:00
Paul Chavard
52c8b0b297 feat(dossier): use turbo to select linked dossier 2023-04-05 11:40:03 +02:00
Paul Chavard
dee0952b2a fix(graphql): demandeur personne morale can be in degraded mode 2023-04-05 11:20:18 +02:00
Lisa Durand
058f1fe6e5 add focus on button when select all 2023-04-05 10:59:59 +02:00
Lisa Durand
c9d21f2b4d add dossier id in checkbox aria-label 2023-04-05 10:40:20 +02:00
Lisa Durand
f1c313eb49 add 'scope: col' to table th 2023-04-05 10:13:34 +02:00
Lisa Durand
9065e57e62 add aria-sort on sortable column 2023-04-05 10:05:51 +02:00
Paul Chavard
020f501a02
Merge pull request #8846 from tchak/fix-graphql-accepter
fix(graphql): return better errors when dossiers cannot change state
2023-04-04 15:42:54 +00:00
Paul Chavard
a778e1083b fix(graphql): return better errors when dossiers cannot change state 2023-04-04 17:24:30 +02:00
krichtof
7250c0cca7
Merge pull request #8855 from demarches-simplifiees/8854-manager-zones
WIP [manager] affiche les zones d'une procédure donnée
2023-04-04 14:50:38 +00:00
Christophe Robillard
7d94d321e9 [manager] display zones for a procedure 2023-04-04 16:36:04 +02:00
Martin
75657b5484 correctif(administrateur.merge): la fusion de compte entre admin devrait dissocie les services des procedures supprimées 2023-04-04 16:29:24 +02:00
Lisa Durand
6b1ecde852 add role status 2023-04-04 16:04:00 +02:00
Paul Chavard
2a48228552 fix(dossier): improuve commune champ rendering in pdf 2023-04-04 16:01:16 +02:00
Paul Chavard
ed33f1916a fix(commune): to_s should always return a string 2023-04-04 15:32:03 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
Paul Chavard
e2d5834dc2
Update app/models/user.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-04-04 15:02:20 +02:00
Lisa Durand
96740152c8
Merge pull request #8852 from demarches-simplifiees/bug-display-btn-logique-conditionnelle
[bug] Changer couleur de fond pour faire apparaitre bouton conditionnelle sur les sections
2023-04-04 09:10:03 +00:00
Paul Chavard
750be8d735
Merge pull request #8849 from demarches-simplifiees/8589-accessibility-environment
a11y : add mobile environment test to accessibility statement
2023-04-04 08:49:44 +00:00
mfo
2c32e38383
Merge pull request #8851 from demarches-simplifiees/fix_condtion_check_on_children
fix(condition_check_on_children): give proper upper tdc to child cond…
2023-04-04 08:48:02 +00:00
Lisa Durand
b1e9fca9b2 add lighter blue for section type background 2023-04-04 10:36:32 +02:00
simon lehericey
fd927fd116 fix(condition_check_on_children): give proper upper tdc to child condition check 2023-04-04 10:24:11 +02:00
Lisa Durand
dde64415ae
Merge pull request #8845 from demarches-simplifiees/remove-dossiers-termines-from-avis-views
[bug] retirer les notifications + compteur des avis pour les dossiers terminés
2023-04-04 08:20:48 +00:00
Julie Salha
0d9beaa223 add mobile environment test 2023-04-04 08:36:43 +02:00
Paul Chavard
0864666d0a fix(dossier): an invited user can remove (leave) a dossier 2023-04-03 20:10:44 +02:00
Lisa Durand
2f012578eb remove dossier termine from avis views 2023-04-03 18:20:17 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
Paul Chavard
b3f58a24cb fix(dossier): add value_json to dossier projection 2023-04-03 16:25:32 +02:00
Paul Chavard
8945777b56
Merge pull request #8835 from tchak/fix-champ-commune
fix(commune): improuve label and error message
2023-04-03 09:56:57 +00:00
Paul Chavard
b0673c0127
Merge pull request #8837 from demarches-simplifiees/bug-special-character-in-email
[fix] bug dans le sujet des mails de notification si le libelle de la procedure contient un apostrophe
2023-04-03 09:39:13 +00:00
Paul Chavard
ed62d171ce fix(commune): improuve label and error message 2023-04-03 11:24:32 +02:00
mfo
4336184fc8
Merge pull request #8833 from mfo/US/fix-valid-conditions-on-repetition
correctif(revision.validation-des-conditions): les conditions dans un bloc répétable ne remontenpt pas dans le composant ErrorsSummary
2023-03-31 15:03:12 +00:00
Lisa Durand
e1260a3df8 fix wrong encoding of special character in email notification subject 2023-03-31 16:58:41 +02:00
mfo
54d88e7dd0
Merge pull request #8699 from mfo/US/8661
a11y(bloc-repetable): amélioration des interactions avec les répétitions d'un bloc répétable
2023-03-31 14:39:23 +00:00