Paul Chavard
179bb5a9fe
Apply suggestions from code review
...
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2021-05-25 11:43:38 +02:00
Paul Chavard
acb277e650
Use stable_id when replacing tags
2021-05-25 11:43:38 +02:00
Pierre de La Morinerie
75a1046315
active_storage: refactor concerns
...
Follow-up of #5953 .
Refactor the concerns with two goals:
- Getting closer from the way ActiveStorage adds its own hooks.
Usually ActiveStorage does this using an `Attachment#after_create`
hook, which then delegates to the blob to enqueue the job.
- Enqueuing each job only once. By hooking on `Attachment#after_create`,
we guarantee each job will be added only once.
We then let the jobs themselves check if they are relevant or not, and
retry or discard themselves if necessary.
We also need to update the tests a bit, because Rails'
`perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on`
clause of jobs. Instead it forwards the exception to the caller – which
makes the test fail.
Instead we use the inline version of `perform_enqueued_jobs()`, without
a block, which properly ignores errors catched by retry_on.
2021-03-16 11:49:14 +01:00
Pierre de La Morinerie
2f948f7e46
active_storage: fix blob update hooks
...
For some reason on Rails 6.1 the `after_update_commit` hook is properly
registered – but disappears from the record later, and in the end is
never run.
Fix it by using the general `after_commit` hook instead.
2021-03-04 14:30:38 +01:00
Paul Chavard
3c6e30a326
Show titre identite link only once watermark is added
2020-12-10 16:50:03 +01:00
Paul Chavard
b48e7813d2
Put watermark code behind a feature flag
2020-11-25 16:19:06 +01:00
Paul Chavard
371179dc5b
Watermark titres identite
2020-11-25 16:19:06 +01:00
kara Diaby
ae61c279af
migrate emails text editor to new interface
2020-09-03 14:42:22 +02:00
Paul Chavard
6a24c3f812
Rails app:update
2020-07-07 18:03:56 +02:00
clemkeirua
48d2093577
tag 'groupe instructeur' uniquement si la procedure est routee
2020-02-20 14:48:14 +00:00
clemkeirua
059d80ea34
#4785 ajout d'une balise 'groupe instructeur'
2020-02-20 14:48:14 +00:00
Paul Chavard
cccb04d725
ActiveStorage url should expire after an hour
2020-01-08 14:43:05 +01:00
Nicolas Bouilleaud
0c98f29d59
Move the cached procedure stats queries to a ProcedureStatsConcern
2019-09-17 16:43:48 +02:00
Paul Chavard
3b8d3b7967
Add Style/CollectionMethods to rubocop
2019-09-12 14:48:18 +02:00
simon lehericey
dab1519b8c
Remove credenticals synchronisation logic
2019-08-16 11:35:19 +02:00
simon lehericey
3fde2a6f70
Rename gestionnaire in code to instructeur
2019-08-12 13:47:01 +02:00
Pierre de La Morinerie
8313752663
mailers: add CTA to templated emails
2019-07-25 12:25:50 +02:00
clemkeirua
7eeddc0b79
using a shared example + scoped to state TERMINE
2019-07-17 11:53:16 +02:00
clemkeirua
b8fa567c81
ajout du tag 'lien document justificatif'
2019-07-17 11:53:16 +02:00
Mathieu Magnin
10d3ba10f2
Before save copy body in rich_body
2019-07-03 13:15:49 +02:00
Mathieu Magnin
d13b7f953f
Migrate mail body to ActionText
2019-07-03 13:15:49 +02:00
Pierre de La Morinerie
d410e31344
active_storage: document the virus scan hooks
2019-05-28 11:39:22 +02:00
Paul Chavard
42235e81b1
Use active storage load hook to extend blob
2019-05-16 20:43:01 +02:00
clemkeirua
d0794f42d1
fix tag_substitution_concern links for lien attestation
2019-05-07 08:54:29 +02:00
clemkeirua
0e26bda186
cleanup the tag substitution concern & uniformization
2019-05-07 08:54:29 +02:00
clemkeirua
e4259466b4
nettoyage du tag_substitution_concern
2019-05-07 08:54:29 +02:00
clemkeirua
f8a2598647
ajout du lien vers le justificatif dans la balise --lien attestation--
2019-05-07 08:54:29 +02:00
Paul Chavard
f113d108c9
Save virus scan status to blob metadata
2019-05-02 15:58:09 +02:00
clemkeirua
0d71120f98
[ fix #306 ] Possibilité de joindre un document à un avis
2019-03-28 15:45:14 +01:00
Frederic Merizen
0ba3515d41
[ #3477 ] Filter by 'column ilike values' as a scope
2019-03-11 17:14:17 +01:00
Frederic Merizen
a87e3ac697
[ #3477 ] Make filtering by datetimes a proper scope
2019-03-11 17:14:17 +01:00
clemkeirua
236f73f838
ajout d'une balise pour le nom du service
2019-02-21 12:18:44 +01:00
simon lehericey
0b8619be77
Gestionnaire: login_token! -> create_trusted_device_token
2019-02-18 17:21:46 +01:00
simon lehericey
7de3a18fd1
valid period depend on trusted_device_token.created_at
2019-02-18 17:20:49 +01:00
simon lehericey
bee9a108c5
split login and trusted_device logic
2019-02-18 17:20:00 +01:00
Frederic Merizen
4a3d402a32
[ #3356 ] No need for special treatment
2019-02-05 17:35:30 +01:00
Frederic Merizen
a8b9da9d3b
[ #3356 ] Remove redundant method
2019-02-05 17:35:30 +01:00
Frederic Merizen
5bc8bbbaa2
[ #3356 ] Let tags handle their own substitution
2019-02-05 17:35:30 +01:00
Frederic Merizen
656061b21a
[ #3356 ] Clarify naming
2019-02-05 17:35:30 +01:00
Frederic Merizen
140a65cb36
[ #3356 ] Simplify detection of handling champ
2019-02-05 17:35:30 +01:00
Frederic Merizen
bcfc0f2535
[ #3356 ] Let types de champ decide their tags
2019-02-05 17:35:30 +01:00
Frederic Merizen
d67af741d5
[ #3356 ] Prepare for multiples tags per type de champ
2019-02-05 17:35:30 +01:00
simon lehericey
41ae1f46f4
Trusted_device: cleaner time comparison
2019-02-01 10:54:20 +01:00
gregoirenovel
5fa5f2aa37
Bump development gems
...
- rubocop (0.61.1 → 0.62.0)
2019-01-05 11:47:55 +01:00
gregoirenovel
fba8d97256
Enable the Stlye/BlockDelimiters cop
2018-12-19 13:56:10 +01:00
simon lehericey
0d8d2de5a6
Session: add trusted_device cookie
2018-11-13 10:41:45 +01:00
simon lehericey
3dad743d56
remove localtime as it uses server timezone
2018-10-26 10:10:20 +00:00
Pierre de La Morinerie
0526551e71
templates: update link to dossier
2018-09-27 17:22:59 +02:00
gregoirenovel
0c9628c180
Fix some files according the the .editorconfig rules
2018-09-20 16:23:09 +02:00
gregoirenovel
00ecae5f93
Procédure → Démarche
2018-09-05 15:46:24 +02:00
gregoirenovel
4b071ecf06
Use enum to the fullest with Dossier.states
2018-08-29 17:31:08 +02:00
gregoirenovel
4d41381155
Move the attestation route inside the member block
2018-07-17 17:26:42 +02:00
Paul Chavard
753a81c2d3
Update tag substitution concern
2018-05-24 17:54:51 +02:00
Frederic Merizen
db0937d1eb
[ #1563 ] Allow default template name to depend on procedure
2018-04-04 10:44:40 +02:00
Frederic Merizen
7bf7347b9c
[ #1563 ] Clarify constant’s role
2018-04-04 10:44:40 +02:00
Frederic Merizen
66aca60957
[ #1563 ] Remove useless self keywords
2018-04-04 10:44:40 +02:00
Frederic Merizen
84c864ed11
[ #1563 ] Add lien attestation link to closed mail template
2018-04-04 09:34:04 +02:00
Frederic Merizen
abf938ff1b
[ #1563 ] Generalise external link generation for mails
2018-04-04 09:34:04 +02:00
Mathieu Magnin
b7de632d6c
[ Fix #1479 ] Create a sanitize email concern
2018-03-14 17:41:45 +01:00
gregoirenovel
29d9b03672
Bump rails to 5.2.0.rc1
2018-02-07 16:18:42 +01:00
Frederic Merizen
9b4ce1517c
Use lambda instead of send for etablissement tag
2018-01-18 18:35:07 +01:00
Frederic Merizen
8f41ab89cf
[ #1203 ] Do not include champs privés in accusé de réception
2018-01-18 18:26:14 +01:00
Frederic Merizen
a21dee680d
[ #1203 ] Define tags in constants rather than methods
2018-01-18 18:26:14 +01:00
Frederic Merizen
db5bf39e32
[ #1203 ] No implicit available_for_states, make it explicit
2018-01-18 18:26:14 +01:00
Frederic Merizen
21ad13cf74
[ #1203 ] Make all tags multi-line
2018-01-18 18:26:14 +01:00
Frederic Merizen
943fef3160
[ #1203 ] Move all tag definitions to mail template concern
...
Even the one that is mail-specific, because it is too easy to overlook
it when refactoring otherwise
2018-01-18 18:26:14 +01:00
Frederic Merizen
eebab14954
[ Fix #1203 ] No début d’instruction tag in accusé de réception mails
...
Doesn’t make sense functionnally
2018-01-18 18:26:14 +01:00
Frederic Merizen
9f7ffddb31
[ #1203 ] Allow filtering tags based on an arbitray status
2018-01-18 18:26:14 +01:00
gregoirenovel
14c1747645
Enable the Layout/MultilineArrayBraceLayout cop
2018-01-15 22:33:13 +01:00
gregoirenovel
1e71188d4d
Enable the Layout/IndentationConsistency cop
2018-01-15 22:33:13 +01:00
gregoirenovel
9f855afdfe
Enable the Layout/FirstHashElementLineBreak cop
2018-01-15 22:14:38 +01:00
gregoirenovel
08ed400ec2
Enable the Layout/FirstArrayElementLineBreak cop
2018-01-15 22:14:38 +01:00
Frederic Merizen
56749769d6
[ Fix #1186 ] Rename object to subject for mail templates
2018-01-09 16:00:31 +01:00
Frederic Merizen
7f040a5cf8
[ Fix #1037 ] Add date tags to mail / attestation templates
...
- date de dépôt
- date de passage en instruction
2018-01-09 11:30:54 +01:00
Frederic Merizen
935a38bde0
[ #1037 ] Introduce format-date function
2018-01-09 11:30:54 +01:00
Frederic Merizen
63ca52792b
[ #1110 ] Remove legacy tags
2018-01-09 10:39:10 +01:00
Frederic Merizen
deea23139f
[ #1110 ] Use TagsSubstitutionConcern as engine for mail template tags
2018-01-05 17:42:25 +01:00
Frederic Merizen
ab63f80080
[ #1110 ] Motivation and date de décision are only tags for terminé dossiers
2018-01-05 16:35:29 +01:00
Frederic Merizen
e985439416
[ #1110 ] Use tags method rather than ALLOWED_TAGS class constant
2018-01-05 12:48:07 +01:00
Frederic Merizen
b9a1f707f5
[ #1110 ] name => libelle in mail templates
...
to match attestation templates
2018-01-05 12:48:07 +01:00
Frederic Merizen
8d77cd58c6
[ #1110 ] Make linked procedure available to mail model
2018-01-05 12:48:07 +01:00
Frederic Merizen
ad0462f7ff
[ #1110 ] Port libellé procédure tag from mail templates
2018-01-05 11:51:08 +01:00
Frederic Merizen
ee109b24e3
[ #1110 ] Port date de décision tag from mail templates
2018-01-05 11:51:08 +01:00
Frederic Merizen
3dfc37826a
[ #1110 ] Extract document template concern from attestation template class
2018-01-05 10:57:27 +01:00
Mathieu Magnin
02c83766e5
[ Fix #839 ] Fix mail template modification by side effect
2017-10-23 14:36:52 +02:00
Simon Lehericey
62f1b9c712
Rubocop: enable indentation width rule
2017-08-28 12:20:58 +02:00
gregoirenovel
0120995533
[ Fix #197 ] Add the TAG_MOTIVATION email tag
2017-06-13 15:14:50 +02:00
gregoirenovel
f1d66e40c3
Enable the Layout/EmptyLinesAroundModuleBody cop
2017-06-13 10:35:34 +02:00
gregoirenovel
585a5bcaba
Add TEMPLATE_NAME to Mail classes
2017-06-08 12:22:49 +02:00
gregoirenovel
07ea0ceea1
Make MailTemplateConcern.slug a constant
2017-06-08 12:22:44 +02:00
gregoirenovel
5a59115df4
Refactor the TAGS management in MailTemplateConcern
2017-06-08 12:22:36 +02:00
Simon Lehericey
cebb197994
Fix #171 : add localtime to a bunch of date
2017-05-11 15:10:49 +02:00
gregoirenovel
2582b44f07
[ Fix #204 ] Add the date_de_decision tag
2017-05-04 16:17:53 +02:00
gregoirenovel
3bd5e32dff
Add a system to restrain the email templates tags to specific templates
2017-05-04 16:17:39 +02:00
gregoirenovel
30cf475485
Add missing brackets in mail_template_concern.rb
2017-05-04 16:17:39 +02:00
gregoirenovel
f389bbeb53
Fix indentation in mail_template_concern.rb
2017-05-04 16:17:38 +02:00
Mathieu Magnin
4ea7635dfc
Fix after review
2017-03-07 16:23:44 +01:00
Simon Lehericey
65e83dd6ec
Mails: factorize default and change slug
2017-03-07 10:27:14 +01:00
Simon Lehericey
695dc16b85
Mails: add refused, without_continuation, draft, closed, received mails object
2017-03-07 10:27:05 +01:00
Mathieu Magnin
aa88fad777
Sync password after login
2017-02-07 16:56:21 +01:00
Xavier J
b5b83e939a
First Commit
2015-08-10 11:05:06 +02:00
