Commit graph

3647 commits

Author SHA1 Message Date
LeSim
154181d793
Merge pull request #1264 from betagouv/partially_clean_fc_part2
Partially clean fc part2
2018-01-17 16:55:30 +01:00
Simon Lehericey
1b91641f9a FC ParticulierController: remove exotic route 2018-01-17 16:37:26 +01:00
Simon Lehericey
d70b6f4af0 FC ParticulierController: cleaner update attribute 2018-01-17 16:37:26 +01:00
Simon Lehericey
2651c5e029 FC ParticulierControllerSpec: final clean 2018-01-17 16:37:26 +01:00
Simon Lehericey
69c121a879 FC ParticulierControllerSpec: simplify ... well you know 2018-01-17 16:37:26 +01:00
Simon Lehericey
570f779bb2 FC ParticulierControllerSpec: without an associate user, better test 2018-01-17 16:37:26 +01:00
Simon Lehericey
b2f59e2b14 FC ParticulierControllerSpec: simplify without an associate user 2018-01-17 16:37:26 +01:00
Simon Lehericey
e1ac33f420 FC ParticulierControllerSpec: simplifier with an associate user case 2018-01-17 16:37:26 +01:00
Simon Lehericey
49f5d570ed FC ParticulierControllerSpec: mutualize subject 2018-01-17 16:37:26 +01:00
Simon Lehericey
ab02f796b3 FC ParticulierControllerSpec: one liner expectation 2018-01-17 16:37:26 +01:00
Simon Lehericey
4008d8e44d FC ParticulierControllerSpec: remove unless context 2018-01-17 16:37:26 +01:00
Simon Lehericey
28bf45e536 FC ParticulierControllerSpec: use controller to store_location 2018-01-17 16:37:26 +01:00
Simon Lehericey
ab116895b7 FC ParticulierControllerSpec: remove one context 2018-01-17 16:37:26 +01:00
simon lehericey
4f86b6305b FC ParticulierControllerSpec: callback handle empty string 2018-01-17 16:37:26 +01:00
simon lehericey
9b6b6bde97 FC ParticulierControllerSpec: simplier auth spec 2018-01-17 16:37:26 +01:00
simon lehericey
02dd1e209c FC ParticulierController: implement auto reconciliation based on user email 2018-01-17 16:37:26 +01:00
simon lehericey
ecfb0f4ec2 FC ParticulierController: move defense logic to before_action 2018-01-17 16:37:26 +01:00
Simon Lehericey
4afc41bca2 FC ParticulierController: inline fci.user 2018-01-17 16:37:26 +01:00
simon lehericey
d348e5fde0 FC ParticulierController: smaller variable 2018-01-17 16:37:26 +01:00
simon lehericey
c6c4dd7c7e FC ParticulierController: use find or tap 2018-01-17 16:37:26 +01:00
simon lehericey
7cbd6ed067 FC ParticulierController: create is private
yep, I know this is strange
2018-01-17 16:37:26 +01:00
LeSim
d2f93b3441
Merge pull request #1271 from betagouv/rubocop-options
Set the RunRailsCops option in the rubocop config
2018-01-17 10:31:25 +01:00
gregoirenovel
d5f55cb360 Set the RunRailsCops option in the rubocop config
Instead of relying on a flag
2018-01-16 20:04:54 +01:00
gregoirenovel
c76097ef55
Merge pull request #1268 from betagouv/fix-readme
Fix readme
2018-01-16 19:54:24 +01:00
gregoirenovel
1ac6b78e13 Remove trailing whitespace 2018-01-16 17:59:01 +01:00
gregoirenovel
55f41f3786 Add missing requirements to FIXME 2018-01-16 17:58:53 +01:00
gregoirenovel
f829ee3926
Merge pull request #1265 from betagouv/fix-redirect-route
Fix an incorrect legacy route
2018-01-16 16:34:07 +01:00
gregoirenovel
a6b60faf9b [Fix #1266] Fix an incorrect legacy route redirection 2018-01-16 16:29:53 +01:00
Paul Chavard
23e0655a80
Merge pull request #1163 from tchak/use-headless-chrome
Use capybara-selenium with headless chrome
2018-01-16 14:24:34 +01:00
Paul Chavard
6a43248cb3 Fix CSS injection 2018-01-16 14:02:10 +01:00
Paul Chavard
a6cdf714a6 Use capybara-selenium with headless chrome 2018-01-16 14:02:10 +01:00
gregoirenovel
a709bd3fb3
Merge pull request #1258 from betagouv/better-methods
Better methods
2018-01-16 13:31:26 +01:00
gregoirenovel
7c93b2a0c2 .map -> .pluck when possible 2018-01-16 13:23:29 +01:00
gregoirenovel
80ed589a17 Use string interpolation 2018-01-16 11:08:57 +01:00
gregoirenovel
83be054884 .map.flatten -> .flat_map 2018-01-16 11:08:56 +01:00
gregoirenovel
c3754a173f Use map instead of inject 2018-01-16 11:08:56 +01:00
gregoirenovel
490a6dee4c
Merge pull request #1257 from betagouv/fix-1199
[Fix #1199] Implement id search for experts
2018-01-16 11:08:29 +01:00
gregoirenovel
16254899e1 [Fix #1199] Make id search work for experts 2018-01-16 11:03:53 +01:00
gregoirenovel
d33d488db7 Avoid EOL if statements 2018-01-16 11:01:52 +01:00
gregoirenovel
a050bc20de Add a dossiers_from_avis relation to Gestionnaire 2018-01-16 11:01:52 +01:00
gregoirenovel
4c0b273e97
Merge pull request #1165 from tchak/create-admins-with-no-passwords
Create admins with no passwords
2018-01-16 11:00:58 +01:00
Paul Chavard
bbf55ab85e Create administrateurs with invitation link and no password 2018-01-16 10:49:07 +01:00
Paul Chavard
0cf40f4f18 Add invitation related methods to administrateur model 2018-01-16 10:49:07 +01:00
Paul Chavard
5a984a3637 Add admin invitation mailer 2018-01-16 10:49:07 +01:00
Paul Chavard
8688d62a24 Add active attribute to administrateur model 2018-01-16 10:49:07 +01:00
gregoirenovel
d6f9736e36
Merge pull request #1256 from betagouv/rubocop
Rubocop
2018-01-16 10:42:05 +01:00
gregoirenovel
727c40ad35 Enable the Layout/RescueEnsureAlignment cop 2018-01-15 22:33:14 +01:00
gregoirenovel
084ee98ab2 Enable the Layout/MultilineMethodDefinitionBraceLayout cop 2018-01-15 22:33:14 +01:00
gregoirenovel
73dd58b6cd Enable the Layout/MultilineMethodCallIndentation cop 2018-01-15 22:33:13 +01:00
gregoirenovel
b77837bfd1 Enable the Layout/MultilineMethodCallBraceLayout cop 2018-01-15 22:33:13 +01:00